tor-browser

commit d24adae695d5634debc7e073627be3ace5924f20
parent 4044d84ca7717ee4d66f51ace6696b3aaf265e5a
Author: Mark Banner <standard8@mozilla.com>
Date:   Fri,  7 Nov 2025 16:28:04 +0000

Bug 1997259 - Ensure the Learn More link for the Retrieve checkbox in Suggest preferences is hidden when the checkbox is hidden. r=adw,mconley

Differential Revision: https://phabricator.services.mozilla.com/D271401

Diffstat:
M
browser/components/preferences/search.inc.xhtml
 | 
3
++-
M
browser/components/preferences/search.js
 | 
2
+-
M
browser/components/preferences/tests/browser_search_firefoxSuggest.js
 | 
3
+++

3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/browser/components/preferences/search.inc.xhtml b/browser/components/preferences/search.inc.xhtml
@@ -129,7 +129,8 @@
                       class="tail-with-learn-more"
                       data-l10n-id="addressbar-firefox-suggest-online"
                       preference="browser.urlbar.quicksuggest.online.enabled" />
-            <html:a is="moz-support-link"
+            <html:a id="firefoxSuggestOnlineEnabledLearnMore"
+                    is="moz-support-link"
                     data-l10n-id="addressbar-quickactions-learn-more"
                     support-page="firefox-suggest#w_what-is-firefox-suggest"
             />
diff --git a/browser/components/preferences/search.js b/browser/components/preferences/search.js
@@ -381,7 +381,7 @@ var gSearchPane = {
         .classList.add("tail-with-learn-more");
       document.getElementById("firefoxSuggestLearnMore").hidden = false;
 
-      document.getElementById("firefoxSuggestOnlineEnabledToggle").hidden =
+      document.getElementById("firefoxSuggestOnlineBox").hidden =
         UrlbarPrefs.get("quickSuggestSettingsUi") !=
         QuickSuggest.SETTINGS_UI.FULL;
 
diff --git a/browser/components/preferences/tests/browser_search_firefoxSuggest.js b/browser/components/preferences/tests/browser_search_firefoxSuggest.js
@@ -11,6 +11,7 @@ ChromeUtils.defineESModuleGetters(this, {
 
 const CONTAINER_ID = "firefoxSuggestContainer";
 const ONLINE_ENABLED_TOGGLE_ID = "firefoxSuggestOnlineEnabledToggle";
+const ONLINE_ENABLED_LEARN_MORE_ID = "firefoxSuggestOnlineEnabledLearnMore";
 const LEARN_MORE_ID = "firefoxSuggestLearnMore";
 const BUTTON_RESTORE_DISMISSED_ID = "restoreDismissedSuggestions";
 
@@ -21,6 +22,7 @@ const EXPECTED = {
     [LEARN_MORE_ID]: { isVisible: true },
     [CONTAINER_ID]: { isVisible: true },
     [ONLINE_ENABLED_TOGGLE_ID]: { isVisible: true },
+    [ONLINE_ENABLED_LEARN_MORE_ID]: { isVisible: true },
     locationBarGroupHeader: {
       isVisible: true,
       l10nId: "addressbar-header-firefox-suggest-1",
@@ -43,6 +45,7 @@ const EXPECTED = {
     [LEARN_MORE_ID]: { isVisible: true },
     [CONTAINER_ID]: { isVisible: true },
     [ONLINE_ENABLED_TOGGLE_ID]: { isVisible: false },
+    [ONLINE_ENABLED_LEARN_MORE_ID]: { isVisible: false },
     locationBarGroupHeader: {
       isVisible: true,
       l10nId: "addressbar-header-firefox-suggest-1",