tor-browser

commit d00bc1ffde28c73bb89ca543269db64ac701b1ed
parent b5a44b7649900dbc52cc81978cf1c51bf07e53f7
Author: Michael Froman <mfroman@mozilla.com>
Date:   Thu,  9 Oct 2025 13:16:00 -0500

Bug 1993083 - Vendor libwebrtc from dda01caff2

Upstream commit: https://webrtc.googlesource.com/src/+/dda01caff2974fd468819de2c6ec046af7ea999d
    stats: do not expose empty ice-ufrag on transport stats

    following the guidelines from
      https://w3c.github.io/webrtc-stats/#guidelines-for-implementing-stats-objects

    This came up during https://github.com/w3c/webrtc-stats/issues/804

    Bug: None
    Change-Id: I1360fc66d67d30f77d897e58f3741e4fac420c96
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/399960
    Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
    Commit-Queue: Philipp Hancke <phancke@meta.com>
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#45137}

Diffstat:
M
third_party/libwebrtc/README.mozilla.last-vendor
 | 
4
++--
M
third_party/libwebrtc/pc/rtc_stats_collector.cc
 | 
15
++++++++-------

2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
 # ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T18:14:46.148322+00:00.
+libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T18:15:50.589993+00:00.
 # base of lastest vendoring
-adecfb681f
+dda01caff2
diff --git a/third_party/libwebrtc/pc/rtc_stats_collector.cc b/third_party/libwebrtc/pc/rtc_stats_collector.cc
@@ -10,11 +10,9 @@
 
 #include "pc/rtc_stats_collector.h"
 
-#include <stdint.h>
-#include <stdio.h>
-
 #include <algorithm>
 #include <cstdint>
+#include <cstdio>
 #include <map>
 #include <memory>
 #include <optional>
@@ -86,8 +84,8 @@ namespace webrtc {
 
 namespace {
 
-const char kDirectionInbound = 'I';
-const char kDirectionOutbound = 'O';
+constexpr char kDirectionInbound = 'I';
+constexpr char kDirectionOutbound = 'O';
 
 constexpr char kAudioPlayoutSingletonId[] = "AP";
 
@@ -1972,8 +1970,11 @@ void RTCStatsCollector::ProduceTransportStats_n(
           channel_stats.ice_transport_stats.selected_candidate_pair_changes;
       channel_transport_stats->ice_role =
           IceRoleToRTCIceRole(channel_stats.ice_transport_stats.ice_role);
-      channel_transport_stats->ice_local_username_fragment =
-          channel_stats.ice_transport_stats.ice_local_username_fragment;
+      if (!channel_stats.ice_transport_stats.ice_local_username_fragment
+               .empty()) {
+        channel_transport_stats->ice_local_username_fragment =
+            channel_stats.ice_transport_stats.ice_local_username_fragment;
+      }
       channel_transport_stats->ice_state =
           IceTransportStateToRTCIceTransportState(
               channel_stats.ice_transport_stats.ice_state);