tor-browser

commit ce2bdcd89bf27fe8323747279b503f608cd92375
parent 2132f3bdad6086a3601dd4005ad176aafabb241b
Author: Beth Rennie <beth@brennie.ca>
Date:   Fri, 12 Dec 2025 19:25:12 +0000

Bug 2005640 - Do not attempt to record nimbus_targeting_environment.nimbus_targeting_environment when the metric is disabled r=nimbus-reviewers,relud

Differential Revision: https://phabricator.services.mozilla.com/D276099

Diffstat:
M
toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs
 | 
27
+++++++++++++++++++--------

1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs b/toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs
@@ -359,6 +359,12 @@ async function recordTargetingContextAttributes() {
     )
   ).ctx;
 
+  const recordAttrsEnabled =
+    lazy.NimbusFeatures.nimbusTelemetry.getVariable("gleanMetricConfiguration")
+      ?.metrics_enabled?.[
+      "nimbus_targeting_environment.targeting_context_value"
+    ] ?? false;
+
   const recordAttrs =
     lazy.NimbusFeatures.nimbusTelemetry.getVariable(
       "nimbusTargetingEnvironment"
@@ -370,7 +376,10 @@ async function recordTargetingContextAttributes() {
     try {
       const value = await transform(await context[attr]);
 
-      if (recordAttrs === null || recordAttrs.includes(attr)) {
+      if (
+        recordAttrsEnabled &&
+        (recordAttrs === null || recordAttrs.includes(attr))
+      ) {
         values[metric] = value;
       }
 
@@ -381,14 +390,16 @@ async function recordTargetingContextAttributes() {
     }
   }
 
-  let stringifiedCtx;
-  try {
-    stringifiedCtx = JSON.stringify(values);
-  } catch (ex) {
-    stringifiedCtx = "(JSON.stringify error)";
-  }
+  if (recordAttrsEnabled) {
+    let stringifiedCtx;
+    try {
+      stringifiedCtx = JSON.stringify(values);
+    } catch (ex) {
+      stringifiedCtx = "(JSON.stringify error)";
+    }
 
-  Glean.nimbusTargetingEnvironment.targetingContextValue.set(stringifiedCtx);
+    Glean.nimbusTargetingEnvironment.targetingContextValue.set(stringifiedCtx);
+  }
 }
 
 /**