commit ce1089cbbcb459374732695189fc42a12e388eed parent 8b1de3fc4be14fe3cfc3ff81ff3d02e4211decad Author: rmalicdem <rmalicdem@mozilla.com> Date: Mon, 8 Dec 2025 19:17:08 +0000 Bug 1993707 - Add site info action telemetry r=android-reviewers,Roger Differential Revision: https://phabricator.services.mozilla.com/D275311 Diffstat:
5 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/mobile/android/fenix/app/metrics.yaml b/mobile/android/fenix/app/metrics.yaml @@ -14373,7 +14373,7 @@ toolbar: add_new_tab, add_new_tab_long_press, add_new_private_tab, tab_counter, tab_counter_long_press, menu, share, clear, refresh, stop, add_bookmark, edit_bookmark, security_indicator, qr_code, home, reader_mode, microphone, open_in_fenix, close, site_custom, search_engine_selector, - search_engine_selected. + search_engine_selected, site_info. type: string extra: description: | diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarMiddleware.kt @@ -274,6 +274,7 @@ class BrowserToolbarMiddleware( is StartPageActions.SiteInfoClicked -> { onSiteInfoClicked() + next(action) } is MenuClicked -> { diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddleware.kt @@ -23,6 +23,7 @@ import org.mozilla.fenix.components.toolbar.DisplayActions.RefreshClicked import org.mozilla.fenix.components.toolbar.DisplayActions.ShareClicked import org.mozilla.fenix.components.toolbar.DisplayActions.StopRefreshClicked import org.mozilla.fenix.components.toolbar.PageEndActionsInteractions.ReaderModeClicked +import org.mozilla.fenix.components.toolbar.StartPageActions.SiteInfoClicked import org.mozilla.fenix.components.toolbar.TabCounterInteractions.AddNewPrivateTab import org.mozilla.fenix.components.toolbar.TabCounterInteractions.AddNewTab import org.mozilla.fenix.components.toolbar.TabCounterInteractions.TabCounterClicked @@ -40,6 +41,7 @@ import org.mozilla.fenix.telemetry.ACTION_NAVIGATE_FORWARD_LONG_CLICKED import org.mozilla.fenix.telemetry.ACTION_READER_MODE_CLICKED import org.mozilla.fenix.telemetry.ACTION_REFRESH_CLICKED import org.mozilla.fenix.telemetry.ACTION_SHARE_CLICKED +import org.mozilla.fenix.telemetry.ACTION_SITE_INFO_CLICKED import org.mozilla.fenix.telemetry.ACTION_STOP_CLICKED import org.mozilla.fenix.telemetry.ACTION_TAB_COUNTER_CLICKED import org.mozilla.fenix.telemetry.ACTION_TAB_COUNTER_LONG_CLICKED @@ -105,6 +107,9 @@ class BrowserToolbarTelemetryMiddleware : Middleware<BrowserToolbarState, Browse is HomepageClicked -> { trackToolbarEvent(ToolbarActionRecord.HomepageClicked, action.source) } + is SiteInfoClicked -> { + trackToolbarEvent(ToolbarActionRecord.SiteInfoClicked, action.source) + } else -> {} } @@ -129,6 +134,7 @@ class BrowserToolbarTelemetryMiddleware : Middleware<BrowserToolbarState, Browse data object ShareClicked : ToolbarActionRecord(ACTION_SHARE_CLICKED) data object ReaderModeClicked : ToolbarActionRecord(ACTION_READER_MODE_CLICKED) data object HomepageClicked : ToolbarActionRecord(ACTION_HOME_CLICKED) + data object SiteInfoClicked : ToolbarActionRecord(ACTION_SITE_INFO_CLICKED) } private fun trackToolbarEvent( diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/telemetry/ToolbarTelemetryConstants.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/telemetry/ToolbarTelemetryConstants.kt @@ -34,3 +34,4 @@ const val ACTION_SITE_CUSTOM_CLICKED = "site_custom" const val ACTION_STOP_CLICKED = "stop" const val ACTION_TAB_COUNTER_CLICKED = "tab_counter" const val ACTION_TAB_COUNTER_LONG_CLICKED = "tab_counter_long_press" +const val ACTION_SITE_INFO_CLICKED = "site_info" diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddlewareTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddlewareTest.kt @@ -25,6 +25,7 @@ import org.mozilla.fenix.components.toolbar.DisplayActions.NavigateForwardLongCl import org.mozilla.fenix.components.toolbar.DisplayActions.RefreshClicked import org.mozilla.fenix.components.toolbar.DisplayActions.ShareClicked import org.mozilla.fenix.components.toolbar.DisplayActions.StopRefreshClicked +import org.mozilla.fenix.components.toolbar.StartPageActions.SiteInfoClicked import org.mozilla.fenix.components.toolbar.TabCounterInteractions.AddNewPrivateTab import org.mozilla.fenix.components.toolbar.TabCounterInteractions.AddNewTab import org.mozilla.fenix.components.toolbar.TabCounterInteractions.TabCounterClicked @@ -146,6 +147,12 @@ class BrowserToolbarTelemetryMiddlewareTest { assertTelemetryRecorded(Source.NavigationBar, item = ToolbarActionRecord.ShareClicked.action) } + @Test + fun `WHEN site info is clicked THEN record addressBar telemetry`() { + buildStore.dispatch(SiteInfoClicked) + assertTelemetryRecorded(Source.AddressBar, item = ToolbarActionRecord.SiteInfoClicked.action) + } + private fun assertTelemetryRecorded( source: Source, item: String,