tor-browser

commit cb090e068f1346fb76f7426011cfcc1b8f6b4627
parent a98532809c01400552fcc943202cbdff47c8c1b9
Author: Tom Schuster <tschuster@mozilla.com>
Date:   Wed, 12 Nov 2025 14:03:21 +0000

Bug 1999506 - Favicon encoding depends on zlib usage in browser_aboutdebugging_tab_favicons.js. r=devtools-reviewers,tnikkel,nchevobbe

Differential Revision: https://phabricator.services.mozilla.com/D272222

Diffstat:
M
devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_tab_favicons.js
 | 
12
++++--------

1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_tab_favicons.js b/devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_tab_favicons.js
@@ -14,9 +14,10 @@ const TAB_URL =
   "https://example.com/browser/devtools/client/aboutdebugging/" +
   "test/browser/test-tab-favicons.html";
 
-// This is the same png data-url as the one used in test-tab-favicons.html.
-const EXPECTED_FAVICON =
-  "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAXElEQVRYR+3SMQoAIAxD0fb+h9ZBEM3SKfwlTkISeEN7Va16Xt/feV9oyDsAHKCdaeDIA2AB+BEGgAO0Mw0ceQAsAD/CAHCAdqaBIw+ABeBHGAAO0M40cOQBoIANOAOf8d5vwtsAAAAASUVORK5CYII=";
+// The favicon in the page is re-encoded, with different results depending on zlib-rs usage.
+const EXPECTED_FAVICON = AppConstants.USE_LIBZ_RS
+  ? "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAXElEQVRYR+3SMQoAIAxD0fb+h9ZBEM3SKfwlTkISeEN7Va16Xt/feV9oyDsAHKCdaeDIA2AB+BEGgAO0Mw0ceQAsAD/CAHCAdqaBIw+ABeBHGAAO0M40cOQBoIANOAOf8d5vwtsAAAAASUVORK5CYII="
+  : "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAV0lEQVRYR+2UMQ4AIAgD4f+P1m6KcVQ7eMZBJCHNUcgWoTtOzoHeJan4dD4RYCewtvl2z3f1yx8CnhOwmxABdgLsAQjYTYgAOwGmAAJ2EyLAToAp+J5ABzgDn/EwCmG5AAAAAElFTkSuQmCC";
 
 add_task(async function () {
   const faviconTab = await addTab(TAB_URL, { background: true });
@@ -39,11 +40,6 @@ add_task(async function () {
     ".qa-debug-target-item-icon"
   );
 
-  // Note this relies on PlaceUtils.favicons.getFaviconForPage() returning the
-  // favicon that has same data-url as the one provided in the test page. If the
-  // implementation changes and PlaceUtils returns a different base64 from the
-  // one we defined, we can instead load the image and check a few pixels to
-  // verify it matches the expected icon.
   is(
     faviconTabIcon.src,
     EXPECTED_FAVICON,