tor-browser

commit c9050affc08bad0c2fdaf9768f40c4929918d12e
parent 2d77cf0238790efea3aa341d0ef2d02b3526ab79
Author: Justin Link <jlink@mozilla.com>
Date:   Sun,  7 Dec 2025 09:31:00 +0000

Bug 2004401: Always set mCacheDisposition, even if not collecting telemetry r=necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D275319

Diffstat:
M
netwerk/protocol/http/nsHttpChannel.cpp
 | 
19
++++++++++---------

1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/netwerk/protocol/http/nsHttpChannel.cpp b/netwerk/protocol/http/nsHttpChannel.cpp
@@ -3498,17 +3498,18 @@ void nsHttpChannel::UpdateCacheDisposition(bool aSuccessfulReval,
       nsPrintfCString(
           !mDidReval ? "Missed"
                      : (aSuccessfulReval ? "HitViaReval" : "MissedViaReval")));
+  CacheDisposition cacheDisposition;
+  if (!mDidReval) {
+    cacheDisposition = kCacheMissed;
+  } else if (aSuccessfulReval) {
+    cacheDisposition = kCacheHitViaReval;
+  } else {
+    cacheDisposition = kCacheMissedViaReval;
+  }
+  mCacheDisposition = cacheDisposition;
+
   if (Telemetry::CanRecordPrereleaseData()) {
-    CacheDisposition cacheDisposition;
-    if (!mDidReval) {
-      cacheDisposition = kCacheMissed;
-    } else if (aSuccessfulReval) {
-      cacheDisposition = kCacheHitViaReval;
-    } else {
-      cacheDisposition = kCacheMissedViaReval;
-    }
     AccumulateCacheHitTelemetry(cacheDisposition, this);
-    mCacheDisposition = cacheDisposition;
   }
 
   ReportHttpResponseVersion(mResponseHead->Version());