commit c8bd25a6348db2e63c05d54bbf39ee99a610c035 parent 6f3ed88ca126ae6161fd6dae3f68f5a5a7da30b8 Author: Ryan VanderMeulen <rvandermeulen@mozilla.com> Date: Wed, 1 Oct 2025 11:47:20 +0000 Bug 1591064 - Enable ToolboxTask-using tests on ASAN. r=devtools-reviewers,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D266931 Diffstat:
5 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/devtools/client/debugger/test/mochitest/browser_aj.toml b/devtools/client/debugger/test/mochitest/browser_aj.toml @@ -26,10 +26,7 @@ prefs = [ ["browser_dbg-backgroundtask-debugging.js"] skip-if = [ - "os == 'linux' && os_version == '24.04' && processor == 'x86_64' && debug", # Bug 1591064 - "os == 'linux' && os_version == '24.04' && processor == 'x86_64' && display == 'x11' && asan", # Bug 1591064 "os == 'mac' && os_version == '14.70' && processor == 'x86_64'", # Bug 1937229 - "os == 'win' && os_version == '11.26100' && processor == 'x86_64' && asan", # Bug 1591064 ] ["browser_dbg-bfcache.js"] @@ -93,16 +90,12 @@ fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and ["browser_dbg-browser-toolbox-unselected-pause.js"] skip-if = [ - "os == 'linux' && os_version == '24.04' && processor == 'x86_64' && display == 'x11' && asan", # Bug 1591064 "os == 'mac' && os_version == '14.70' && processor == 'x86_64'", # Bug 1937315 - "os == 'win' && os_version == '11.26100' && processor == 'x86_64' && asan", # Bug 1591064 ] ["browser_dbg-browser-toolbox-workers.js"] skip-if = [ - "os == 'linux' && os_version == '24.04' && processor == 'x86_64' && display == 'x11' && asan", # Bug 1591064 "os == 'mac' && os_version == '14.70' && processor == 'x86_64'", # Bug 1767721 - "os == 'win' && os_version == '11.26100' && processor == 'x86_64' && asan", # Bug 1591064, parent intercept mode is needed ] ["browser_dbg-call-stack.js"] diff --git a/devtools/client/framework/browser-toolbox/test/browser.toml b/devtools/client/framework/browser-toolbox/test/browser.toml @@ -2,7 +2,6 @@ tags = "devtools" subsuite = "devtools" skip-if = [ - "asan", # UNTIL Bug 1591064 IS FIXED ALL NEW TESTS SHOULD BE SKIPPED ON ASAN "os == 'mac' && os_version == '14.70' && processor == 'x86_64'", # Bug 1937225 ] support-files = [ @@ -23,6 +22,7 @@ prefs = ["security.allow_unsafe_parent_loads=true"] # This is far from ideal. Bu ["browser_browser_toolbox.js"] ["browser_browser_toolbox_debugger.js"] +skip-if = ["asan"] # Bug 1991880 ["browser_browser_toolbox_evaluation_context.js"] diff --git a/devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js b/devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js @@ -34,13 +34,6 @@ const { * asserted to be 0 (success). */ async function initBrowserToolboxTask({ existingProcessClose } = {}) { - if (AppConstants.ASAN) { - ok( - false, - "ToolboxTask cannot be used on ASAN builds. This test should be skipped (Bug 1591064)." - ); - } - await pushPref("devtools.chrome.enabled", true); await pushPref("devtools.debugger.remote-enabled", true); await pushPref("devtools.browsertoolbox.enable-test-server", true); diff --git a/devtools/client/storage/test/browser.toml b/devtools/client/storage/test/browser.toml @@ -140,9 +140,7 @@ fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and ["browser_storage_indexeddb_hide_internal_dbs.js"] skip-if = [ - "os == 'linux' && os_version == '24.04' && processor == 'x86_64' && display == 'x11' && asan", # Bug 1591064 "os == 'mac' && os_version == '14.70' && processor == 'x86_64'", # Bug 1929421 - "os == 'win' && os_version == '11.26100' && processor == 'x86_64' && asan", # Bug 1591064 ] ["browser_storage_indexeddb_navigation.js"] diff --git a/devtools/client/styleeditor/test/browser.toml b/devtools/client/styleeditor/test/browser.toml @@ -219,7 +219,5 @@ fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and ["browser_toolbox_styleeditor.js"] skip-if = [ - "os == 'linux' && os_version == '24.04' && processor == 'x86_64' && display == 'x11' && asan", # Bug 1591064 "os == 'mac' && os_version == '14.70' && processor == 'x86_64'", # Bug 1929428 - "os == 'win' && os_version == '11.26100' && processor == 'x86_64' && asan", # Bug 1591064 ]