commit c72da1267a0e26fc5aba2a49cfb02fedc9d2c661 parent b02234f56834d7c2e6b5676e1395ee9991165610 Author: Roger Yang <royang@mozilla.com> Date: Mon, 10 Nov 2025 17:08:14 +0000 Bug 1994722 - Remove shortcut suggestions switch from search settings. r=android-reviewers,android-l10n-reviewers,petru,flod Differential Revision: https://phabricator.services.mozilla.com/D272002 Diffstat:
6 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/mobile/android/fenix/app/metrics.yaml b/mobile/android/fenix/app/metrics.yaml @@ -296,7 +296,7 @@ events: show_search_shortcuts, open_links_in_a_private_tab, pref_key_sync_logins, pref_key_sync_bookmarks, pref_key_sync_history, pref_key_show_voice_search, pref_key_show_search_suggestions_in_private, pref_key_show_trending_search_suggestions, - pref_key_show_recent_search_suggestions, pref_key_show_shortcuts_suggestions. + pref_key_show_recent_search_suggestions. type: string enabled: description: "Whether or not the preference is *now* enabled" diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -154,7 +154,6 @@ class SettingsFragment : PreferenceFragmentCompat() { getString(R.string.pref_key_show_search_suggestions_in_private), getString(R.string.pref_key_show_trending_search_suggestions), getString(R.string.pref_key_show_recent_search_suggestions), - getString(R.string.pref_key_show_shortcuts_suggestions), ) } diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt @@ -716,14 +716,6 @@ class Settings(private val appContext: Context) : PreferencesHolder { default = true, ) - /** - * Indicates if the user has enabled shortcuts in Firefox Suggest. - */ - val shortcutSuggestionsEnabled by booleanPreference( - appContext.getPreferenceKey(R.string.pref_key_show_shortcuts_suggestions), - default = false, - ) - val shouldShowSyncedTabsSuggestions by booleanPreference( appContext.getPreferenceKey(R.string.pref_key_search_synced_tabs), default = true, diff --git a/mobile/android/fenix/app/src/main/res/values/preference_keys.xml b/mobile/android/fenix/app/src/main/res/values/preference_keys.xml @@ -132,7 +132,6 @@ <string name="pref_key_show_clipboard_suggestions" translatable="false">pref_key_show_clipboard_suggestions</string> <string name="pref_key_search_browsing_history" translatable="false">pref_key_search_browsing_history</string> <string name="pref_key_search_bookmarks" translatable="false">pref_key_search_bookmarks</string> - <string name="pref_key_show_shortcuts_suggestions" translatable="false">pref_key_show_shortcuts_suggestions</string> <string name="pref_key_search_synced_tabs" translatable="false">pref_key_search_synced_tabs</string> <string name="pref_key_show_search_suggestions_in_private" translatable="false">pref_key_show_search_suggestions_in_private</string> <string name="pref_key_show_search_suggestions_in_private_onboarding" translatable="false">pref_key_show_search_suggestions_in_privateonboarding</string> diff --git a/mobile/android/fenix/app/src/main/res/values/strings.xml b/mobile/android/fenix/app/src/main/res/values/strings.xml @@ -773,7 +773,7 @@ <!-- Preference title for switch preference to suggest bookmarks when searching --> <string name="preferences_search_bookmarks">Search bookmarks</string> <!-- Preference title for switch preference to show shortcuts when searching --> - <string name="preferences_show_shortcuts">Show shortcuts</string> + <string name="preferences_show_shortcuts" tools:ignore="UnusedResources" moz:removedIn="147">Show shortcuts</string> <!-- Preference title for switch preference to suggest synced tabs when searching --> <string name="preferences_search_synced_tabs">Search synced tabs</string> <!-- Preference for account settings --> diff --git a/mobile/android/fenix/app/src/main/res/xml/search_settings_preferences.xml b/mobile/android/fenix/app/src/main/res/xml/search_settings_preferences.xml @@ -69,11 +69,6 @@ <SwitchPreference app:iconSpaceReserved="false" android:defaultValue="true" - android:key="@string/pref_key_show_shortcuts_suggestions" - android:title='@string/preferences_show_shortcuts' /> - <SwitchPreference - app:iconSpaceReserved="false" - android:defaultValue="true" android:key="@string/pref_key_search_synced_tabs" android:title='@string/preferences_search_synced_tabs' /> <SwitchPreference