commit c457bffaa5e5ece976f0939fcd0b472ed649e6e7
parent 227ca58dd353c9fdb1ae356a2502b4865e8ce847
Author: Mike Conley <mconley@mozilla.com>
Date: Mon, 6 Oct 2025 13:49:59 +0000
Bug 1988313 - Add back the ability to remember the persistent storage permission decision. r=emz,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D267114
Diffstat:
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/browser/locales/en-US/browser/permissions.ftl b/browser/locales/en-US/browser/permissions.ftl
@@ -0,0 +1,5 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
+# You can obtain one at http://mozilla.org/MPL/2.0/.
+
+perm-persistent-storage-remember = Remember this decision
diff --git a/browser/modules/PermissionUI.sys.mjs b/browser/modules/PermissionUI.sys.mjs
@@ -99,6 +99,10 @@ ChromeUtils.defineLazyGetter(lazy, "gBrowserBundle", function () {
);
});
+ChromeUtils.defineLazyGetter(lazy, "gFluentStrings", function () {
+ return new Localization(["browser/permissions.ftl"], true /* aSync */);
+});
+
import { SITEPERMS_ADDON_PROVIDER_PREF } from "resource://gre/modules/addons/siteperms-addon-utils.sys.mjs";
XPCOMUtils.defineLazyPreferenceGetter(
@@ -1339,11 +1343,25 @@ class PersistentStoragePermissionPrompt extends PermissionPromptForRequest {
let learnMoreURL =
Services.urlFormatter.formatURLPref("app.support.baseURL") +
"storage-permissions";
- return {
+ let options = {
learnMoreURL,
displayURI: false,
name: this.getPrincipalName(),
};
+
+ options.checkbox = {
+ show: !lazy.PrivateBrowsingUtils.isWindowPrivate(
+ this.browser.ownerGlobal
+ ),
+ };
+
+ if (options.checkbox.show) {
+ options.checkbox.label = lazy.gFluentStrings.formatValueSync(
+ "perm-persistent-storage-remember"
+ );
+ }
+
+ return options;
}
get notificationID() {