commit c43bc47baa1baaece42806227e6330d13030e829
parent c5e6d2ed8ad8a45a59cecef14d3374d60b34b575
Author: Thomas Wisniewski <twisniewski@mozilla.com>
Date: Thu, 16 Oct 2025 16:12:14 +0000
Bug 1979612 - remove our webcompat intervention for scroller.com; r=webcompat-reviewers,ksenia
Differential Revision: https://phabricator.services.mozilla.com/D268785
Diffstat:
3 files changed, 2 insertions(+), 59 deletions(-)
diff --git a/browser/extensions/webcompat/data/interventions.json b/browser/extensions/webcompat/data/interventions.json
@@ -5249,23 +5249,6 @@
}
]
},
- "1979612": {
- "label": "scrolller.com",
- "bugs": {
- "1979612": {
- "issue": "page-fails-to-load",
- "matches": ["*://scrolller.com/*"]
- }
- },
- "interventions": [
- {
- "platforms": ["all"],
- "content_scripts": {
- "js": ["bug1979612-scroller.com-shim-mozappearance.js"]
- }
- }
- ]
- },
"1980382": {
"label": "www.fidrec.com.sg",
"bugs": {
diff --git a/browser/extensions/webcompat/injections/js/bug1979612-scroller.com-shim-mozappearance.js b/browser/extensions/webcompat/injections/js/bug1979612-scroller.com-shim-mozappearance.js
@@ -1,32 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-"use strict";
-
-/*
- * Bug 1979612 - Override "MozAppearance" in element.style and return false
- * Webcompat issue #169020 - https://github.com/webcompat/web-bugs/issues/169020
- *
- * The site is detecting Firefox by checking for MozAppearance on the document element,
- * and refuses to load the page if it cannot be found. We can define it as "" to fix this.
- */
-
-/* globals exportFunction */
-
-console.info(
- "Overriding MozAppearance in element.style for compatibility reasons. See https://bugzilla.mozilla.org/show_bug.cgi?id=1979612 for details."
-);
-
-(function () {
- const ele = HTMLElement.wrappedJSObject.prototype;
- const obj = window.wrappedJSObject.Object;
- const style = obj.getOwnPropertyDescriptor(ele, "style");
- const { get } = style;
- style.get = exportFunction(function () {
- const styles = get.call(this);
- styles.MozAppearance = "";
- return styles;
- }, window);
- obj.defineProperty(ele, "style", style);
-})();
diff --git a/testing/webcompat/interventions/tests/test_1979612_scrolller_com.py b/testing/webcompat/interventions/tests/test_1979612_scrolller_com.py
@@ -7,16 +7,8 @@ UNSUPPORTED_CSS = "html#__next_error__"
@pytest.mark.asyncio
-@pytest.mark.with_interventions
-async def test_enabled(client):
+@pytest.mark.without_interventions
+async def test_regression(client):
await client.navigate(URL, wait="none")
assert client.await_css(SUPPORTED_CSS, is_displayed=True)
assert not client.find_css(UNSUPPORTED_CSS, is_displayed=True)
-
-
-@pytest.mark.asyncio
-@pytest.mark.without_interventions
-async def test_disabled(client):
- await client.navigate(URL, wait="none")
- assert client.await_css(UNSUPPORTED_CSS, is_displayed=True)
- assert not client.find_css(SUPPORTED_CSS, is_displayed=True)
