tor-browser

commit c377c528969e6acbe9b800a4d189710ae6ace550
parent 88c252a126c1e1f93d52e812c41431b51d8b3ca1
Author: serge-sans-paille <sguelton@mozilla.com>
Date:   Wed, 15 Oct 2025 05:40:43 +0000

Bug 1981981 - Move check_vanilla_allocations.py to js/src/build/moz.build r=glandium

Differential Revision: https://phabricator.services.mozilla.com/D260446

Diffstat:
M
js/src/build/Makefile.in
 | 
7
-------
M
js/src/build/moz.build
 | 
9
+++++++++
M
python/mozbuild/mozbuild/test/test_legacy_test.py
 | 
1
+

3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/js/src/build/Makefile.in b/js/src/build/Makefile.in
@@ -7,17 +7,10 @@
 include $(topsrcdir)/config/rules.mk
 
 ifdef NM
-# check_vanilla_allocations.py is tailored to Linux, so only run it there.
-# That should be enough to catch any problems.
-check-vanilla-allocations:
-	$(PYTHON3) $(topsrcdir)/config/check_vanilla_allocations.py $(REAL_LIBRARY)
-
 # The "aggressive" variant will likely fail on some compiler/platform
 # combinations, but is worth running by hand every once in a while.
 check-vanilla-allocations-aggressive:
 	$(PYTHON3) $(topsrcdir)/config/check_vanilla_allocations.py --aggressive $(REAL_LIBRARY)
-
-check:: check-vanilla-allocations
 endif
 
 $(LIBRARY_NAME).pc: js.pc
diff --git a/js/src/build/moz.build b/js/src/build/moz.build
@@ -122,3 +122,12 @@ if CONFIG["ENABLE_TESTS"] or CONFIG["JS_STANDALONE"]:
             "/config/check_js_opcode.py",
         ],
     )
+
+if CONFIG["NM"]:
+    # check_vanilla_allocations.py is tailored to Linux, so only run it there.
+    # That should be enough to catch any problems.
+    LegacyTest(
+        f"%{CONFIG['PYTHON3']}",
+        "/config/check_vanilla_allocations.py",
+        f"!lib{STATIC_LIBRARY_NAME}.a",
+    )
diff --git a/python/mozbuild/mozbuild/test/test_legacy_test.py b/python/mozbuild/mozbuild/test/test_legacy_test.py
@@ -11,6 +11,7 @@ import mozversioncontrol
 allowlist = {
     "ipc/ipdl/test/ipdl/moz.build",
     "js/src/moz.build",
+    "js/src/build/moz.build",
     "toolkit/xre/test/win/moz.build",
 }