tor-browser

commit c2b1b7cfc8891e6cc7a1716ffe523453ca395eed
parent 83b176a2d30d270fe1fa1444b07db300e5c4aab4
Author: Jari Jalkanen <jjalkanen@mozilla.com>
Date:   Mon, 13 Oct 2025 12:32:51 +0000

Bug 1924210 - Use const for immutable values in certain helpers. r=Jamie,layout-anchor-positioning-reviewers,firefox-style-system-reviewers,dshin

Differential Revision: https://phabricator.services.mozilla.com/D267835

Diffstat:
M
accessible/base/nsAccessibilityService.cpp
 | 
2
+-
M
accessible/base/nsCoreUtils.cpp
 | 
4
++--
M
accessible/base/nsCoreUtils.h
 | 
2
+-
M
accessible/generic/DocAccessible.cpp
 | 
2
+-
M
accessible/generic/LocalAccessible.cpp
 | 
5
+++--
M
layout/style/GeckoBindings.cpp
 | 
4
++--

6 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/accessible/base/nsAccessibilityService.cpp b/accessible/base/nsAccessibilityService.cpp
@@ -681,7 +681,7 @@ void nsAccessibilityService::NotifyAnchorPositionedRemoved(
     return;
   }
 
-  nsIFrame* anchorFrame =
+  const nsIFrame* anchorFrame =
       nsCoreUtils::GetAnchorForPositionedFrame(aPresShell, aFrame);
   if (!anchorFrame) {
     return;
diff --git a/accessible/base/nsCoreUtils.cpp b/accessible/base/nsCoreUtils.cpp
@@ -676,7 +676,7 @@ bool nsCoreUtils::IsTrimmedWhitespaceBeforeHardLineBreak(nsIFrame* aFrame) {
   return text.mString.IsEmpty();
 }
 
-nsIFrame* nsCoreUtils::GetAnchorForPositionedFrame(
+const nsIFrame* nsCoreUtils::GetAnchorForPositionedFrame(
     const PresShell* aPresShell, const nsIFrame* aPositionedFrame) {
   if (!aPositionedFrame ||
       !aPositionedFrame->Style()->HasAnchorPosReference()) {
@@ -691,7 +691,7 @@ nsIFrame* nsCoreUtils::GetAnchorForPositionedFrame(
     return nullptr;
   }
 
-  for (auto& entry : *referencedAnchors) {
+  for (const auto& entry : *referencedAnchors) {
     if (entry.GetData().isNothing()) {
       continue;
     }
diff --git a/accessible/base/nsCoreUtils.h b/accessible/base/nsCoreUtils.h
@@ -360,7 +360,7 @@ class nsCoreUtils {
    * 2. there is more than one anchor,
    * 3. or, there is one or more anchor used for sizing/margin only.
    */
-  static nsIFrame* GetAnchorForPositionedFrame(
+  static const nsIFrame* GetAnchorForPositionedFrame(
       const PresShell* aPresShell, const nsIFrame* aPositionedFrame);
 
   /**
diff --git a/accessible/generic/DocAccessible.cpp b/accessible/generic/DocAccessible.cpp
@@ -466,7 +466,7 @@ void DocAccessible::QueueCacheUpdateForDependentRelations(
     QueueCacheUpdate(relatedAcc, CacheDomain::Relations);
   }
 
-  if (nsIFrame* anchorFrame = nsCoreUtils::GetAnchorForPositionedFrame(
+  if (const nsIFrame* anchorFrame = nsCoreUtils::GetAnchorForPositionedFrame(
           mPresShell, aAcc->GetFrame())) {
     // If this accessible is anchored, retrieve the anchor and update its
     // relations.
diff --git a/accessible/generic/LocalAccessible.cpp b/accessible/generic/LocalAccessible.cpp
@@ -2408,8 +2408,9 @@ Relation LocalAccessible::RelationByType(RelationType aType) const {
       // Check early if the accessible is a tooltip. If so, it can never be a
       // valid target for an anchor's details relation.
       if (Role() != roles::TOOLTIP) {
-        if (nsIFrame* anchorFrame = nsCoreUtils::GetAnchorForPositionedFrame(
-                mDoc->PresShellPtr(), GetFrame())) {
+        if (const nsIFrame* anchorFrame =
+                nsCoreUtils::GetAnchorForPositionedFrame(mDoc->PresShellPtr(),
+                                                         GetFrame())) {
           LocalAccessible* anchorAcc =
               mDoc->GetAccessible(anchorFrame->GetContent());
           if (anchorAcc->GetAnchorPositionTargetDetailsRelation() == this &&
diff --git a/layout/style/GeckoBindings.cpp b/layout/style/GeckoBindings.cpp
@@ -1861,8 +1861,8 @@ static const nsAtom* GetUsedAnchorName(const nsIFrame* aPositioned,
   return stylePos->mPositionAnchor.AsIdent().AsAtom();
 }
 
-static nsIFrame* GetAnchorOf(const nsIFrame* aPositioned,
-                             const nsAtom* aAnchorName) {
+static const nsIFrame* GetAnchorOf(const nsIFrame* aPositioned,
+                                   const nsAtom* aAnchorName) {
   const auto* presShell = aPositioned->PresShell();
   MOZ_ASSERT(presShell, "No PresShell for frame?");
   return presShell->GetAnchorPosAnchor(aAnchorName, aPositioned);