tor-browser

commit c19da6e773a19e75b100f3819ce034eac43a10de
parent fbb87850f74eed36329a2b2a4dac99302b53094a
Author: Lorenz A <me@lorenzackermann.xyz>
Date:   Tue,  2 Dec 2025 07:55:25 +0000

Bug 1665702 - [devtools] Remove unused `idGenerator` argument of `networkMessageUpdates` action method. r=devtools-reviewers,nchevobbe

Seems like `idGenerator` was added to mirror messagesAdd but was never used

Differential Revision: https://phabricator.services.mozilla.com/D274645

Diffstat:
M
devtools/client/webconsole/actions/messages.js
 | 
10
++++------
M
devtools/client/webconsole/test/node/store/messages.test.js
 | 
12
++++++------
M
devtools/client/webconsole/test/node/store/network-messages.test.js
 | 
2
+-
M
devtools/client/webconsole/webconsole-wrapper.js
 | 
2
+-

4 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/devtools/client/webconsole/actions/messages.js b/devtools/client/webconsole/actions/messages.js
@@ -148,12 +148,10 @@ function messageRemove(id) {
   };
 }
 
-function networkMessageUpdates(packets, idGenerator = null) {
-  if (idGenerator == null) {
-    idGenerator = defaultIdGenerator;
-  }
-
-  const messages = packets.map(packet => prepareMessage(packet, idGenerator));
+function networkMessageUpdates(packets) {
+  const messages = packets.map(packet =>
+    prepareMessage(packet, defaultIdGenerator)
+  );
 
   return {
     type: NETWORK_MESSAGES_UPDATE,
diff --git a/devtools/client/webconsole/test/node/store/messages.test.js b/devtools/client/webconsole/test/node/store/messages.test.js
@@ -1046,7 +1046,7 @@ describe("Message reducer:", () => {
       packet.actor = "message1";
       updatePacket.actor = "message1";
       dispatch(actions.messagesAdd([packet]));
-      dispatch(actions.networkMessageUpdates([updatePacket], null));
+      dispatch(actions.networkMessageUpdates([updatePacket]));
 
       let networkUpdates = getAllNetworkMessagesUpdateById(getState());
       expect(Object.keys(networkUpdates)).toEqual(["message1"]);
@@ -1056,7 +1056,7 @@ describe("Message reducer:", () => {
       packet.actor = "message2";
       updatePacket.actor = "message2";
       dispatch(actions.messagesAdd([packet]));
-      dispatch(actions.networkMessageUpdates([updatePacket], null));
+      dispatch(actions.networkMessageUpdates([updatePacket]));
 
       networkUpdates = getAllNetworkMessagesUpdateById(getState());
       expect(Object.keys(networkUpdates)).toEqual(["message1", "message2"]);
@@ -1066,7 +1066,7 @@ describe("Message reducer:", () => {
       const { dispatch, getState } = setupStore(["XHR GET request"]);
 
       const updatePacket = stubPackets.get("XHR GET request update");
-      dispatch(actions.networkMessageUpdates([updatePacket], null));
+      dispatch(actions.networkMessageUpdates([updatePacket]));
 
       let networkUpdates = getAllNetworkMessagesUpdateById(getState());
       expect(!!Object.keys(networkUpdates).length).toBe(true);
@@ -1092,17 +1092,17 @@ describe("Message reducer:", () => {
       packet.actor = "message1";
       updatePacket.actor = "message1";
       dispatch(actions.messagesAdd([packet]));
-      dispatch(actions.networkMessageUpdates([updatePacket], null));
+      dispatch(actions.networkMessageUpdates([updatePacket]));
 
       packet.actor = "message2";
       updatePacket.actor = "message2";
       dispatch(actions.messagesAdd([packet]));
-      dispatch(actions.networkMessageUpdates([updatePacket], null));
+      dispatch(actions.networkMessageUpdates([updatePacket]));
 
       packet.actor = "message3";
       updatePacket.actor = "message3";
       dispatch(actions.messagesAdd([packet]));
-      dispatch(actions.networkMessageUpdates([updatePacket], null));
+      dispatch(actions.networkMessageUpdates([updatePacket]));
 
       // Check that we have the expected data.
       const messages = getMutableMessagesById(getState());
diff --git a/devtools/client/webconsole/test/node/store/network-messages.test.js b/devtools/client/webconsole/test/node/store/network-messages.test.js
@@ -37,7 +37,7 @@ describe("Network message reducer:", () => {
     packet.actor = "message1";
     updatePacket.actor = "message1";
     dispatch(actions.messagesAdd([packet]));
-    dispatch(actions.networkMessageUpdates([updatePacket], null));
+    dispatch(actions.networkMessageUpdates([updatePacket]));
   });
 
   describe("networkMessagesUpdateById", () => {
diff --git a/devtools/client/webconsole/webconsole-wrapper.js b/devtools/client/webconsole/webconsole-wrapper.js
@@ -436,7 +436,7 @@ class WebConsoleWrapper {
 
         if (this.queuedMessageUpdates.length) {
           await store.dispatch(
-            actions.networkMessageUpdates(this.queuedMessageUpdates, null)
+            actions.networkMessageUpdates(this.queuedMessageUpdates)
           );
           this.webConsoleUI.emitForTests("network-messages-updated");
           this.queuedMessageUpdates = [];