tor-browser

commit c079c42b0f069778d7b6c4e2c2f2974c6456c372
parent 9beac8b6754bd0211a614dc70095426eede73e27
Author: Paul Bone <paul@bone.id.au>
Date:   Wed, 29 Oct 2025 06:32:45 +0000

Bug 1976162 - pt 2. BaseAlloc::pages_alloc now returns false when it fails r=glandium

Differential Revision: https://phabricator.services.mozilla.com/D256413

Diffstat:
M
memory/build/BaseAlloc.cpp
 | 
6
+++---

1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/memory/build/BaseAlloc.cpp b/memory/build/BaseAlloc.cpp
@@ -23,7 +23,7 @@ bool BaseAlloc::pages_alloc(size_t minsize) MOZ_REQUIRES(base_mtx) {
   csize = CHUNK_CEILING(minsize);
   base_pages = chunk_alloc(csize, kChunkSize, true);
   if (!base_pages) {
-    return true;
+    return false;
   }
   base_next_addr = base_pages;
   base_past_addr = (void*)((uintptr_t)base_pages + csize);
@@ -37,7 +37,7 @@ bool BaseAlloc::pages_alloc(size_t minsize) MOZ_REQUIRES(base_mtx) {
   mStats.mapped += csize;
   mStats.committed += pminsize;
 
-  return false;
+  return true;
 }
 
 void* BaseAlloc::alloc(size_t aSize) {
@@ -50,7 +50,7 @@ void* BaseAlloc::alloc(size_t aSize) {
   MutexAutoLock lock(base_mtx);
   // Make sure there's enough space for the allocation.
   if ((uintptr_t)base_next_addr + csize > (uintptr_t)base_past_addr) {
-    if (pages_alloc(csize)) {
+    if (!pages_alloc(csize)) {
       return nullptr;
     }
   }