commit be94162fc615a1f846f959ce84bd3bb68895b0d2
parent cab312d5bba68ba819d2634097b7218363c80146
Author: Thomas Wisniewski <twisniewski@mozilla.com>
Date: Fri, 31 Oct 2025 15:54:28 +0000
Bug 1959132 - remove our Android webcompat intervention for samsung.com to fix their 2-column layout; r=webcompat-reviewers,ksenia
Differential Revision: https://phabricator.services.mozilla.com/D270748
Diffstat:
3 files changed, 0 insertions(+), 68 deletions(-)
diff --git a/browser/extensions/webcompat/data/interventions.json b/browser/extensions/webcompat/data/interventions.json
@@ -4841,23 +4841,6 @@
}
]
},
- "1959132": {
- "label": "www.samsung.com (columns fix)",
- "bugs": {
- "1959132": {
- "issue": "broken-layout",
- "matches": ["*://www.samsung.com/*"]
- }
- },
- "interventions": [
- {
- "platforms": ["android"],
- "content_scripts": {
- "css": ["bug1959132-www.samsung.com-column-size-fix.css"]
- }
- }
- ]
- },
"1959444": {
"label": "m.modanisa.com",
"bugs": {
diff --git a/browser/extensions/webcompat/injections/css/bug1959132-www.samsung.com-column-size-fix.css b/browser/extensions/webcompat/injections/css/bug1959132-www.samsung.com-column-size-fix.css
@@ -1,18 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/**
- * www.samsung.com - Layout shows one column instead of two on Android
- * Bug #1959132 - https://bugzilla.mozilla.org/show_bug.cgi?id=1959132
- * WebCompat issue #152559 - https://webcompat.com/issues/152559
- *
- * The site is using a grid gap which is a bit too large, and Firefox
- * dutifully mis-arranges the columns as instructed. Making the gap a
- * bit smaller seems to work better across browsers.
- */
-@media screen and (max-width: 800px) {
- .mo_ver2.pf-container .pf-prd-cardlist.col-2 .list-product .list {
- gap: 3.3vw;
- }
-}
diff --git a/testing/webcompat/interventions/tests/test_1959132_www_samsung_com.py b/testing/webcompat/interventions/tests/test_1959132_www_samsung_com.py
@@ -1,33 +0,0 @@
-import pytest
-
-URL = "https://www.samsung.com/sec/memory-storage/all-memory-storage/?ssd"
-COLUMN1_CSS = ".list-product > .list > :nth-child(1)"
-COLUMN2_CSS = ".list-product > .list > :nth-child(2)"
-
-
-async def shows_two_columns(client):
- await client.navigate(URL, wait="none")
- col1 = client.await_css(COLUMN1_CSS, is_displayed=True)
- col2 = client.await_css(COLUMN2_CSS, is_displayed=True)
- return client.execute_script(
- """
- const [col1, col2] = arguments;
- return col1.getBoundingClientRect().top === col2.getBoundingClientRect().top;
- """,
- col1,
- col2,
- )
-
-
-@pytest.mark.only_platforms("android")
-@pytest.mark.asyncio
-@pytest.mark.with_interventions
-async def test_enabled(client):
- assert await shows_two_columns(client)
-
-
-@pytest.mark.only_platforms("android")
-@pytest.mark.asyncio
-@pytest.mark.without_interventions
-async def test_disabled(client):
- assert not await shows_two_columns(client)
