tor-browser

commit bdb5a318f0845be9dd285b47e06781947cd034a1
parent 83ba6a04f970eaa380e76291e92ccf7384fd1c6d
Author: Thomas Wisniewski <twisniewski@mozilla.com>
Date:   Wed, 26 Nov 2025 23:06:56 +0000

Bug 1886566 - disable our webcompat intervention for qceservices.quezoncity.gov.ph where it is no longer needed; r=ksenia,webcompat-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D274084

Diffstat:
M
browser/extensions/webcompat/data/interventions.json
 | 
9
+++++++++
M
testing/webcompat/interventions/tests/test_1886566_qceservices_quezoncity_gov_ph.py
 | 
32
++++++++++++++++++++++++++++++--

2 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/browser/extensions/webcompat/data/interventions.json b/browser/extensions/webcompat/data/interventions.json
@@ -1759,6 +1759,15 @@
     "interventions": [
       {
         "platforms": ["all"],
+        "max_version": 145,
+        "content_scripts": {
+          "css": ["bug1886566-quezoncity.gov.ph-iframe-height.css"]
+        }
+      },
+      {
+        "platforms": ["all"],
+        "min_version": 146,
+        "pref_check": { "layout.css.webkit-fill-available.enabled": false },
         "content_scripts": {
           "css": ["bug1886566-quezoncity.gov.ph-iframe-height.css"]
         }
diff --git a/testing/webcompat/interventions/tests/test_1886566_qceservices_quezoncity_gov_ph.py b/testing/webcompat/interventions/tests/test_1886566_qceservices_quezoncity_gov_ph.py
@@ -36,13 +36,41 @@ async def is_iframe_visible(client, in_headless_mode):
     )
 
 
+@pytest.mark.only_firefox_versions(min=146)
+@pytest.mark.enable_webkit_fill_available
+@pytest.mark.asyncio
+@pytest.mark.without_interventions
+async def test_now_works_with_just_pref(client, in_headless_mode):
+    assert await is_iframe_visible(client, in_headless_mode)
+
+
+@pytest.mark.only_firefox_versions(min=146)
+@pytest.mark.disable_webkit_fill_available
 @pytest.mark.asyncio
 @pytest.mark.with_interventions
-async def test_enabled(client, in_headless_mode):
+async def test_still_works_without_pref(client, in_headless_mode):
+    assert await is_iframe_visible(client, in_headless_mode)
+
+
+@pytest.mark.only_firefox_versions(min=146)
+@pytest.mark.disable_webkit_fill_available
+@pytest.mark.asyncio
+@pytest.mark.without_interventions
+async def test_still_does_not_work_without_pref_or_intervention(
+    client, in_headless_mode
+):
+    assert not await is_iframe_visible(client, in_headless_mode)
+
+
+@pytest.mark.only_firefox_versions(max=145)
+@pytest.mark.asyncio
+@pytest.mark.without_interventions
+async def test_did_work_with_intervention(client, in_headless_mode):
     assert await is_iframe_visible(client, in_headless_mode)
 
 
+@pytest.mark.only_firefox_versions(max=145)
 @pytest.mark.asyncio
 @pytest.mark.without_interventions
-async def test_disabled(client, in_headless_mode):
+async def test_did_not_work_without_intervention(client, in_headless_mode):
     assert not await is_iframe_visible(client, in_headless_mode)