tor-browser

commit baecbcec1afd9a692858ec84e3991b4e97655a51
parent 3de5137e2e0adea3c9a7dbed9230fc781ae794d3
Author: Randell Jesup <rjesup@mozilla.com>
Date:   Wed, 26 Nov 2025 05:20:08 +0000

Bug 2002034: When matching for CompressionDictionaries pass the cache entry URI to URLPattern r=necko-reviewers,valentin

In the spec, section 2.2.2 step 2

Differential Revision: https://phabricator.services.mozilla.com/D273938

Diffstat:
M
netwerk/cache2/Dictionary.cpp
 | 
2
+-
M
netwerk/test/unit/test_dictionary_compression_dcb.js
 | 
2
+-
M
netwerk/test/unit/xpcshell.toml
 | 
4
++++

3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/netwerk/cache2/Dictionary.cpp b/netwerk/cache2/Dictionary.cpp
@@ -169,7 +169,7 @@ bool DictionaryCacheEntry::Match(const nsACString& aFilePath,
                 aType)) != mMatchDest.NoIndex) {
       UrlpPattern pattern;
       UrlpOptions options;
-      const nsCString base("https://foo.com/"_ns);
+      const nsCString base(mURI);
       if (!urlp_parse_pattern_from_string(&mPattern, &base, options,
                                           &pattern)) {
         DICTIONARY_LOG(
diff --git a/netwerk/test/unit/test_dictionary_compression_dcb.js b/netwerk/test/unit/test_dictionary_compression_dcb.js
@@ -444,7 +444,7 @@ async function setupDicts() {
     let dictKey = dictKeys[i];
     let url = `${server.origin()}${path}`;
     dump(
-      `registering dictionary ${path} for match patter ${DCB_TEST_DICTIONARIES[dictKey].patterh}\n`
+      `registering dictionary ${path} for match pattern ${DCB_TEST_DICTIONARIES[dictKey].pattern}\n`
     );
 
     let chan = makeChan(url);
diff --git a/netwerk/test/unit/xpcshell.toml b/netwerk/test/unit/xpcshell.toml
@@ -487,6 +487,7 @@ run-sequentially = ["true"] # httpd server
 run-sequentially = ["true"] # httpd server
 
 ["test_cache2_compression_dictionary.js"]
+run-sequentially = ["true"]
 
 ["test_cache2_nostore.js"]
 
@@ -595,10 +596,13 @@ prefs = ["content.cors.use_triggering_principal=true"] # See bug 1982916.
 ["test_defaultURI.js"]
 
 ["test_dictionary_compression_dcb.js"]
+run-sequentially = ["true"]
 
 ["test_dictionary_retrieval.js"]
+run-sequentially = ["true"]
 
 ["test_dictionary_storage.js"]
+run-sequentially = ["true"]
 
 ["test_dns_by_type_resolve.js"]