commit b7b17bf8b6feef771dc0ebb41fdbb209243bc949 parent 65b035355ead905b7a6651d693d267a9d46f3631 Author: Sarah Chung <sachung@mozilla.com> Date: Wed, 5 Nov 2025 18:57:09 +0000 Bug 1995784 - Fix password tooltip transition and unecessary scrollbars on backup optin spotlight r=omc-reviewers,emcminn This patch fixes [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1995784 | Bug 1995784 ]] and [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1996553 | Bug 1996553 ]]: - It updates the password rules tooltip to be hidden when the password input is not focused to fix the odd transition when the "Back" button is pressed - The scrollbars are no longer showing in the passwords screen in `BROWSER_BACKUP_OPTIN_SPOTLIGHT` - Fixes the fill colour for the check icon in the tooltip Differential Revision: https://phabricator.services.mozilla.com/D271418 Diffstat:
5 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/browser/components/asrouter/modules/OnboardingMessageProvider.sys.mjs b/browser/components/asrouter/modules/OnboardingMessageProvider.sys.mjs @@ -634,7 +634,7 @@ const BASE_MESSAGES = () => [ fontSize: "13px", }, screen_style: { - width: "764px", + width: "700px", height: "650px", }, logo: { diff --git a/browser/components/backup/content/password-rules-tooltip.css b/browser/components/backup/content/password-rules-tooltip.css @@ -22,6 +22,8 @@ padding-left: 20px; list-style: none; background-image: url(chrome://global/skin/icons/check.svg); + -moz-context-properties: fill; + fill: currentColor; background-repeat: no-repeat; background-position: left center; background-size: 14px; @@ -95,6 +97,6 @@ :host([embedded-fx-backup-opt-in]) { #password-rules-wrapper { - margin: 0 -140px; + margin: 0 -100px; } } diff --git a/browser/components/backup/content/password-validation-inputs.css b/browser/components/backup/content/password-validation-inputs.css @@ -65,4 +65,9 @@ font-weight: var(--heading-font-weight); font-size: var(--font-size-sub-heading); } + + .hidden { + visibility: hidden; + transition: visibility 0s; + } } diff --git a/browser/components/backup/content/password-validation-inputs.mjs b/browser/components/backup/content/password-validation-inputs.mjs @@ -70,8 +70,8 @@ export default class PasswordValidationInputs extends MozLitElement { this._showRules = true; } - handleBlurNewPassword(event) { - this._showRules = !event.target.checkValidity(); + handleBlurNewPassword() { + this._showRules = false; } handleChangeNewPassword() { diff --git a/browser/components/backup/content/turn-on-scheduled-backups.css b/browser/components/backup/content/turn-on-scheduled-backups.css @@ -130,6 +130,7 @@ width: 500px; margin-inline: auto; padding-block: var(--padding-block-wrapper); + overflow: hidden; #backup-location-controls #backup-location-filepicker { margin-block-start: var(--margin-block-start-file-picker);