tor-browser

commit b7a2e2d65ec006ed7bdb4a1bfd393acc7fe6d2a6
parent 78c28fa0ca195f6223f4f65b9b57bb832f7ca0c1
Author: Thomas Wisniewski <twisniewski@mozilla.com>
Date:   Thu, 16 Oct 2025 16:12:12 +0000

Bug 1898959 - remove our UA override for indices.circana.com; r=webcompat-reviewers,ksenia

Differential Revision: https://phabricator.services.mozilla.com/D268779

Diffstat:
M
browser/extensions/webcompat/data/interventions.json
 | 
15
---------------
M
browser/extensions/webcompat/manifest.json
 | 
2
+-
M
testing/webcompat/interventions/tests/test_1933811_indices_circana_com.py
 | 
38
+++++++++++++-------------------------

3 files changed, 14 insertions(+), 41 deletions(-)
diff --git a/browser/extensions/webcompat/data/interventions.json b/browser/extensions/webcompat/data/interventions.json
@@ -3970,21 +3970,6 @@
       }
     ]
   },
-  "1933811": {
-    "label": "indices.circana.com",
-    "bugs": {
-      "1898959": {
-        "issue": "firefox-blocked-completely",
-        "matches": ["*://indices.circana.com/*"]
-      }
-    },
-    "interventions": [
-      {
-        "platforms": ["all"],
-        "ua_string": ["add_Chrome"]
-      }
-    ]
-  },
   "1933910": {
     "label": "www.tiktok.com/tiktokstudio",
     "bugs": {
diff --git a/browser/extensions/webcompat/manifest.json b/browser/extensions/webcompat/manifest.json
@@ -2,7 +2,7 @@
   "manifest_version": 2,
   "name": "Web Compatibility Interventions",
   "description": "Urgent post-release fixes for web compatibility.",
-  "version": "146.0.0",
+  "version": "146.1.0",
   "browser_specific_settings": {
     "gecko": {
       "id": "webcompat@mozilla.org",
diff --git a/testing/webcompat/interventions/tests/test_1933811_indices_circana_com.py b/testing/webcompat/interventions/tests/test_1933811_indices_circana_com.py
@@ -1,37 +1,25 @@
-import asyncio
-
 import pytest
+from webdriver.bidi.error import UnknownErrorException
 
 URL = "https://indices.circana.com"
 OLD_URL = "https://indices.iriworldwide.com"
-BAD_CSS = ".hiddPage"
-
-
-async def does_unsupported_banner_appear(client, url):
-    await client.navigate(url, wait="complete")
-    await asyncio.sleep(2)
-    return client.find_css(BAD_CSS)
 
 
 @pytest.mark.asyncio
 @pytest.mark.with_interventions
-async def test_enabled(client):
-    assert not await does_unsupported_banner_appear(client, URL)
+async def test_regression_site_is_dead(client):
+    try:
+        await client.navigate(URL)
+        assert False
+    except UnknownErrorException:
+        assert True
 
 
 @pytest.mark.asyncio
 @pytest.mark.with_interventions
-async def test_enabled_old_url(client):
-    assert not await does_unsupported_banner_appear(client, OLD_URL)
-
-
-@pytest.mark.asyncio
-@pytest.mark.without_interventions
-async def test_disabled(client):
-    assert await does_unsupported_banner_appear(client, URL)
-
-
-@pytest.mark.asyncio
-@pytest.mark.without_interventions
-async def test_disabled_old_url(client):
-    assert await does_unsupported_banner_appear(client, OLD_URL)
+async def test_regression_old_site_is_dead(client):
+    try:
+        await client.navigate(OLD_URL)
+        assert False
+    except UnknownErrorException:
+        assert True