commit b5d8f1acd21dfd42cb88c0c54116ddbf70570773 parent b6c6cb8fb0e1ec5cf463aaa15d1f17ffd51cb606 Author: Simon Farre <simon.farre.cx@gmail.com> Date: Wed, 7 Jan 2026 15:57:16 +0000 Bug 2008951 - Fix getting a null global for Navigation.reload r=farre Addresses the following failing tests - navigation-api/navigation-methods/return-value/navigate-detach-in-serialization.html - navigation-api/navigation-methods/return-value/reload-detach-in-serialization.html Differential Revision: https://phabricator.services.mozilla.com/D278126 Diffstat:
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/dom/navigation/Navigation.cpp b/dom/navigation/Navigation.cpp @@ -442,7 +442,9 @@ void Navigation::SetEarlyErrorResult(JSContext* aCx, NavigationResult& aResult, // «[ "committed" → a promise rejected with e, // "finished" → a promise rejected with e ]». - RefPtr global = GetOwnerGlobal(); + // Get the global of the current realm to create the DOMException. + // See https://webidl.spec.whatwg.org/#js-creating-throwing-exceptions + nsIGlobalObject* global = GetCurrentGlobal(); if (!global) { // Creating a promise should only fail if there is no global. // In this case, the only solution is to ignore the error. diff --git a/testing/web-platform/meta/navigation-api/navigation-methods/return-value/navigate-detach-in-serialization.html.ini b/testing/web-platform/meta/navigation-api/navigation-methods/return-value/navigate-detach-in-serialization.html.ini @@ -1,3 +0,0 @@ -[navigate-detach-in-serialization.html] - [navigate() promise rejections when detaching an iframe inside state serialization] - expected: FAIL diff --git a/testing/web-platform/meta/navigation-api/navigation-methods/return-value/reload-detach-in-serialization.html.ini b/testing/web-platform/meta/navigation-api/navigation-methods/return-value/reload-detach-in-serialization.html.ini @@ -1,3 +0,0 @@ -[reload-detach-in-serialization.html] - [reload() promise rejections when detaching an iframe inside state serialization] - expected: FAIL