tor-browser

commit b312b2abae101bb0575dda084aec2fc2119b1dc2
parent b77e723fc778eb0b394164a076c5b59befbc04cf
Author: Emilio Cobos Álvarez <emilio@crisal.io>
Date:   Fri,  3 Oct 2025 14:54:56 +0000

Bug 1992425 - Remove unused argument to UpdateValueDisplay. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D267424

Diffstat:
M
dom/html/TextControlState.cpp
 | 
5
++---
M
layout/forms/nsTextControlFrame.cpp
 | 
1
-
M
layout/forms/nsTextControlFrame.h
 | 
3
+--

3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/dom/html/TextControlState.cpp b/dom/html/TextControlState.cpp
@@ -1751,7 +1751,7 @@ nsresult TextControlState::PrepareEditor(const nsAString* aValue) {
 
     // Make sure we clear out the non-breaking space before we initialize the
     // editor
-    nsresult rv = mBoundFrame->UpdateValueDisplay(true, true);
+    nsresult rv = mBoundFrame->UpdateValueDisplay(true);
     if (NS_FAILED(rv)) {
       NS_WARNING("nsTextControlFrame::UpdateValueDisplay() failed");
       return rv;
@@ -1759,8 +1759,7 @@ nsresult TextControlState::PrepareEditor(const nsAString* aValue) {
   } else {
     if (aValue || !mEditorInitialized) {
       // Set the correct value in the root node
-      nsresult rv =
-          mBoundFrame->UpdateValueDisplay(true, !mEditorInitialized, aValue);
+      nsresult rv = mBoundFrame->UpdateValueDisplay(true, aValue);
       if (NS_FAILED(rv)) {
         NS_WARNING("nsTextControlFrame::UpdateValueDisplay() failed");
         return rv;
diff --git a/layout/forms/nsTextControlFrame.cpp b/layout/forms/nsTextControlFrame.cpp
@@ -1035,7 +1035,6 @@ void nsTextControlFrame::SetInitialChildList(ChildListID aListID,
 }
 
 nsresult nsTextControlFrame::UpdateValueDisplay(bool aNotify,
-                                                bool aBeforeEditorInit,
                                                 const nsAString* aValue) {
   MOZ_ASSERT(mRootNode, "Must have a div content\n");
   MOZ_ASSERT(!mEditorHasBeenInitialized,
diff --git a/layout/forms/nsTextControlFrame.h b/layout/forms/nsTextControlFrame.h
@@ -248,8 +248,7 @@ class nsTextControlFrame : public nsContainerFrame,
    * value. This should only be called when we have no editor yet.
    * @throws NS_ERROR_UNEXPECTED if the div has no text content
    */
-  nsresult UpdateValueDisplay(bool aNotify, bool aBeforeEditorInit = false,
-                              const nsAString* aValue = nullptr);
+  nsresult UpdateValueDisplay(bool aNotify, const nsAString* aValue = nullptr);
 
   /**
    * Find out whether an attribute exists on the content or not.