tor-browser

commit af6096821afbed251a496da2d2bf1b79fdbc7a08
parent 2faa0e3a61af946466f111cebb4b62dd808bea89
Author: Michael Froman <mfroman@mozilla.com>
Date:   Wed,  5 Nov 2025 21:23:51 +0000

Bug 1997266 - don't exit when getting MsgDropped in GMPChild::ProcessingError. r=aosmond,media-playback-reviewers

This was causing tsan crashes in dom/media/webrtc/tests/mochitests/test_peerConnection_basicScreenshare.html
where the only real symptom was the message "The fakeopenh264 plugin has crashed"
in the screen shot recorded at failure.  In the logs, all we see is the more generic
"PluginCrash: Our plugin {n} crashed".

Differential Revision: https://phabricator.services.mozilla.com/D271498

Diffstat:
M
dom/media/gmp/GMPChild.cpp
 | 
3
++-

1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dom/media/gmp/GMPChild.cpp b/dom/media/gmp/GMPChild.cpp
@@ -617,7 +617,8 @@ void GMPChild::ActorDestroy(ActorDestroyReason aWhy) {
 void GMPChild::ProcessingError(Result aCode, const char* aReason) {
   switch (aCode) {
     case MsgDropped:
-      _exit(0);  // Don't trigger a crash report.
+      NS_WARNING("MsgDropped in GMPChild");
+      return;
     case MsgNotKnown:
       MOZ_CRASH("aborting because of MsgNotKnown");
     case MsgNotAllowed: