tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit af579dacfdcb1ddca10d8d7fb212de806a379af3
parent c47d934ec01c0cd3e6468651e40442a4f5238cad
Author: Nina Pypchenko <npypchenko@mozilla.com>
Date:   Wed,  1 Oct 2025 21:12:17 +0000

Bug 1968152 - Remove Pocket prefs r=home-newtab-reviewers,urlbar-reviewers,nbarrett,jteow

- Removed Pocket extension prefs.
- Removed temporary updates to test files while the pref was off by default but not yet removed.
- Removed Pocket extension prefs from Nimbus Feature Manifest.

Differential Revision: https://phabricator.services.mozilla.com/D266942

Diffstat:
Mbrowser/app/profile/firefox.js | 18------------------
Mbrowser/base/content/test/keyboard/browser_toolbarKeyNav.js | 2--
Mbrowser/base/content/test/sync/browser_contextmenu_sendpage.js | 4----
Mbrowser/components/customizableui/test/browser_remote_attribute.js | 7-------
Mbrowser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_revert_keyboard.js | 2--
Mtoolkit/components/nimbus/FeatureManifest.yaml | 36------------------------------------
6 files changed, 0 insertions(+), 69 deletions(-)

diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js @@ -2717,24 +2717,6 @@ pref("browser.migrate.interactions.passwords", false); pref("browser.migrate.preferences-entrypoint.enabled", true); -pref("extensions.pocket.api", "api.getpocket.com"); -pref("extensions.pocket.bffApi", "firefox-api-proxy.cdn.mozilla.net"); -pref("extensions.pocket.bffRecentSaves", true); -pref("extensions.pocket.enabled", false); -pref("extensions.pocket.oAuthConsumerKey", "40249-e88c401e1b1f2242d9e441c4"); -pref("extensions.pocket.oAuthConsumerKeyBff", "94110-6d5ff7a89d72c869766af0e0"); -pref("extensions.pocket.site", "getpocket.com"); - -// Enable Pocket button home panel for non link pages. -pref("extensions.pocket.showHome", true); - -// Control what version of the logged out doorhanger is displayed -// Possibilities are: `control`, `control-one-button`, `variant_a`, `variant_b`, `variant_c` -pref("extensions.pocket.loggedOutVariant", "control"); - -// Just for the new Pocket panels, enables the email signup button. -pref("extensions.pocket.refresh.emailButton.enabled", false); - // "available" - user can see feature offer. // "offered" - we have offered feature to user and they have not yet made a decision. // "enabled" - user opted in to the feature. diff --git a/browser/base/content/test/keyboard/browser_toolbarKeyNav.js b/browser/base/content/test/keyboard/browser_toolbarKeyNav.js @@ -125,8 +125,6 @@ add_setup(async function () { ["browser.urlbar.scotchBonnet.enableOverride", false], ["browser.toolbars.keyboard_navigation", true], ["accessibility.tabfocus", 7], - // Bug 1968055 - Temporarily enabled pocket pref while we remove the pref entirely - ["extensions.pocket.enabled", true], // Taskbar Tabs' page action is controlled by a pref that differs across // platforms and by runtime checks. Patching around it is currently // onorous and creates issues with existing tests without improving test diff --git a/browser/base/content/test/sync/browser_contextmenu_sendpage.js b/browser/base/content/test/sync/browser_contextmenu_sendpage.js @@ -41,10 +41,6 @@ add_setup(async function () { }); sinon.stub(Weave.Service.clientsEngine, "getClientType").returns("desktop"); await BrowserTestUtils.openNewForegroundTab(gBrowser, "about:mozilla"); - // Bug 1968055 - Temporarily enabled pocket pref while we remove the pref entirely - await SpecialPowers.pushPrefEnv({ - set: [["extensions.pocket.enabled", true]], - }); }); add_task(async function test_page_contextmenu() { diff --git a/browser/components/customizableui/test/browser_remote_attribute.js b/browser/components/customizableui/test/browser_remote_attribute.js @@ -4,13 +4,6 @@ "use strict"; -add_setup(async () => { - // Bug 1968055 - Temporarily enabled pocket pref while we remove the pref entirely - await SpecialPowers.pushPrefEnv({ - set: [["extensions.pocket.enabled", true]], - }); -}); - /** * These tests check that the remote attribute is true for remote panels. * This attribute is needed for Mac to properly render the panel. diff --git a/browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_revert_keyboard.js b/browser/components/urlbar/tests/browser/browser_UrlbarInput_searchTerms_revert_keyboard.js @@ -18,8 +18,6 @@ add_setup(async function () { set: [ ["browser.urlbar.showSearchTerms.featureGate", true], ["browser.urlbar.scotchBonnet.enableOverride", true], - // Bug 1968055 - Temporarily enabled pocket pref while we remove the pref entirely - ["extensions.pocket.enabled", true], ], }); let cleanup = await installPersistTestEngines(); diff --git a/toolkit/components/nimbus/FeatureManifest.yaml b/toolkit/components/nimbus/FeatureManifest.yaml @@ -2049,42 +2049,6 @@ pocketNewtab: description: >- Change the layout of the sections to be more compact to account for the added card height with the thumbs up/down enabled. -saveToPocket: - description: The save to Pocket feature - owner: sdowne@mozilla.com - hasExposure: false - variables: - enabled: - type: boolean - setPref: - branch: user - pref: extensions.pocket.enabled - description: Enabled save to Pocket feature. - emailButton: - type: boolean - setPref: - branch: user - pref: extensions.pocket.refresh.emailButton.enabled - description: Just for the new Pocket panels, enables the email signup button. - bffRecentSaves: - type: boolean - setPref: - branch: user - pref: extensions.pocket.bffRecentSaves - description: Use the new BFF Proxy Service instead of the legacy Pocket Service for Recent Saves - bffApi: - type: string - setPref: - branch: user - pref: extensions.pocket.bffApi - description: BFF Proxy Service domain - oAuthConsumerKeyBff: - type: string - setPref: - branch: user - pref: extensions.pocket.oAuthConsumerKeyBff - description: BFF Proxy Service OAuth Consumer Key - sessionRestore: description: Session restore feature owner: sfoster@mozilla.com