commit adfadc8ce1e13fbdea0615d3e42069697937fe6e
parent d3efec3d533b86e78ea1728e5e53661e21498d97
Author: Chris Fredrickson <cfredric@chromium.org>
Date: Fri, 19 Dec 2025 09:16:40 +0000
Bug 2006538 [wpt PR 56800] - [SAH] Rename WPT helper function, a=testonly
Automatic update from web-platform-tests
[SAH] Rename WPT helper function
The current name is a bit of a misnomer, since the "active" suffix is
used whenever the request had the `Sec-Fetch-Storage-Access: active`
header; it is not necessary that the request was retried. (See
https://crsrc.org/c/third_party/blink/web_tests/external/wpt/storage-access-api/resources/handle-headers-retry.py;drc=5bb5f07e46bc5359319ba8e444e99d00cc9cc135;l=32-33.)
Change-Id: I227344465ace3568b4ca76c136db2edd1250c08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7265210
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1559726}
--
wpt-commits: c601ead2b899b369758cdfafd2a088b716bf6895
wpt-pr: 56800
Diffstat:
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/testing/web-platform/tests/storage-access-api/storage-access-headers.tentative.https.sub.window.js b/testing/web-platform/tests/storage-access-api/storage-access-headers.tentative.https.sub.window.js
@@ -74,7 +74,7 @@ function addCommonCleanupCallback(test) {
});
}
-function retriedKey(key) {
+function activeKey(key) {
return key + 'active';
}
@@ -135,7 +135,7 @@ promise_test(async (t) => {
assertHeaderValuesMatch(headers, {'sec-fetch-storage-access': ['inactive'],
'origin': [https_origin], 'cookie': undefined});
// Retrieve the headers for the retried request.
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
// The unpartitioned cookie should have been included in the retry.
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
@@ -161,7 +161,7 @@ promise_test(async (t) => {
'cookie': undefined
});
// Retrieve the headers for the retried request.
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [https_origin],
@@ -184,7 +184,7 @@ promise_test(async (t) => {
// sent but was previously retrieved. To ensure the request to retrieve the
// post-retry header occurs only because they were never sent, always
// test its retrieval first.
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assert_equals(retried_headers, undefined);
// Retrieve the pre-retry headers.
const headers = await sendRetrieveRequest(key);
@@ -201,7 +201,7 @@ promise_test(async (t) => {
[['retry-allowed-origin',
same_site]]));
// Should not be able to retrieve any headers at the post-retry key.
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assert_equals(retried_headers, undefined);
// Retrieve the pre-retry headers.
const headers = await sendRetrieveRequest(key);
@@ -217,7 +217,7 @@ promise_test(async (t) => {
[['retry-allowed-origin',
https_origin]]));
// Should not be able to retrieve any headers at the post-retry key.
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assert_equals(retried_headers, undefined);
// Retrieve the pre-retry headers.
const headers = await sendRetrieveRequest(key);
@@ -326,7 +326,7 @@ promise_test(async t => {
// Storage access should have been activated, without the need for a grant,
// on the ABA case.
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [cross_site],
@@ -359,14 +359,14 @@ promise_test(async (t) => {
const headers = await sendRetrieveRequest(key);
assertHeaderValuesMatch(headers, {'sec-fetch-storage-access': ['inactive'],
'origin': [https_origin], 'cookie': undefined});
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [https_origin],
'cookie': ['cookie=unpartitioned']
});
// Retrieve the headers for the post-retry redirect request.
- const redirected_headers = await sendRetrieveRequest(redirectedKey(retriedKey(key)));
+ const redirected_headers = await sendRetrieveRequest(redirectedKey(activeKey(key)));
assertHeaderValuesMatch(redirected_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [https_origin],
@@ -398,7 +398,7 @@ promise_test(async (t) => {
'origin': [https_origin],
'cookie': undefined
});
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [https_origin],
@@ -436,7 +436,7 @@ promise_test(async (t) => {
'origin': [https_origin],
'cookie': undefined
});
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [https_origin],
@@ -479,7 +479,7 @@ promise_test(async (t) => {
assertHeaderValuesMatch(headers, {'sec-fetch-storage-access': ['inactive'],
'origin': [https_origin],
'cookie': undefined});
- const retried_headers = await sendRetrieveRequest(retriedKey(key));
+ const retried_headers = await sendRetrieveRequest(activeKey(key));
assertHeaderValuesMatch(retried_headers, {
'sec-fetch-storage-access': ['active'],
'origin': [https_origin],