tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit ade2b4d57bc4748d9854614c6cd7f8af5e061fa2
parent e28a015a06f79b6be3c1677cb05df89e48539245
Author: Jens Stutte <jstutte@mozilla.com>
Date:   Wed, 12 Nov 2025 06:59:05 +0000

Bug 1996196 - Do not use TimeDuration::Resolution in HTMLMediaElement. r=alwu,karlt

Just use a fix offset of 1ms instead to adjust the progress calculations.
Given the general switch to QPC on Windows in bug 1995254, we can also just switch to using Now() instead of NowLoRes().

Differential Revision: https://phabricator.services.mozilla.com/D270040

Diffstat:
Mdom/media/mediaelement/HTMLMediaElement.cpp | 10+++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/dom/media/mediaelement/HTMLMediaElement.cpp b/dom/media/mediaelement/HTMLMediaElement.cpp @@ -6109,7 +6109,7 @@ void HTMLMediaElement::CheckProgress(bool aHaveNewProgress) { MOZ_ASSERT(NS_IsMainThread()); MOZ_ASSERT(mNetworkState == NETWORK_LOADING); - TimeStamp now = TimeStamp::NowLoRes(); + TimeStamp now = TimeStamp::Now(); if (aHaveNewProgress) { mDataTime = now; @@ -6127,11 +6127,11 @@ void HTMLMediaElement::CheckProgress(bool aHaveNewProgress) { TimeDuration::FromMilliseconds(PROGRESS_MS) && mDataTime > mProgressTime)) { QueueEvent(u"progress"_ns); - // Resolution() ensures that future data will have now > mProgressTime, + // Going back 1ms ensures that future data will have now > mProgressTime, // and so will trigger another event. mDataTime is not reset because it // is still required to detect stalled; it is similarly offset by - // resolution to indicate the new data has not yet arrived. - mProgressTime = now - TimeDuration::Resolution(); + // 1ms to indicate the new data has not yet arrived. + mProgressTime = now - TimeDuration::FromMilliseconds(1); if (mDataTime > mProgressTime) { mDataTime = mProgressTime; } @@ -6185,7 +6185,7 @@ void HTMLMediaElement::StartProgressTimer() { void HTMLMediaElement::StartProgress() { // Record the time now for detecting stalled. - mDataTime = TimeStamp::NowLoRes(); + mDataTime = TimeStamp::Now(); // Reset mProgressTime so that mDataTime is not indicating bytes received // after the last progress event. mProgressTime = TimeStamp();