commit abb0b791ea88df4c712ccff3b0e83dfc093f5a1b
parent 20e321d4d0ac7ea677abaf75948b474243a54b50
Author: Emily McDonough <emcdonough@mozilla.com>
Date: Wed, 19 Nov 2025 22:26:38 +0000
Bug 2000958 - Minor style fix for if (...) return in HTMLMediaElement.cpp r=media-playback-reviewers,alwu
Differential Revision: https://phabricator.services.mozilla.com/D273098
Diffstat:
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/dom/media/mediaelement/HTMLMediaElement.cpp b/dom/media/mediaelement/HTMLMediaElement.cpp
@@ -2646,7 +2646,9 @@ void HTMLMediaElement::QueueLoadFromSourceTask() {
void HTMLMediaElement::QueueSelectResourceTask() {
// Don't allow multiple async select resource calls to be queued.
- if (mHaveQueuedSelectResource) return;
+ if (mHaveQueuedSelectResource) {
+ return;
+ }
mHaveQueuedSelectResource = true;
ChangeNetworkState(NETWORK_NO_SOURCE);
RefPtr<Runnable> r = NewRunnableMethod<JSCallingLocation>(
@@ -3286,7 +3288,9 @@ MediaResult HTMLMediaElement::LoadResource(
// TODO: remove the cast by storing ChannelMediaDecoder in the URI table.
nsresult rv = InitializeDecoderAsClone(
static_cast<ChannelMediaDecoder*>(other->mDecoder.get()));
- if (NS_SUCCEEDED(rv)) return rv;
+ if (NS_SUCCEEDED(rv)) {
+ return rv;
+ }
}
LOG(LogLevel::Debug, ("%p LoadResource", this));
@@ -3336,7 +3340,9 @@ nsresult HTMLMediaElement::LoadWithChannel(nsIChannel* aChannel,
*aListener = nullptr;
// Make sure we don't reenter during synchronous abort events.
- if (mIsRunningLoadMethod) return NS_OK;
+ if (mIsRunningLoadMethod) {
+ return NS_OK;
+ }
mIsRunningLoadMethod = true;
AbortExistingLoads();
mIsRunningLoadMethod = false;
@@ -3649,7 +3655,9 @@ void HTMLMediaElement::SetVolume(double aVolume, ErrorResult& aRv) {
return;
}
- if (aVolume == mVolume) return;
+ if (aVolume == mVolume) {
+ return;
+ }
mVolume = aVolume;
@@ -4728,7 +4736,9 @@ HTMLMediaElement::~HTMLMediaElement() {
void HTMLMediaElement::StopSuspendingAfterFirstFrame() {
mAllowSuspendAfterFirstFrame = false;
- if (!mSuspendedAfterFirstFrame) return;
+ if (!mSuspendedAfterFirstFrame) {
+ return;
+ }
mSuspendedAfterFirstFrame = false;
if (mDecoder) {
mDecoder->Resume();
@@ -5418,7 +5428,9 @@ nsresult HTMLMediaElement::InitializeDecoderAsClone(
HasAttr(nsGkAtoms::loop), aOriginal->ContainerType());
RefPtr<ChannelMediaDecoder> decoder = aOriginal->Clone(decoderInit);
- if (!decoder) return NS_ERROR_FAILURE;
+ if (!decoder) {
+ return NS_ERROR_FAILURE;
+ }
LOG(LogLevel::Debug,
("%p Cloned decoder %p from %p", this, decoder.get(), aOriginal));
@@ -6685,7 +6697,9 @@ VideoFrameContainer* HTMLMediaElement::GetVideoFrameContainer() {
return nullptr;
}
- if (mVideoFrameContainer) return mVideoFrameContainer;
+ if (mVideoFrameContainer) {
+ return mVideoFrameContainer;
+ }
// Only video frames need an image container.
if (!IsVideo()) {
@@ -7111,7 +7125,9 @@ HTMLSourceElement* HTMLMediaElement::GetNextSource() {
}
void HTMLMediaElement::ChangeDelayLoadStatus(bool aDelay) {
- if (mDelayingLoadEvent == aDelay) return;
+ if (mDelayingLoadEvent == aDelay) {
+ return;
+ }
mDelayingLoadEvent = aDelay;