commit a96addd166e92755fbd9625bcd4056041ea1fc2f
parent 26fd1f37a5c468a3efc812e5020d5c4cc36d56cf
Author: Alexander Cooper <alcooper@chromium.org>
Date: Thu, 6 Nov 2025 21:34:28 +0000
Bug 1997716 [wpt PR 55800] - Split render_state_update test into two, a=testonly
Automatic update from web-platform-tests
Split render_state_update test into two
While the test has been reliably okay for a while, there's been a recent
surge of flakiness which seems to center around the single inline test
hanging. In order to better isolate this, split the inline test into its
own file.
Bug: 456455370
Change-Id: I8bcd85e0265b63498277d5cae71e9655be9337b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7108259
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538863}
--
wpt-commits: 634f0ee3e2f40414f4fb98e1c8a595999ffc4b4e
wpt-pr: 55800
Diffstat:
2 files changed, 38 insertions(+), 28 deletions(-)
diff --git a/testing/web-platform/tests/webxr/render_state_update.https.html b/testing/web-platform/tests/webxr/render_state_update.https.html
@@ -52,31 +52,6 @@ let testNoParams = function(session, fakeDeviceController, t) {
});
};
-let testParams = function(session, fakeDeviceController, t, sessionObjects) {
- return new Promise((resolve, reject) => {
- let gl = sessionObjects.gl;
- try {
- gl.makeXRCompatible().then(() => {
- t.step(() => {
- let fov = Math.PI;
- let near = 0.2;
- let far = 0.8;
- let layer = new XRWebGLLayer(session, gl);
- session.updateRenderState({ inlineVerticalFieldOfView: fov, depthNear: near, depthFar: far, baseLayer: layer });
- // The update can only happen between frame boundaries, updateRenderState only queues changes.
- assert_not_equals(session.renderState.inlineVerticalFieldOfView, fov);
- assert_not_equals(session.renderState.depthNear, near);
- assert_not_equals(session.renderState.depthFar, far);
- assert_not_equals(session.renderState.baseLayer, layer);
- });
- });
- } catch (err) {
- assert_unreached("updateRenderState should not fail when all params are specified");
- }
- resolve();
- });
-};
-
let testMinMaxClippingPlanes = function(session, fakeDeviceController, t, sessionObjects) {
return new Promise((resolve, reject) => {
let gl = sessionObjects.gl;
@@ -123,9 +98,6 @@ xr_session_promise_test(testName, testFieldOfView, fakeDeviceInitParams, 'immers
testName = "updateRenderState handles appropriately XRRenderStateInit with no params";
xr_session_promise_test(testName, testNoParams, fakeDeviceInitParams, 'immersive-vr');
-testName = "updateRenderState handles appropriately XRRenderStateInit params";
-xr_session_promise_test(testName, testParams, fakeDeviceInitParams, 'inline');
-
testName = "updateRenderState clamps appropriately near/far clipping planes";
xr_session_promise_test(testName, testMinMaxClippingPlanes, fakeDeviceInitParams, 'immersive-vr');
diff --git a/testing/web-platform/tests/webxr/render_state_update_inline.https.html b/testing/web-platform/tests/webxr/render_state_update_inline.https.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="resources/webxr_util.js"></script>
+<script src="resources/webxr_test_constants.js"></script>
+
+<script>
+let fakeDeviceInitParams = TRACKED_IMMERSIVE_DEVICE;
+
+let testParams = function(session, fakeDeviceController, t, sessionObjects) {
+ return new Promise((resolve, reject) => {
+ let gl = sessionObjects.gl;
+ try {
+ gl.makeXRCompatible().then(() => {
+ t.step(() => {
+ let fov = Math.PI;
+ let near = 0.2;
+ let far = 0.8;
+ let layer = new XRWebGLLayer(session, gl);
+ session.updateRenderState({ inlineVerticalFieldOfView: fov, depthNear: near, depthFar: far, baseLayer: layer });
+ // The update can only happen between frame boundaries, updateRenderState only queues changes.
+ assert_not_equals(session.renderState.inlineVerticalFieldOfView, fov);
+ assert_not_equals(session.renderState.depthNear, near);
+ assert_not_equals(session.renderState.depthFar, far);
+ assert_not_equals(session.renderState.baseLayer, layer);
+ });
+ });
+ } catch (err) {
+ assert_unreached("updateRenderState should not fail when all params are specified");
+ }
+ resolve();
+ });
+};
+
+let testName = "updateRenderState handles appropriately XRRenderStateInit params";
+xr_session_promise_test(testName, testParams, fakeDeviceInitParams, 'inline');
+
+</script>
