tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit a4b46b07d1b02ffa08a4ec1d8d4ca0fbb72c6f58
parent c0d9d01c327c8e9098961e0a5eacf19601f96671
Author: Dharma Ong <dharmaong00@gmail.com>
Date:   Wed, 17 Dec 2025 15:39:11 +0000

Bug 2005392 - Remove expired urlbar.pref_switch_tabs_search_all_containers metric. r=mak,urlbar-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D276686

Diffstat:
Mbrowser/components/urlbar/content/UrlbarInput.mjs | 7-------
Mbrowser/components/urlbar/metrics.yaml | 16----------------
Mbrowser/components/urlbar/tests/browser/browser.toml | 3---
Dbrowser/components/urlbar/tests/browser/browser_urlbar_telemetry_searchContainers.js | 34----------------------------------
4 files changed, 0 insertions(+), 60 deletions(-)

diff --git a/browser/components/urlbar/content/UrlbarInput.mjs b/browser/components/urlbar/content/UrlbarInput.mjs @@ -339,13 +339,6 @@ export class UrlbarInput extends HTMLElement { // The engine name is not known yet, but update placeholder anyway to // reflect value of keyword.enabled or set the searchbar placeholder. this._setPlaceholder(null); - - if (this.#isAddressbar) { - let searchContainersPref = lazy.UrlbarPrefs.get( - "switchTabs.searchAllContainers" - ); - Glean.urlbar.prefSwitchTabsSearchAllContainers.set(searchContainersPref); - } } connectedCallback() { diff --git a/browser/components/urlbar/metrics.yaml b/browser/components/urlbar/metrics.yaml @@ -882,22 +882,6 @@ urlbar: send_in_pings: - events - pref_switch_tabs_search_all_containers: - lifetime: application - type: boolean - description: > - Whether the "Switch to Tab" feature searches across all containers. - Corresponds to the value of the `browser.urlbar.switchTabs.searchAllContainers` pref. - bugs: - - https://bugzilla.mozilla.org/show_bug.cgi?id=1974961 - data_reviews: - - https://bugzilla.mozilla.org/show_bug.cgi?id=1974961 - data_sensitivity: - - technical - notification_emails: - - fx-search-telemetry@mozilla.com - expires: 149 - autofill_deletion: type: counter description: > diff --git a/browser/components/urlbar/tests/browser/browser.toml b/browser/components/urlbar/tests/browser/browser.toml @@ -780,9 +780,6 @@ tags = "search-telemetry" ["browser_urlbar_telemetry_remotetab.js"] tags = "search-telemetry" -["browser_urlbar_telemetry_searchContainers.js"] -tags = "search-telemetry" - ["browser_urlbar_telemetry_searchmode.js"] tags = "search-telemetry" support-files = [ diff --git a/browser/components/urlbar/tests/browser/browser_urlbar_telemetry_searchContainers.js b/browser/components/urlbar/tests/browser/browser_urlbar_telemetry_searchContainers.js @@ -1,34 +0,0 @@ -/* Any copyright is dedicated to the Public Domain. - * http://creativecommons.org/publicdomain/zero/1.0/ - */ - -/** - * Tests telemetry for pref_switch_tabs_search_all_containers Glean metric - */ - -"use strict"; - -const PREF = "browser.urlbar.switchTabs.searchAllContainers"; - -add_setup(async function () { - Services.fog.initializeFOG(); -}); - -add_task(async function test_switchTabs_searchAllContainers_pref() { - for (let value of [false, true]) { - await SpecialPowers.pushPrefEnv({ - set: [[PREF, value]], - }); - - let newWin = await BrowserTestUtils.openNewBrowserWindow(); - - let result = Glean.urlbar.prefSwitchTabsSearchAllContainers.testGetValue(); - Assert.equal( - result, - value, - `Setting pref to ${value} should make the metric ${value}` - ); - - newWin.close(); - } -});