tor-browser

commit a37ec88e9be65105846db8d2ab65850d3c017808
parent 5cf8e7214a2e6dea79920680135bad6621fb4c62
Author: Jamie Nicol <jnicol@mozilla.com>
Date:   Wed, 12 Nov 2025 17:06:25 +0000

Bug 1999681 - Ensure shader source strings are null terminated on Mali-G57. r=gfx-reviewers,lsalzman

We are seeing a lot of crashes in glShaderSource on Mali-G57 devices.
We have previously seen crashes due to shader source strings not being
null terminated on different Mali devices. As a speculative fix, apply
the same workaround of null terminating the strings on Mali-G57 too.

Differential Revision: https://phabricator.services.mozilla.com/D272236

Diffstat:
M
gfx/wr/webrender/src/device/gl.rs
 | 
3
++-

1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gfx/wr/webrender/src/device/gl.rs b/gfx/wr/webrender/src/device/gl.rs
@@ -1712,7 +1712,8 @@ impl Device {
         // can crash if the source strings are not null-terminated.
         // See bug 1591945 and bug 1799722.
         let requires_null_terminated_shader_source = is_emulator || renderer_name == "Mali-T628"
-            || renderer_name == "Mali-T720" || renderer_name == "Mali-T760";
+            || renderer_name == "Mali-T720" || renderer_name == "Mali-T760"
+            || renderer_name == "Mali-G57";
 
         // The android emulator gets confused if you don't explicitly unbind any texture
         // from GL_TEXTURE_EXTERNAL_OES before binding another to GL_TEXTURE_2D. See bug 1636085.