commit a262cf53778889c0e3289010184ea9e6462be4f7 parent ef98fd5f1d72d1e9f3b692439985c34dcdf71cb0 Author: Daisuke Akatsuka <daisuke@birchill.co.jp> Date: Thu, 20 Nov 2025 22:19:21 +0000 Bug 1996171: Remove 'browser.urlbar.quicksuggest.dataCollection.enabled' pref r=profiles-reviewers,adw,omc-reviewers,aminomancer,jhirsch Differential Revision: https://phabricator.services.mozilla.com/D272413 Diffstat:
7 files changed, 1 insertion(+), 25 deletions(-)
diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js @@ -486,16 +486,6 @@ pref("browser.urlbar.suggest.quicksuggest.nonsponsored", false, sticky); // default-branch values, the user is enrolled in over time. pref("browser.urlbar.suggest.quicksuggest.sponsored", false, sticky); -// TODO: Remove this pref, which is the old opt-in pref for online Firefox -// Suggest. We need to keep it for now because some live Nimbus experiments use -// a targeting filter that depends on it. Original comment below. -// -// Whether data collection is enabled for quick suggest results in the urlbar. -// This pref is exposed to the user in the UI, and it's sticky so that its -// user-branch value persists regardless of whatever Firefox Suggest scenarios, -// with their various default-branch values, the user is enrolled in over time. -pref("browser.urlbar.quicksuggest.dataCollection.enabled", false, sticky); - // Whether online Firefox Suggest is available to the user. This is only // relevant when Suggest overall is enabled [1]. When true, a checkbox will be // shown in the settings UI allowing to the user to toggle online Suggest. diff --git a/browser/components/asrouter/modules/ASRouterTriggerListeners.sys.mjs b/browser/components/asrouter/modules/ASRouterTriggerListeners.sys.mjs @@ -115,7 +115,6 @@ export const ASRouterTriggerListeners = new Map([ "datareporting.healthreport.uploadEnabled", "datareporting.usage.uploadEnabled", "datareporting.policy.dataSubmissionEnabled", - "browser.urlbar.quicksuggest.dataCollection.enabled", "app.shield.optoutstudies.enabled", "browser.crashReports.unsubmittedCheck.autoSubmit2", "browser.discovery.enabled", diff --git a/browser/components/profiles/SelectableProfileService.sys.mjs b/browser/components/profiles/SelectableProfileService.sys.mjs @@ -187,7 +187,6 @@ class SelectableProfileServiceClass extends EventEmitter { "browser.crashReports.unsubmittedCheck.autoSubmit2", "browser.discovery.enabled", "browser.shell.checkDefaultBrowser", - "browser.urlbar.quicksuggest.dataCollection.enabled", DAU_GROUPID_PREF_NAME, "datareporting.healthreport.uploadEnabled", "datareporting.policy.currentPolicyVersion", @@ -210,6 +209,7 @@ class SelectableProfileServiceClass extends EventEmitter { // Preferences that were previously shared but should now be ignored. static ignoredSharedPrefs = [ "browser.profiles.enabled", + "browser.urlbar.quicksuggest.dataCollection.enabled", "toolkit.profiles.storeID", ]; diff --git a/browser/components/urlbar/UrlbarPrefs.sys.mjs b/browser/components/urlbar/UrlbarPrefs.sys.mjs @@ -292,11 +292,6 @@ const PREF_URLBAR_DEFAULTS = /** @type {PreferenceDefinition[]} */ ([ // impression. ["quicksuggest.contextualOptIn.impressionDaysLimit", 5], - // TODO: Remove this pref, which is the old opt-in pref for online Firefox - // Suggest. We need to keep it for now because some live Nimbus experiments - // use a targeting filter that depends on it. - ["quicksuggest.dataCollection.enabled", false], - // Comma-separated list of Suggest dynamic suggestion types to enable. ["quicksuggest.dynamicSuggestionTypes", ""], diff --git a/toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs b/toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs @@ -226,7 +226,6 @@ export const PREFS = Object.freeze({ "browser.startup.page": PREF_INT, "browser.toolbars.bookmarks.visibility": PREF_STRING, "browser.urlbar.lastUrlbarSearchSeconds": PREF_INT, - "browser.urlbar.quicksuggest.dataCollection.enabled": PREF_BOOL, "browser.urlbar.showSearchSuggestionsFirst": PREF_BOOL, "browser.urlbar.suggest.quicksuggest.sponsored": PREF_BOOL, "media.videocontrols.picture-in-picture.enabled": PREF_BOOL, diff --git a/toolkit/components/nimbus/metrics.yaml b/toolkit/components/nimbus/metrics.yaml @@ -88,7 +88,6 @@ nimbus_targeting_environment: - "browser.startup.page" - "browser.toolbars.bookmarks.visibility" - "browser.urlbar.lastUrlbarSearchSeconds" - - "browser.urlbar.quicksuggest.dataCollection.enabled" - "browser.urlbar.showSearchSuggestionsFirst" - "browser.urlbar.suggest.quicksuggest.sponsored" - "media.videocontrols.picture-in-picture.enabled" @@ -203,8 +202,6 @@ nimbus_targeting_environment: type: string browser__urlbar__lastUrlbarSearchSeconds: type: number - browser__urlbar__quicksuggest__dataCollection__enabled: - type: boolean browser__urlbar__showSearchSuggestionsFirst: type: boolean browser__urlbar__suggest__quicksuggest__sponsored: diff --git a/tools/@types/subs/FeatureManifest.sys.d.mts b/tools/@types/subs/FeatureManifest.sys.d.mts @@ -362,10 +362,6 @@ export const FeatureManifest: { }; description: string; }; - quickSuggestDataCollectionEnabled: { - type: string; - description: string; - }; quickSuggestDynamicSuggestionTypes: { type: string; setPref: {