commit a2586e4723b725d111ec72b3f090d1ecd62a04c7 parent 471dcac98ccebf520fbdf0d10c3ed56189c8a55e Author: Cosmin Sabou <csabou@mozilla.com> Date: Tue, 9 Dec 2025 14:15:58 +0200 Revert "Bug 1988726 - Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn,desktop-theme-reviewers,dao" for causing bc failures on browser_ext_popup_corners.js This reverts commit a2e37315c4de688220d62642edf782360aa0cb7e. Diffstat:
24 files changed, 7 insertions(+), 92 deletions(-)
diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js @@ -424,11 +424,7 @@ pref("browser.urlbar.deduplication.thresholdDays", 0); pref("browser.urlbar.scotchBonnet.enableOverride", true); -#ifdef NIGHTLY_BUILD -pref("browser.urlbar.trustPanel.featureGate", true); -#else pref("browser.urlbar.trustPanel.featureGate", false); -#endif // Once Perplexity has entered search mode at least once, // we no longer show the Perplexity onboarding callout. diff --git a/browser/base/content/test/about/browser_aboutNetError_blank_page.js b/browser/base/content/test/about/browser_aboutNetError_blank_page.js @@ -21,10 +21,7 @@ async function test_blankPage( header = "show" // show (zero content-length), hide (no content-length), or lie (non-empty content-length) ) { await SpecialPowers.pushPrefEnv({ - set: [ - ["browser.http.blank_page_with_error_response.enabled", false], - ["browser.urlbar.trustPanel.featureGate", false], - ], + set: [["browser.http.blank_page_with_error_response.enabled", false]], }); let browser; diff --git a/browser/base/content/test/general/browser_addCertException.js b/browser/base/content/test/general/browser_addCertException.js @@ -9,12 +9,6 @@ // using the button contained therein to load the certificate exception // dialog, using that to add an exception, and finally successfully visiting // the site, including showing the right identity box and control center icons. -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task(async function () { for (let feltPrivacyEnabled of [true, false]) { await SpecialPowers.pushPrefEnv({ diff --git a/browser/base/content/test/keyboard/browser_toolbarKeyNav.js b/browser/base/content/test/keyboard/browser_toolbarKeyNav.js @@ -123,7 +123,6 @@ add_setup(async function () { ["test.wait300msAfterTabSwitch", true], // TODO: Reenable in https://bugzilla.mozilla.org/show_bug.cgi?id=1923388 ["browser.urlbar.scotchBonnet.enableOverride", false], - ["browser.urlbar.trustPanel.featureGate", false], ["browser.toolbars.keyboard_navigation", true], ["accessibility.tabfocus", 7], // Taskbar Tabs' page action is controlled by a pref that differs across diff --git a/browser/base/content/test/popupNotifications/browser_popupNotification_hide_after_identity_panel.js b/browser/base/content/test/popupNotifications/browser_popupNotification_hide_after_identity_panel.js @@ -2,12 +2,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task(async function test_displayURI_geo() { await BrowserTestUtils.withNewTab( "https://test1.example.com/", diff --git a/browser/base/content/test/popupNotifications/browser_popupNotification_hide_after_protections_panel.js b/browser/base/content/test/popupNotifications/browser_popupNotification_hide_after_protections_panel.js @@ -2,12 +2,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task(async function test_hide_popup_with_protections_panel_showing() { await BrowserTestUtils.withNewTab( "https://test1.example.com/", diff --git a/browser/base/content/test/protectionsUI/browser.toml b/browser/base/content/test/protectionsUI/browser.toml @@ -13,10 +13,6 @@ support-files = [ "trackingPage.html", ] -prefs = [ - "browser.urlbar.trustPanel.featureGate=false" -] - ["browser_protectionsUI.js"] https_first_disabled = true diff --git a/browser/base/content/test/siteIdentity/browser.toml b/browser/base/content/test/siteIdentity/browser.toml @@ -5,7 +5,6 @@ support-files = [ "!/image/test/mochitest/blue.png", ] prefs = [ - "browser.urlbar.trustPanel.featureGate=false", "security.certerrors.felt-privacy-v1=true" ] diff --git a/browser/base/content/test/sync/browser_contextmenu_sendtab.js b/browser/base/content/test/sync/browser_contextmenu_sendtab.js @@ -54,10 +54,7 @@ function updateTabContextMenu(tab = gBrowser.selectedTab) { add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["browser.urlbar.trustPanel.featureGate", false], - ["test.wait300msAfterTabSwitch", true], - ], + set: [["test.wait300msAfterTabSwitch", true]], }); await promiseSyncReady(); diff --git a/browser/base/content/test/sync/browser_sync.js b/browser/base/content/test/sync/browser_sync.js @@ -31,10 +31,7 @@ add_setup(async function () { // when in the signed-out state, we need to set the state _before_ opening // the FxA menu (since the panel cannot be opened) in the signed out state. await SpecialPowers.pushPrefEnv({ - set: [ - ["browser.urlbar.trustPanel.featureGate", false], - ["identity.fxaccounts.toolbar.accessed", true], - ], + set: [["identity.fxaccounts.toolbar.accessed", true]], }); }); diff --git a/browser/components/customizableui/test/browser.toml b/browser/components/customizableui/test/browser.toml @@ -6,7 +6,6 @@ support-files = [ prefs = [ "browser.sessionstore.closedTabsFromAllWindows=true", "browser.sessionstore.closedTabsFromClosedWindows=true", - "browser.urlbar.trustPanel.featureGate=false", "sidebar.revamp=false", ] diff --git a/browser/components/extensions/test/browser/browser_ext_commands_execute_page_action.js b/browser/components/extensions/test/browser/browser_ext_commands_execute_page_action.js @@ -7,10 +7,7 @@ const scriptPage = url => add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["browser.urlbar.trustPanel.featureGate", false], - ["test.wait300msAfterTabSwitch", true], - ], + set: [["test.wait300msAfterTabSwitch", true]], }); }); diff --git a/browser/components/places/tests/browser/browser_bookmarks_toolbar_drag_with_chevron.js b/browser/components/places/tests/browser/browser_bookmarks_toolbar_drag_with_chevron.js @@ -6,10 +6,7 @@ add_setup(async function () { await SpecialPowers.pushPrefEnv({ - set: [ - ["browser.toolbars.bookmarks.visibility", "newtab"], - ["browser.urlbar.trustPanel.featureGate", false], - ], + set: [["browser.toolbars.bookmarks.visibility", "newtab"]], }); info("Open new tab and bookmarks toolbar"); diff --git a/browser/components/reportbrokensite/test/browser/head.js b/browser/components/reportbrokensite/test/browser/head.js @@ -48,7 +48,6 @@ function add_common_setup() { add_setup(async function () { await SpecialPowers.pushPrefEnv({ set: [ - ["browser.urlbar.trustPanel.featureGate", false], [PREFS.NEW_REPORT_ENDPOINT, NEW_REPORT_ENDPOINT_TEST_URL], // set touch events to auto-detect, as the pref gets set to 1 somewhere diff --git a/browser/extensions/formautofill/test/browser/address/browser_address_doorhanger_confirmation_popup.js b/browser/extensions/formautofill/test/browser/address/browser_address_doorhanger_confirmation_popup.js @@ -6,7 +6,6 @@ add_setup(async function () { await SpecialPowers.pushPrefEnv({ set: [ - ["browser.urlbar.trustPanel.featureGate", false], ["test.wait300msAfterTabSwitch", true], ["extensions.formautofill.addresses.capture.enabled", true], ["extensions.formautofill.addresses.supported", "on"], diff --git a/browser/extensions/webcompat/tests/browser/browser_smartblockembeds.js b/browser/extensions/webcompat/tests/browser/browser_smartblockembeds.js @@ -6,8 +6,8 @@ add_setup(async function () { await SpecialPowers.pushPrefEnv({ set: [ - ["browser.urlbar.trustPanel.featureGate", false], ["test.wait300msAfterTabSwitch", true], + // Extend clickjacking delay for test because timer expiry can happen before we // check the toggle is disabled (especially in chaos mode). [SEC_DELAY_PREF, 1000], diff --git a/browser/themes/shared/identity-block/identity-block.css b/browser/themes/shared/identity-block/identity-block.css @@ -317,9 +317,6 @@ padding-inline: var(--urlbar-icon-padding); border-radius: var(--urlbar-inner-border-radius); -moz-context-properties: fill, fill-opacity; - /* Height shouldn't need defined here but is failing wpt tests without. - Investigating in https://bugzilla.mozilla.org/show_bug.cgi?id=2004907 */ - height: calc(16px + (2 * var(--urlbar-icon-padding))); /* The urlbar will show insecure or secure icon by default depending on the state of the connection, the further clauses may override that. */ diff --git a/browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js b/browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js @@ -6,12 +6,6 @@ "use strict"; -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task(async function capture() { if (!shouldCapture()) { return; diff --git a/dom/security/test/https-only/browser_continue_button_delay.js b/dom/security/test/https-only/browser_continue_button_delay.js @@ -57,12 +57,6 @@ async function waitForEnabledButtonAndCheckTiming() { ); } -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task(async function () { await SpecialPowers.pushPrefEnv({ set: [["dom.security.https_only_mode", true]], diff --git a/toolkit/components/extensions/test/browser/browser_ext_themes_arrowpanels.js b/toolkit/components/extensions/test/browser/browser_ext_themes_arrowpanels.js @@ -20,12 +20,6 @@ function closeIdentityPopup() { return promise; } -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - // This test checks applied WebExtension themes that attempt to change // popup properties diff --git a/toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_open_protection_panel.js b/toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_open_protection_panel.js @@ -3,12 +3,6 @@ "use strict"; -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task(async function test_OPEN_PROTECTION_PANEL() { await BrowserTestUtils.withNewTab(EXAMPLE_URL, async () => { const popupshown = BrowserTestUtils.waitForEvent( diff --git a/toolkit/components/passwordmgr/test/browser/browser_doorhanger_remembering.js b/toolkit/components/passwordmgr/test/browser/browser_doorhanger_remembering.js @@ -54,10 +54,7 @@ requestLongerTimeout(2); add_setup(async function () { // We do not want http://example.com etc. to be upgraded to https await SpecialPowers.pushPrefEnv({ - set: [ - ["browser.urlbar.trustPanel.featureGate", false], - ["dom.security.https_first", false], - ], + set: [["dom.security.https_first", false]], }); // Load recipes for this test. diff --git a/toolkit/components/passwordmgr/test/browser/browser_formless_submit_chrome.js b/toolkit/components/passwordmgr/test/browser/browser_formless_submit_chrome.js @@ -48,9 +48,6 @@ function withTestPage(aTaskFn) { } add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); await SimpleTest.promiseFocus(window); }); diff --git a/toolkit/components/passwordmgr/test/browser/browser_relay_signup_flow.js b/toolkit/components/passwordmgr/test/browser/browser_relay_signup_flow.js @@ -5,12 +5,6 @@ Services.scriptloader.loadSubScript( this ); -add_setup(async function () { - await SpecialPowers.pushPrefEnv({ - set: [["browser.urlbar.trustPanel.featureGate", false]], - }); -}); - add_task( async function test_default_does_not_display_Relay_to_unauthenticated_browser() { await BrowserTestUtils.withNewTab(