tor-browser

commit 9e80ac1401c44849d5ecf1c40e8dd5cb40fcf13b
parent 6a1bf0a168094a71f21f700472b00de770b18e0e
Author: Irene Ni <ini@mozilla.com>
Date:   Fri, 19 Dec 2025 21:46:15 +0000

Bug 2006471 - Have New Tab frecency-based sorting dedupe against spocs on initial load. r=home-newtab-reviewers,thecount

Differential Revision: https://phabricator.services.mozilla.com/D277049

Diffstat:
M
browser/extensions/newtab/lib/TopSitesFeed.sys.mjs
 | 
28
+++++++++++++++++++---------

1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/browser/extensions/newtab/lib/TopSitesFeed.sys.mjs b/browser/extensions/newtab/lib/TopSitesFeed.sys.mjs
@@ -1473,11 +1473,7 @@ export class TopSitesFeed {
         .filter(site => site.type !== "frecency-boost")
         .map(site => {
           try {
-            return (
-              site.label?.toLowerCase() ||
-              site.hostname ||
-              lazy.NewTabUtils.shortURL(site)
-            );
+            return site.hostname || lazy.NewTabUtils.shortURL(site);
           } catch (e) {
             return null;
           }
@@ -1979,13 +1975,27 @@ export class TopSitesFeed {
       let link = null;
       const { assignedPartner } = allocation;
       if (assignedPartner) {
-        // Unknown partners are allowed so that new parters can be added to Shepherd
-        // sooner without waiting for client changes.
-        link = sponsoredLinks[assignedPartner]?.shift();
+        while (sponsoredLinks[assignedPartner].length) {
+          // Unknown partners are allowed so that new partners can be added to Shepherd
+          // sooner without waiting for client changes.
+          const candidate = sponsoredLinks[assignedPartner]?.shift();
+
+          // Deduplicate against sponsored links that have already been added.
+          const duplicateSponsor = sponsored.find(
+            s =>
+              s.label?.toLowerCase() === candidate.label?.toLowerCase() ||
+              s.hostname === candidate.hostname
+          );
+
+          if (!duplicateSponsor) {
+            link = candidate;
+            break;
+          }
+        }
       }
 
       if (!link) {
-        // If the chosen partner doesn't have a tile for this postion, choose any
+        // If the chosen partner doesn't have a tile for this position, choose any
         // one from another group. For simplicity, we do _not_ do resampling here
         // against the remaining partners.
         for (const partner of SPONSORED_TILE_PARTNERS) {