commit 9cb06af1879ce20a698b49e4071ccb3075b2240f
parent 5d351e4afb1973865aa4dfe7235ab267e5f77b06
Author: Dan Baker <dbaker@mozilla.com>
Date: Mon, 1 Dec 2025 18:19:24 -0700
Bug 2000941 - Vendor libwebrtc from 640c1aeea2
Upstream commit: https://webrtc.googlesource.com/src/+/640c1aeea2e8278122c9ad32788060aa9a5d5a0b
Remove the deprecated SdpDeserializeCandidate function
This function was already marked as deprecated in the header file, with
a notice directing users to use `IceCandidate::Create` as the
replacement.
This patch completes the deprecation by removing the function's
declaration from webrtc_sdp.h and its corresponding implementation from
webrtc_sdp.cc.
Bug: webrtc:42233526
Change-Id: Id754c9f6dc8b203acfbdd8551acc661ccbc1498c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/408801
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45600}
Diffstat:
3 files changed, 2 insertions(+), 32 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-12-02T01:09:12.139655+00:00.
+libwebrtc updated from /Users/danielbaker/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-12-02T01:19:09.715699+00:00.
# base of lastest vendoring
-c223e2036e
+640c1aeea2
diff --git a/third_party/libwebrtc/pc/webrtc_sdp.cc b/third_party/libwebrtc/pc/webrtc_sdp.cc
@@ -3433,21 +3433,6 @@ std::unique_ptr<SessionDescriptionInterface> SdpDeserialize(
return description;
}
-bool SdpDeserializeCandidate(absl::string_view transport_name,
- absl::string_view message,
- Candidate* candidate,
- SdpParseError* error) {
- RTC_DCHECK(candidate != nullptr);
- if (!ParseCandidate(message, candidate, error, true)) {
- return false;
- }
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- candidate->set_transport_name(transport_name);
-#pragma clang diagnostic pop
- return true;
-}
-
bool ParseCandidate(absl::string_view message,
Candidate* candidate,
SdpParseError* error,
diff --git a/third_party/libwebrtc/pc/webrtc_sdp.h b/third_party/libwebrtc/pc/webrtc_sdp.h
@@ -73,21 +73,6 @@ absl_nullable std::unique_ptr<SessionDescriptionInterface> SdpDeserialize(
absl::string_view sdp,
SdpParseError* absl_nullable error = nullptr);
-// Deserializes the passed in SDP string to a cricket Candidate.
-// The first line must be a=candidate line and only the first line will be
-// parsed.
-// transport_name - The transport name (MID) of the candidate.
-// message - The SDP string to be deserialized.
-// candidate - The cricket Candidate from the SDP string.
-// error - The detail error information when parsing fails.
-// return - true on success, false on failure.
-// TODO(bugs.webrtc.org/42233526): Remove.
-[[deprecated("Use IceCandidate::Create instead.")]]
-RTC_EXPORT bool SdpDeserializeCandidate(absl::string_view transport_name,
- absl::string_view message,
- Candidate* candidate,
- SdpParseError* error);
-
// Parses `message` according to the grammar defined in RFC 5245, Section 15.1
// and, if successful, stores the result in `candidate` and returns true.
// If unsuccessful, returns false and stores error information in `error` if
