tor-browser

commit 9ac19416c3ab534bdcde6c48f12ae2b25e6d7d91
parent 46b34254a2dfc01e2f5de5954066ddf1094a1811
Author: Luca Greco <lgreco@mozilla.com>
Date:   Thu, 13 Nov 2025 20:35:00 +0000

Bug 1999957 - Fix frequent failures hit by test_ext_simple.js xpcshell test while xpcshell tests are executed in parallel. r=willdurand

Differential Revision: https://phabricator.services.mozilla.com/D272445

Diffstat:
M
toolkit/components/extensions/test/xpcshell/test_ext_simple.js
 | 
39
++++++++++++++++++++++++++++++---------

1 file changed, 30 insertions(+), 9 deletions(-)
diff --git a/toolkit/components/extensions/test/xpcshell/test_ext_simple.js b/toolkit/components/extensions/test/xpcshell/test_ext_simple.js
@@ -11,6 +11,10 @@ AddonTestUtils.createAppInfo(
   "43"
 );
 
+add_setup(async () => {
+  await AddonTestUtils.promiseStartupManager();
+});
+
 add_task(async function test_simple() {
   let extensionData = {
     manifest: {
@@ -120,8 +124,6 @@ add_task(async function test_extensionTypes() {
 });
 
 add_task(async function test_policy_temporarilyInstalled() {
-  await AddonTestUtils.promiseStartupManager();
-
   let extensionData = {
     manifest: {
       manifest_version: 2,
@@ -190,19 +192,38 @@ add_task(async function test_manifest_allowInsecureRequests_throws() {
 });
 
 add_task(async function test_gecko_android_key_in_applications() {
-  const extensionData = {
+  const xpiFile = AddonTestUtils.createTempWebExtensionFile({
     manifest: {
       manifest_version: 2,
       applications: {
         gecko_android: {},
       },
     },
-  };
-  const extension = ExtensionTestUtils.loadExtension(extensionData);
+  });
 
-  await Assert.rejects(
-    extension.startup(),
-    /applications: Property "gecko_android" is unsupported by Firefox/,
-    "expected applications.gecko_android to be invalid"
+  ExtensionTestUtils.failOnSchemaWarnings(false);
+  let { messages } = await promiseConsoleOutput(async () => {
+    const { AddonManager } = ChromeUtils.importESModule(
+      "resource://gre/modules/AddonManager.sys.mjs"
+    );
+    await Assert.rejects(
+      AddonManager.installTemporaryAddon(xpiFile),
+      /Extension is invalid/,
+      "Install failed with privileged permission"
+    );
+  });
+  ExtensionTestUtils.failOnSchemaWarnings(true);
+  AddonTestUtils.checkMessages(
+    messages,
+    {
+      expected: [
+        {
+          message:
+            /applications: Property "gecko_android" is unsupported by Firefox/,
+        },
+      ],
+    },
+    true
   );
+  xpiFile.remove(true);
 });