tor-browser

commit 98b91beb72b63447b9ca1d9aab3fc6862b18ddd0
parent 65643858cfd85b9d8638420165dc68279118c71f
Author: Tom Ritter <tom@mozilla.com>
Date:   Mon,  8 Dec 2025 16:31:03 +0000

Bug 1873716: Remove the 'shouldReport' parameter r=timhuang

Based on the fact that no other reporting mechanism cares about
the DATA_RECEIVED flag, and that it eliminates about 75% of the
reports we would have received, remove this argument and do not
change any behavior based on it

Differential Revision: https://phabricator.services.mozilla.com/D274959

Diffstat:
M
dom/ipc/WindowGlobalParent.cpp
 | 
6
+-----
M
toolkit/components/antitracking/ContentBlockingLog.cpp
 | 
2
+-
M
toolkit/components/antitracking/ContentBlockingLog.h
 | 
3
+--

3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/dom/ipc/WindowGlobalParent.cpp b/dom/ipc/WindowGlobalParent.cpp
@@ -1656,12 +1656,8 @@ void WindowGlobalParent::ActorDestroy(ActorDestroyReason aWhy) {
         GetContentBlockingLog()->ReportLog();
 
         if (mDocumentURI && net::SchemeIsHttpOrHttps(mDocumentURI)) {
-          bool incrementedTopLevelContentDocumentsDestroyed =
-              pageUseCounterResult.contains(
-                  PageUseCounterResultBits::DATA_RECEIVED);
           GetContentBlockingLog()->ReportCanvasFingerprintingLog(
-              DocumentPrincipal(),
-              incrementedTopLevelContentDocumentsDestroyed);
+              DocumentPrincipal());
           GetContentBlockingLog()->ReportFontFingerprintingLog(
               DocumentPrincipal());
           GetContentBlockingLog()->ReportEmailTrackingLog(DocumentPrincipal());
diff --git a/toolkit/components/antitracking/ContentBlockingLog.cpp b/toolkit/components/antitracking/ContentBlockingLog.cpp
@@ -204,7 +204,7 @@ void ContentBlockingLog::ReportLog() {
 }
 
 void ContentBlockingLog::ReportCanvasFingerprintingLog(
-    nsIPrincipal* aFirstPartyPrincipal, bool aShouldReport) {
+    nsIPrincipal* aFirstPartyPrincipal) {
   MOZ_ASSERT(XRE_IsParentProcess());
   MOZ_ASSERT(NS_IsMainThread());
   MOZ_ASSERT(aFirstPartyPrincipal);
diff --git a/toolkit/components/antitracking/ContentBlockingLog.h b/toolkit/components/antitracking/ContentBlockingLog.h
@@ -106,8 +106,7 @@ class ContentBlockingLog final {
   }
 
   void ReportLog();
-  void ReportCanvasFingerprintingLog(nsIPrincipal* aFirstPartyPrincipal,
-                                     bool aShouldReport);
+  void ReportCanvasFingerprintingLog(nsIPrincipal* aFirstPartyPrincipal);
   void ReportFontFingerprintingLog(nsIPrincipal* aFirstPartyPrincipal);
   void ReportEmailTrackingLog(nsIPrincipal* aFirstPartyPrincipal);