commit 96f623df840eae7cb7ce2c30a54a6cfeaa19751d
parent f9094ff4fe176a148985ecc5ff9ce925ffab7062
Author: Yoichi Osato <yoichio@chromium.org>
Date: Tue, 14 Oct 2025 22:23:17 +0000
Bug 1993008 [wpt PR 55277] - Revert "geolocation: Fix permission policy wpt test", a=testonly
Automatic update from web-platform-tests
Revert "geolocation: Fix permission policy wpt test"
This reverts commit 0a95cdb341c4f15ae3ec374ab015a26eb8aeb2db.
Reason for revert: the test has been flaky since this CL:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Fgeolocation%2Fenabled-by-permissions-policy.https.sub.html?q=VHASH%3A61b41c2ab0d10d82
Original change's description:
> geolocation: Fix permission policy wpt test
>
> The two geolocation permission policy tests were timeout because there
> is no default position is set. This CL fix it by using bidi to set
> default position.
>
> Change-Id: Idcd939df64b82faaffbc15832859035d16db940f
> Bug: 347055177
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7006327
> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
> Commit-Queue: Alvin Ji <alvinji@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1524990}
Bug: 347055177
Change-Id: Ib9ae98f085570bbc44b2a720c07f49ffdde4d871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7015647
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Owners-Override: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1526027}
--
wpt-commits: b6e862ca3af572300849a63cd808cda661eccb4c
wpt-pr: 55277
Diffstat:
2 files changed, 5 insertions(+), 55 deletions(-)
diff --git a/testing/web-platform/tests/geolocation/enabled-by-permissions-policy.https.sub.html b/testing/web-platform/tests/geolocation/enabled-by-permissions-policy.https.sub.html
@@ -1,9 +1,9 @@
<!DOCTYPE html>
-<meta charset="utf-8">
+<meta charset="utf-8" />
<body>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
- <script src="/resources/testdriver.js?feature=bidi"></script>
+ <script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/permissions-policy/resources/permissions-policy.js"></script>
<script>
@@ -13,22 +13,7 @@
"https://{{hosts[alt][]}}:{{ports[https][0]}}" + same_origin_src;
promise_setup(async () => {
- // Grant permission for the top-level document's origin.
- await test_driver.bidi.permissions.set_permission({
- descriptor: {
- name: "geolocation"
- },
- state: "granted"
- });
-
- // Set a default position.
- await test_driver.bidi.emulation.set_geolocation_override({
- coordinates: {
- latitude: 0,
- longitude: 0,
- accuracy: 0
- }
- });
+ await test_driver.set_permission({ name: "geolocation" }, "granted");
});
promise_test(async (test) => {
@@ -53,15 +38,6 @@
}, "Permissions-Policy header geolocation=* allows same-origin iframes.");
promise_test(async (test) => {
- // Grant site-level permission for the cross-origin iframe's origin.
- await test_driver.bidi.permissions.set_permission({
- descriptor: {
- name: "geolocation"
- },
- state: "granted",
- origin: cross_origin_src
- });
-
await test_feature_availability({
feature_description: "Geolocation API",
test,
diff --git a/testing/web-platform/tests/geolocation/enabled-on-self-origin-by-permissions-policy.https.sub.html b/testing/web-platform/tests/geolocation/enabled-on-self-origin-by-permissions-policy.https.sub.html
@@ -1,9 +1,8 @@
<!DOCTYPE html>
-<meta charset="utf-8">
<body>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
- <script src="/resources/testdriver.js?feature=bidi"></script>
+ <script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/permissions-policy/resources/permissions-policy.js"></script>
@@ -17,22 +16,7 @@
promise_setup(async () => {
- // Grant site-level permission for the top-level document's origin.
- await test_driver.bidi.permissions.set_permission({
- descriptor: {
- name: "geolocation"
- },
- state: "granted"
- });
-
- // Set a default position.
- await test_driver.bidi.emulation.set_geolocation_override({
- coordinates: {
- latitude: 0,
- longitude: 0,
- accuracy: 0
- }
- });
+ await test_driver.set_permission({ name: "geolocation" }, "granted");
});
promise_test(async (t) => {
@@ -56,16 +40,6 @@
}, "Permissions-Policy header geolocation=(self) allows same-origin iframes.");
promise_test(async (test) => {
- // This is to ensure that the rejection is due to permission policy
- // instead of site-level permission.
- await test_driver.bidi.permissions.set_permission({
- descriptor: {
- name: "geolocation"
- },
- state: "granted",
- origin: cross_origin_src
- });
-
await test_feature_availability({
feature_description: "Geolocation API",
test,
