commit 96d84dc8cdc6f77a4863526a038c86be55fac12a parent db5cd82e7505bef73c5861b4e5f958389ba10969 Author: Michael Froman <mfroman@mozilla.com> Date: Wed, 15 Oct 2025 11:26:29 -0500 Bug 1993083 - Vendor libwebrtc from 213119e51e Upstream commit: https://webrtc.googlesource.com/src/+/213119e51e4209194ab38e706e0ab170cb32fc1c Apply clang-tidy readability-redundant-smartptr-get https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-smartptr-get.html and https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html (which resulted only in a single change) Done using tools/clang/scripts/build_clang_tools_extra.py \ --fetch out/Default clang-tidy clang-apply-replacements ninja -C out/Default gn gen out/Default --export-compile-commands cd out/Default tools/clang/third_party/llvm/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -p . \ -clang-tidy-binary tools/clang/third_party/llvm/build/bin/clang-tidy \ -clang-apply-replacements-binary \ tools/clang/third_party/llvm/build/bin/clang-apply-replacements \ -checks='-*,readability-redundant-smartptr-get,readability-named-parameter' \ -fix followed by git cl format Bug: webrtc:424706384 Change-Id: Ie5a4077286d34c1363a1d341aca50a7047f6543b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402584 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Cr-Commit-Position: refs/heads/main@{#45247} Diffstat:
46 files changed, 104 insertions(+), 107 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor @@ -1,4 +1,4 @@ # ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc -libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-15T16:20:35.868884+00:00. +libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-15T16:26:20.412349+00:00. # base of lastest vendoring -3d555146a3 +213119e51e diff --git a/third_party/libwebrtc/api/transport/stun_unittest.cc b/third_party/libwebrtc/api/transport/stun_unittest.cc @@ -1511,7 +1511,7 @@ TEST_F(StunTest, CopyAttribute) { auto attr = StunAttribute::CreateByteString(STUN_ATTR_USERNAME); attr->CopyBytes("kes", sizeof("kes")); - auto copy = CopyStunAttribute(*attr.get(), buffer_ptr); + auto copy = CopyStunAttribute(*attr, buffer_ptr); ASSERT_EQ(copy->value_type(), STUN_VALUE_BYTE_STRING); EXPECT_STREQ("kes", static_cast<StunByteStringAttribute*>(copy.get()) ->string_view() @@ -1526,7 +1526,7 @@ TEST_F(StunTest, CopyAttribute) { CheckStunAddressAttribute(addr.get(), STUN_ADDRESS_IPV6, kTestMessagePort2, test_ip); - auto copy = CopyStunAttribute(*addr.get(), buffer_ptr); + auto copy = CopyStunAttribute(*addr, buffer_ptr); ASSERT_EQ(copy->value_type(), STUN_VALUE_ADDRESS); CheckStunAddressAttribute(static_cast<StunAddressAttribute*>(copy.get()), STUN_ADDRESS_IPV6, kTestMessagePort2, test_ip); @@ -1540,7 +1540,7 @@ TEST_F(StunTest, CopyAttribute) { CheckStunAddressAttribute(addr.get(), STUN_ADDRESS_IPV6, kTestMessagePort2, test_ip); - auto copy = CopyStunAttribute(*addr.get(), buffer_ptr); + auto copy = CopyStunAttribute(*addr, buffer_ptr); ASSERT_EQ(copy->value_type(), STUN_VALUE_ADDRESS); CheckStunAddressAttribute(static_cast<StunAddressAttribute*>(copy.get()), STUN_ADDRESS_IPV6, kTestMessagePort2, test_ip); diff --git a/third_party/libwebrtc/common_audio/resampler/push_sinc_resampler.cc b/third_party/libwebrtc/common_audio/resampler/push_sinc_resampler.cc @@ -36,7 +36,7 @@ size_t PushSincResampler::Resample(const int16_t* source, size_t source_length, int16_t* destination, size_t /* destination_capacity */) { - if (!float_buffer_.get()) + if (!float_buffer_) float_buffer_.reset(new float[destination_frames_]); source_ptr_int_ = source; diff --git a/third_party/libwebrtc/common_video/libyuv/libyuv_unittest.cc b/third_party/libwebrtc/common_video/libyuv/libyuv_unittest.cc @@ -147,10 +147,10 @@ TEST_F(TestLibYuv, ConvertTest) { int ret = libyuv::I420Copy( out_i420_buffer.get(), width_, out_i420_buffer.get() + y_size, width_ >> 1, out_i420_buffer.get() + y_size + u_size, width_ >> 1, - res_i420_buffer.get()->MutableDataY(), res_i420_buffer.get()->StrideY(), - res_i420_buffer.get()->MutableDataU(), res_i420_buffer.get()->StrideU(), - res_i420_buffer.get()->MutableDataV(), res_i420_buffer.get()->StrideV(), - width_, height_); + res_i420_buffer->MutableDataY(), res_i420_buffer->StrideY(), + res_i420_buffer->MutableDataU(), res_i420_buffer->StrideU(), + res_i420_buffer->MutableDataV(), res_i420_buffer->StrideV(), width_, + height_); EXPECT_EQ(0, ret); if (PrintVideoFrame(*res_i420_buffer, output_file) < 0) { @@ -173,10 +173,10 @@ TEST_F(TestLibYuv, ConvertTest) { res_rgb_buffer2.get())); ret = libyuv::ConvertToI420( - res_rgb_buffer2.get(), 0, res_i420_buffer.get()->MutableDataY(), - res_i420_buffer.get()->StrideY(), res_i420_buffer.get()->MutableDataU(), - res_i420_buffer.get()->StrideU(), res_i420_buffer.get()->MutableDataV(), - res_i420_buffer.get()->StrideV(), 0, 0, width_, height_, + res_rgb_buffer2.get(), 0, res_i420_buffer->MutableDataY(), + res_i420_buffer->StrideY(), res_i420_buffer->MutableDataU(), + res_i420_buffer->StrideU(), res_i420_buffer->MutableDataV(), + res_i420_buffer->StrideV(), 0, 0, width_, height_, res_i420_buffer->width(), res_i420_buffer->height(), libyuv::kRotate0, ConvertVideoType(VideoType::kRGB24)); @@ -197,10 +197,10 @@ TEST_F(TestLibYuv, ConvertTest) { out_uyvy_buffer.get())); ret = libyuv::ConvertToI420( - out_uyvy_buffer.get(), 0, res_i420_buffer.get()->MutableDataY(), - res_i420_buffer.get()->StrideY(), res_i420_buffer.get()->MutableDataU(), - res_i420_buffer.get()->StrideU(), res_i420_buffer.get()->MutableDataV(), - res_i420_buffer.get()->StrideV(), 0, 0, width_, height_, + out_uyvy_buffer.get(), 0, res_i420_buffer->MutableDataY(), + res_i420_buffer->StrideY(), res_i420_buffer->MutableDataU(), + res_i420_buffer->StrideU(), res_i420_buffer->MutableDataV(), + res_i420_buffer->StrideV(), 0, 0, width_, height_, res_i420_buffer->width(), res_i420_buffer->height(), libyuv::kRotate0, ConvertVideoType(VideoType::kUYVY)); @@ -219,10 +219,10 @@ TEST_F(TestLibYuv, ConvertTest) { out_yuy2_buffer.get())); ret = libyuv::ConvertToI420( - out_yuy2_buffer.get(), 0, res_i420_buffer.get()->MutableDataY(), - res_i420_buffer.get()->StrideY(), res_i420_buffer.get()->MutableDataU(), - res_i420_buffer.get()->StrideU(), res_i420_buffer.get()->MutableDataV(), - res_i420_buffer.get()->StrideV(), 0, 0, width_, height_, + out_yuy2_buffer.get(), 0, res_i420_buffer->MutableDataY(), + res_i420_buffer->StrideY(), res_i420_buffer->MutableDataU(), + res_i420_buffer->StrideU(), res_i420_buffer->MutableDataV(), + res_i420_buffer->StrideV(), 0, 0, width_, height_, res_i420_buffer->width(), res_i420_buffer->height(), libyuv::kRotate0, ConvertVideoType(VideoType::kYUY2)); @@ -243,10 +243,10 @@ TEST_F(TestLibYuv, ConvertTest) { out_rgb565_buffer.get())); ret = libyuv::ConvertToI420( - out_rgb565_buffer.get(), 0, res_i420_buffer.get()->MutableDataY(), - res_i420_buffer.get()->StrideY(), res_i420_buffer.get()->MutableDataU(), - res_i420_buffer.get()->StrideU(), res_i420_buffer.get()->MutableDataV(), - res_i420_buffer.get()->StrideV(), 0, 0, width_, height_, + out_rgb565_buffer.get(), 0, res_i420_buffer->MutableDataY(), + res_i420_buffer->StrideY(), res_i420_buffer->MutableDataU(), + res_i420_buffer->StrideU(), res_i420_buffer->MutableDataV(), + res_i420_buffer->StrideV(), 0, 0, width_, height_, res_i420_buffer->width(), res_i420_buffer->height(), libyuv::kRotate0, ConvertVideoType(VideoType::kRGB565)); @@ -270,10 +270,10 @@ TEST_F(TestLibYuv, ConvertTest) { out_argb8888_buffer.get())); ret = libyuv::ConvertToI420( - out_argb8888_buffer.get(), 0, res_i420_buffer.get()->MutableDataY(), - res_i420_buffer.get()->StrideY(), res_i420_buffer.get()->MutableDataU(), - res_i420_buffer.get()->StrideU(), res_i420_buffer.get()->MutableDataV(), - res_i420_buffer.get()->StrideV(), 0, 0, width_, height_, + out_argb8888_buffer.get(), 0, res_i420_buffer->MutableDataY(), + res_i420_buffer->StrideY(), res_i420_buffer->MutableDataU(), + res_i420_buffer->StrideU(), res_i420_buffer->MutableDataV(), + res_i420_buffer->StrideV(), 0, 0, width_, height_, res_i420_buffer->width(), res_i420_buffer->height(), libyuv::kRotate0, ConvertVideoType(VideoType::kARGB)); @@ -315,10 +315,10 @@ TEST_F(TestLibYuv, ConvertAlignedFrame) { int ret = libyuv::I420Copy( out_i420_buffer.get(), width_, out_i420_buffer.get() + y_size, width_ >> 1, out_i420_buffer.get() + y_size + u_size, width_ >> 1, - res_i420_buffer.get()->MutableDataY(), res_i420_buffer.get()->StrideY(), - res_i420_buffer.get()->MutableDataU(), res_i420_buffer.get()->StrideU(), - res_i420_buffer.get()->MutableDataV(), res_i420_buffer.get()->StrideV(), - width_, height_); + res_i420_buffer->MutableDataY(), res_i420_buffer->StrideY(), + res_i420_buffer->MutableDataU(), res_i420_buffer->StrideU(), + res_i420_buffer->MutableDataV(), res_i420_buffer->StrideV(), width_, + height_); EXPECT_EQ(0, ret); diff --git a/third_party/libwebrtc/examples/peerconnection/client/conductor.cc b/third_party/libwebrtc/examples/peerconnection/client/conductor.cc @@ -170,7 +170,7 @@ bool Conductor::InitializePeerConnection() { RTC_DCHECK(!peer_connection_factory_); RTC_DCHECK(!peer_connection_); - if (!signaling_thread_.get()) { + if (!signaling_thread_) { signaling_thread_ = webrtc::Thread::CreateWithSocketServer(); signaling_thread_->Start(); } @@ -350,7 +350,7 @@ void Conductor::OnMessageFromPeer(int peer_id, const std::string& message) { RTC_DCHECK(peer_id_ == peer_id || peer_id_ == -1); RTC_DCHECK(!message.empty()); - if (!peer_connection_.get()) { + if (!peer_connection_) { RTC_DCHECK(peer_id_ == -1); peer_id_ = peer_id; @@ -439,7 +439,7 @@ void Conductor::OnMessageFromPeer(int peer_id, const std::string& message) { webrtc::SdpParseError error; std::unique_ptr<webrtc::IceCandidate> candidate( webrtc::CreateIceCandidate(sdp_mid, sdp_mlineindex, sdp, &error)); - if (!candidate.get()) { + if (!candidate) { RTC_LOG(LS_WARNING) << "Can't parse received candidate message. " "SdpParseError was: " << error.description; @@ -483,7 +483,7 @@ void Conductor::ConnectToPeer(int peer_id) { RTC_DCHECK(peer_id_ == -1); RTC_DCHECK(peer_id != -1); - if (peer_connection_.get()) { + if (peer_connection_) { main_wnd_->MessageBox( "Error", "We only support connecting to one peer at a time", true); return; @@ -535,7 +535,7 @@ void Conductor::AddTracks() { void Conductor::DisconnectFromCurrentPeer() { RTC_LOG(LS_INFO) << __FUNCTION__; - if (peer_connection_.get()) { + if (peer_connection_) { client_->SendHangUp(peer_id_); DeletePeerConnection(); } @@ -582,7 +582,7 @@ void Conductor::UIThreadCallback(int msg_id, void* data) { delete msg; } - if (!peer_connection_.get()) + if (!peer_connection_) peer_id_ = -1; break; diff --git a/third_party/libwebrtc/media/base/media_engine.cc b/third_party/libwebrtc/media/base/media_engine.cc @@ -321,19 +321,19 @@ bool CompositeMediaEngine::Init() { } VoiceEngineInterface& CompositeMediaEngine::voice() { - return *voice_engine_.get(); + return *voice_engine_; } VideoEngineInterface& CompositeMediaEngine::video() { - return *video_engine_.get(); + return *video_engine_; } const VoiceEngineInterface& CompositeMediaEngine::voice() const { - return *voice_engine_.get(); + return *voice_engine_; } const VideoEngineInterface& CompositeMediaEngine::video() const { - return *video_engine_.get(); + return *video_engine_; } } // namespace webrtc diff --git a/third_party/libwebrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc b/third_party/libwebrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc @@ -667,7 +667,7 @@ class AcmSenderBitExactnessOldApi : public ::testing::Test, audio_source_.reset(new test::InputAudioFile(input_file_name)); send_test_.reset(new test::AcmSendTestOldApi(audio_source_.get(), source_rate, kTestDurationMs)); - return send_test_.get() != nullptr; + return send_test_ != nullptr; } // Registers a send codec in the test::AcmSendTest object. Returns true on diff --git a/third_party/libwebrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/third_party/libwebrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc @@ -482,7 +482,7 @@ bool AudioEncoderOpusImpl::EnableAudioNetworkAdaptor( RtcEventLog* event_log) { audio_network_adaptor_ = audio_network_adaptor_creator_(config_string, event_log); - return audio_network_adaptor_.get() != nullptr; + return audio_network_adaptor_ != nullptr; } void AudioEncoderOpusImpl::DisableAudioNetworkAdaptor() { diff --git a/third_party/libwebrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc b/third_party/libwebrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc @@ -157,7 +157,7 @@ class NetEqImplTest : public ::testing::Test { red_payload_splitter_ = deps.red_payload_splitter.get(); deps.timestamp_scaler = std::unique_ptr<TimestampScaler>( - new TimestampScaler(*deps.decoder_database.get())); + new TimestampScaler(*deps.decoder_database)); neteq_.reset(new NetEqImpl(config_, std::move(deps))); ASSERT_TRUE(neteq_ != nullptr); diff --git a/third_party/libwebrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc b/third_party/libwebrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc @@ -152,7 +152,7 @@ int main(int argc, char* argv[]) { std::unique_ptr<webrtc::RtpPacketReceived> packet; while (true) { packet = file_source->NextPacket(); - if (!packet.get()) { + if (!packet) { // End of file reached. break; } diff --git a/third_party/libwebrtc/modules/audio_processing/audio_buffer.cc b/third_party/libwebrtc/modules/audio_processing/audio_buffer.cc @@ -205,7 +205,7 @@ void AudioBuffer::CopyTo(AudioBuffer* buffer) const { void AudioBuffer::RestoreNumChannels() { num_channels_ = buffer_num_channels_; data_->set_num_channels(buffer_num_channels_); - if (split_data_.get()) { + if (split_data_) { split_data_->set_num_channels(buffer_num_channels_); } } @@ -214,7 +214,7 @@ void AudioBuffer::set_num_channels(size_t num_channels) { RTC_DCHECK_GE(buffer_num_channels_, num_channels); num_channels_ = num_channels; data_->set_num_channels(num_channels); - if (split_data_.get()) { + if (split_data_) { split_data_->set_num_channels(num_channels); } } diff --git a/third_party/libwebrtc/modules/audio_processing/audio_processing_impl.cc b/third_party/libwebrtc/modules/audio_processing/audio_processing_impl.cc @@ -820,7 +820,7 @@ void AudioProcessingImpl::HandleCaptureOutputUsedSetting( capture_.capture_output_used = capture_output_used || !constants_.minimize_processing_for_unused_output; - if (submodules_.agc_manager.get()) { + if (submodules_.agc_manager) { submodules_.agc_manager->HandleCaptureOutputUsedChange( capture_.capture_output_used); } @@ -2044,9 +2044,8 @@ void AudioProcessingImpl::InitializeGainController1() { return; } - if (!submodules_.agc_manager.get() || - submodules_.agc_manager->num_channels() != - static_cast<int>(num_proc_channels())) { + if (!submodules_.agc_manager || submodules_.agc_manager->num_channels() != + static_cast<int>(num_proc_channels())) { int stream_analog_level = -1; const bool re_creation = !!submodules_.agc_manager; if (re_creation) { diff --git a/third_party/libwebrtc/modules/audio_processing/test/debug_dump_replayer.cc b/third_party/libwebrtc/modules/audio_processing/test/debug_dump_replayer.cc @@ -34,7 +34,7 @@ namespace { void MaybeResetBuffer(std::unique_ptr<ChannelBuffer<float>>* buffer, const StreamConfig& config) { auto& buffer_ref = *buffer; - if (!buffer_ref.get() || buffer_ref->num_frames() != config.num_frames() || + if (!buffer_ref || buffer_ref->num_frames() != config.num_frames() || buffer_ref->num_channels() != config.num_channels()) { buffer_ref.reset( new ChannelBuffer<float>(config.num_frames(), config.num_channels())); diff --git a/third_party/libwebrtc/modules/audio_processing/test/debug_dump_test.cc b/third_party/libwebrtc/modules/audio_processing/test/debug_dump_test.cc @@ -43,7 +43,7 @@ namespace { void MaybeResetBuffer(std::unique_ptr<ChannelBuffer<float>>* buffer, const StreamConfig& config) { auto& buffer_ref = *buffer; - if (!buffer_ref.get() || buffer_ref->num_frames() != config.num_frames() || + if (!buffer_ref || buffer_ref->num_frames() != config.num_frames() || buffer_ref->num_channels() != config.num_channels()) { buffer_ref.reset( new ChannelBuffer<float>(config.num_frames(), config.num_channels())); diff --git a/third_party/libwebrtc/modules/desktop_capture/cropping_window_capturer.cc b/third_party/libwebrtc/modules/desktop_capture/cropping_window_capturer.cc @@ -47,7 +47,7 @@ void CroppingWindowCapturer::SetSharedMemoryFactory( void CroppingWindowCapturer::CaptureFrame() { if (ShouldUseScreenCapturer()) { - if (!screen_capturer_.get()) { + if (!screen_capturer_) { screen_capturer_ = DesktopCapturer::CreateRawScreenCapturer(options_); if (excluded_window_) { screen_capturer_->SetExcludedWindow(excluded_window_); @@ -62,7 +62,7 @@ void CroppingWindowCapturer::CaptureFrame() { void CroppingWindowCapturer::SetExcludedWindow(WindowId window) { excluded_window_ = window; - if (screen_capturer_.get()) { + if (screen_capturer_) { screen_capturer_->SetExcludedWindow(window); } } diff --git a/third_party/libwebrtc/modules/desktop_capture/linux/x11/mouse_cursor_monitor_x11.cc b/third_party/libwebrtc/modules/desktop_capture/linux/x11/mouse_cursor_monitor_x11.cc @@ -135,7 +135,7 @@ void MouseCursorMonitorX11::Capture() { x_display_->ProcessPendingXEvents(); // cursor_shape_| is set only if we were notified of a cursor shape change. - if (cursor_shape_.get()) + if (cursor_shape_) callback_->OnMouseCursor(cursor_shape_.release()); // Get cursor position if necessary. diff --git a/third_party/libwebrtc/modules/desktop_capture/linux/x11/screen_capturer_x11.cc b/third_party/libwebrtc/modules/desktop_capture/linux/x11/screen_capturer_x11.cc @@ -512,7 +512,7 @@ std::unique_ptr<DesktopCapturer> ScreenCapturerX11::CreateRawScreenCapturer( return nullptr; std::unique_ptr<ScreenCapturerX11> capturer(new ScreenCapturerX11()); - if (!capturer.get()->Init(options)) { + if (!capturer->Init(options)) { return nullptr; } diff --git a/third_party/libwebrtc/modules/desktop_capture/screen_drawer_linux.cc b/third_party/libwebrtc/modules/desktop_capture/screen_drawer_linux.cc @@ -176,7 +176,7 @@ std::unique_ptr<ScreenDrawerLock> ScreenDrawerLock::Create() { // static std::unique_ptr<ScreenDrawer> ScreenDrawer::Create() { - if (SharedXDisplay::CreateDefault().get()) { + if (SharedXDisplay::CreateDefault()) { return std::make_unique<ScreenDrawerLinux>(); } return nullptr; diff --git a/third_party/libwebrtc/modules/desktop_capture/window_capturer_unittest.cc b/third_party/libwebrtc/modules/desktop_capture/window_capturer_unittest.cc @@ -86,7 +86,7 @@ TEST_F(WindowCapturerTest, MAYBE_Capture) { } // If we failed to capture a window make sure it no longer exists. - if (!frame_.get()) { + if (!frame_) { DesktopCapturer::SourceList new_list; EXPECT_TRUE(capturer_->GetSourceList(&new_list)); for (auto new_list_it = new_list.begin(); new_list_it != new_list.end(); diff --git a/third_party/libwebrtc/modules/video_capture/video_capture_impl.cc b/third_party/libwebrtc/modules/video_capture/video_capture_impl.cc @@ -243,10 +243,9 @@ int32_t VideoCaptureImpl::IncomingFrame(uint8_t* videoFrame, } const int conversionResult = libyuv::ConvertToI420( - videoFrame, videoFrameLength, buffer.get()->MutableDataY(), - buffer.get()->StrideY(), buffer.get()->MutableDataU(), - buffer.get()->StrideU(), buffer.get()->MutableDataV(), - buffer.get()->StrideV(), 0, 0, // No Cropping + videoFrame, videoFrameLength, buffer->MutableDataY(), buffer->StrideY(), + buffer->MutableDataU(), buffer->StrideU(), buffer->MutableDataV(), + buffer->StrideV(), 0, 0, // No Cropping width, height, dst_width, dst_height, rotation_mode, ConvertVideoType(frameInfo.videoType)); if (conversionResult != 0) { diff --git a/third_party/libwebrtc/modules/video_coding/codecs/av1/dav1d_decoder.cc b/third_party/libwebrtc/modules/video_coding/codecs/av1/dav1d_decoder.cc @@ -210,7 +210,7 @@ int32_t Dav1dDecoder::Decode(const EncodedImage& encoded_image, return WEBRTC_VIDEO_CODEC_ERROR; } - if (!wrapped_buffer.get()) { + if (!wrapped_buffer) { return WEBRTC_VIDEO_CODEC_ERROR; } diff --git a/third_party/libwebrtc/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc b/third_party/libwebrtc/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc @@ -285,7 +285,7 @@ int LibvpxVp8Decoder::ReturnFrame(const vpx_image_t* img, scoped_refptr<I420Buffer> i420_buffer = buffer_pool_.CreateI420Buffer(img->d_w, img->d_h); buffer = i420_buffer; - if (i420_buffer.get()) { + if (i420_buffer) { libyuv::I420Copy(img->planes[VPX_PLANE_Y], img->stride[VPX_PLANE_Y], img->planes[VPX_PLANE_U], img->stride[VPX_PLANE_U], img->planes[VPX_PLANE_V], img->stride[VPX_PLANE_V], @@ -295,7 +295,7 @@ int LibvpxVp8Decoder::ReturnFrame(const vpx_image_t* img, img->d_w, img->d_h); } - if (!buffer.get()) { + if (!buffer) { // Pool has too many pending frames. RTC_HISTOGRAM_BOOLEAN("WebRTC.Video.LibvpxVp8Decoder.TooManyPendingFrames", 1); diff --git a/third_party/libwebrtc/modules/video_coding/nack_requester_unittest.cc b/third_party/libwebrtc/modules/video_coding/nack_requester_unittest.cc @@ -90,7 +90,7 @@ class TestNackRequester : public ::testing::Test, TaskQueueBase::Current(), nack_periodic_processor_.get(), clock_.get(), this, this, CreateTestFieldTrials()); nack_module_->UpdateRtt(kDefaultRttMs); - return *nack_module_.get(); + return *nack_module_; } static constexpr int64_t kDefaultRttMs = 20; diff --git a/third_party/libwebrtc/moz-patch-stack/s0001.patch b/third_party/libwebrtc/moz-patch-stack/s0001.patch @@ -492,7 +492,7 @@ index a80d9aa1ff..0e77405fa4 100644 } diff --git a/modules/desktop_capture/linux/x11/mouse_cursor_monitor_x11.cc b/modules/desktop_capture/linux/x11/mouse_cursor_monitor_x11.cc -index 59047dc03f..3a0cef3b3e 100644 +index 531130a876..fcaaee9eb7 100644 --- a/modules/desktop_capture/linux/x11/mouse_cursor_monitor_x11.cc +++ b/modules/desktop_capture/linux/x11/mouse_cursor_monitor_x11.cc @@ -39,6 +39,7 @@ namespace { @@ -521,7 +521,7 @@ index 59047dc03f..3a0cef3b3e 100644 x_display_->AddEventHandler(xfixes_event_base_ + XFixesCursorNotify, this); diff --git a/modules/desktop_capture/linux/x11/screen_capturer_x11.cc b/modules/desktop_capture/linux/x11/screen_capturer_x11.cc -index 4f32a27426..d05ec87963 100644 +index ce7312424b..d1898a2ea7 100644 --- a/modules/desktop_capture/linux/x11/screen_capturer_x11.cc +++ b/modules/desktop_capture/linux/x11/screen_capturer_x11.cc @@ -307,7 +307,7 @@ bool ScreenCapturerX11::GetSourceList(SourceList* sources) { @@ -1170,7 +1170,7 @@ index d7fa0fa26e..bb45a88f0e 100644 VideoCaptureModule::DeviceInfo* VideoCaptureFactory::CreateDeviceInfo( diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc -index 6e205a215f..98bf0c78cf 100644 +index c5d3f989ab..74c1768e8f 100644 --- a/modules/video_capture/video_capture_impl.cc +++ b/modules/video_capture/video_capture_impl.cc @@ -88,7 +88,6 @@ VideoCaptureImpl::VideoCaptureImpl() @@ -1237,7 +1237,7 @@ index 6e205a215f..98bf0c78cf 100644 } return 0; -@@ -240,6 +251,13 @@ int32_t VideoCaptureImpl::IncomingFrame(uint8_t* videoFrame, +@@ -239,6 +250,13 @@ int32_t VideoCaptureImpl::IncomingFrame(uint8_t* videoFrame, .build(); captureFrame.set_ntp_time_ms(captureTime); diff --git a/third_party/libwebrtc/moz-patch-stack/s0007.patch b/third_party/libwebrtc/moz-patch-stack/s0007.patch @@ -9,7 +9,7 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/92a7c3eee9f0c80ff 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/modules/audio_coding/codecs/opus/audio_encoder_opus.cc -index 85995137ef..b3e99bea05 100644 +index 73a6ea5b64..3b52e4f3f3 100644 --- a/modules/audio_coding/codecs/opus/audio_encoder_opus.cc +++ b/modules/audio_coding/codecs/opus/audio_encoder_opus.cc @@ -245,7 +245,7 @@ AudioCodecInfo AudioEncoderOpusImpl::QueryAudioEncoder( diff --git a/third_party/libwebrtc/moz-patch-stack/s0008.patch b/third_party/libwebrtc/moz-patch-stack/s0008.patch @@ -14,10 +14,10 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/c56cb66f86518dfb0 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc -index 98bf0c78cf..f5d605f6ee 100644 +index 74c1768e8f..4d685c285c 100644 --- a/modules/video_capture/video_capture_impl.cc +++ b/modules/video_capture/video_capture_impl.cc -@@ -229,12 +229,21 @@ int32_t VideoCaptureImpl::IncomingFrame(uint8_t* videoFrame, +@@ -229,11 +229,20 @@ int32_t VideoCaptureImpl::IncomingFrame(uint8_t* videoFrame, } } @@ -31,10 +31,9 @@ index 98bf0c78cf..f5d605f6ee 100644 + } + const int conversionResult = libyuv::ConvertToI420( - videoFrame, videoFrameLength, buffer.get()->MutableDataY(), - buffer.get()->StrideY(), buffer.get()->MutableDataU(), - buffer.get()->StrideU(), buffer.get()->MutableDataV(), - buffer.get()->StrideV(), 0, 0, // No Cropping + videoFrame, videoFrameLength, buffer->MutableDataY(), buffer->StrideY(), + buffer->MutableDataU(), buffer->StrideU(), buffer->MutableDataV(), + buffer->StrideV(), 0, 0, // No Cropping - width, height, target_width, target_height, rotation_mode, + width, height, dst_width, dst_height, rotation_mode, ConvertVideoType(frameInfo.videoType)); diff --git a/third_party/libwebrtc/moz-patch-stack/s0012.patch b/third_party/libwebrtc/moz-patch-stack/s0012.patch @@ -10,7 +10,7 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/51d12094d825c4c44 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc -index f5d605f6ee..de7fabef55 100644 +index 4d685c285c..4e150ed468 100644 --- a/modules/video_capture/video_capture_impl.cc +++ b/modules/video_capture/video_capture_impl.cc @@ -191,8 +191,6 @@ int32_t VideoCaptureImpl::IncomingFrame(uint8_t* videoFrame, diff --git a/third_party/libwebrtc/moz-patch-stack/s0018.patch b/third_party/libwebrtc/moz-patch-stack/s0018.patch @@ -10,7 +10,7 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/1387b2c480b55ecca 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc b/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc -index 453a2c27b6..17359070cc 100644 +index 13e7b3229b..85b85e06a2 100644 --- a/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc +++ b/modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc @@ -51,7 +51,7 @@ const char kVp8PostProcArmFieldTrial[] = "WebRTC-VP8-Postproc-Config-Arm"; diff --git a/third_party/libwebrtc/moz-patch-stack/s0077.patch b/third_party/libwebrtc/moz-patch-stack/s0077.patch @@ -17,7 +17,7 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/56ff441b644400f09 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc -index de7fabef55..56efa18968 100644 +index 4e150ed468..2f009820d3 100644 --- a/modules/video_capture/video_capture_impl.cc +++ b/modules/video_capture/video_capture_impl.cc @@ -130,11 +130,14 @@ void VideoCaptureImpl::DeRegisterCaptureDataCallback( diff --git a/third_party/libwebrtc/moz-patch-stack/s0078.patch b/third_party/libwebrtc/moz-patch-stack/s0078.patch @@ -13,7 +13,7 @@ Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/26c84d214137a1b0d 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc -index 56efa18968..d47e25f271 100644 +index 2f009820d3..62a4b21a5f 100644 --- a/modules/video_capture/video_capture_impl.cc +++ b/modules/video_capture/video_capture_impl.cc @@ -145,7 +145,7 @@ int32_t VideoCaptureImpl::DeliverCapturedFrame(VideoFrame& captureFrame) { diff --git a/third_party/libwebrtc/moz-patch-stack/s0119.patch b/third_party/libwebrtc/moz-patch-stack/s0119.patch @@ -42,7 +42,7 @@ index a7c1764c51..8a91ca2f83 100644 // Start capture device virtual int32_t StartCapture(const VideoCaptureCapability& capability) = 0; diff --git a/modules/video_capture/video_capture_impl.cc b/modules/video_capture/video_capture_impl.cc -index d47e25f271..0193bed0ba 100644 +index 62a4b21a5f..98d7081b1d 100644 --- a/modules/video_capture/video_capture_impl.cc +++ b/modules/video_capture/video_capture_impl.cc @@ -120,7 +120,7 @@ void VideoCaptureImpl::RegisterCaptureDataCallback( diff --git a/third_party/libwebrtc/p2p/base/transport_description_factory.cc b/third_party/libwebrtc/p2p/base/transport_description_factory.cc @@ -93,10 +93,10 @@ std::unique_ptr<TransportDescription> TransportDescriptionFactory::CreateAnswer( // Special affordance for testing: Answer without DTLS params // if we are insecure without a certificate, or if we are // insecure with a non-DTLS offer. - if ((!certificate_ || !offer->identity_fingerprint.get()) && insecure()) { + if ((!certificate_ || !offer->identity_fingerprint) && insecure()) { return desc; } - if (!offer->identity_fingerprint.get()) { + if (!offer->identity_fingerprint) { if (require_transport_attributes) { // We require DTLS, but the other side didn't offer it. Fail. RTC_LOG(LS_WARNING) << "Failed to create TransportDescription answer " diff --git a/third_party/libwebrtc/pc/legacy_stats_collector.cc b/third_party/libwebrtc/pc/legacy_stats_collector.cc @@ -1393,7 +1393,7 @@ void LegacyStatsCollector::UpdateReportFromAudioTrack( auto audio_processor(track->GetAudioProcessor()); - if (audio_processor.get()) { + if (audio_processor) { AudioProcessorInterface::AudioProcessorStatistics stats = audio_processor->GetStats(has_remote_tracks); diff --git a/third_party/libwebrtc/pc/rtc_stats_collector.cc b/third_party/libwebrtc/pc/rtc_stats_collector.cc @@ -1429,11 +1429,11 @@ void RTCStatsCollector::ProduceCertificateStats_n( for (const auto& transport_cert_stats_pair : transport_cert_stats) { if (transport_cert_stats_pair.second.local) { ProduceCertificateStatsFromSSLCertificateStats( - timestamp, *transport_cert_stats_pair.second.local.get(), report); + timestamp, *transport_cert_stats_pair.second.local, report); } if (transport_cert_stats_pair.second.remote) { ProduceCertificateStatsFromSSLCertificateStats( - timestamp, *transport_cert_stats_pair.second.remote.get(), report); + timestamp, *transport_cert_stats_pair.second.remote, report); } } } @@ -1622,7 +1622,7 @@ void RTCStatsCollector::ProduceMediaSourceStats_s( // Audio processor may be attached to either the track or the send // stream, so look in both places. auto audio_processor(audio_track->GetAudioProcessor()); - if (audio_processor.get()) { + if (audio_processor) { // The `has_remote_tracks` argument is obsolete; makes no difference // if it's set to true or false. AudioProcessorInterface::AudioProcessorStatistics ap_stats = diff --git a/third_party/libwebrtc/pc/sctp_data_channel.cc b/third_party/libwebrtc/pc/sctp_data_channel.cc @@ -730,7 +730,7 @@ void SctpDataChannel::OnDataReceived(DataMessageType type, if (state_ == kOpen && observer_) { ++messages_received_; bytes_received_ += buffer->size(); - observer_->OnMessage(*buffer.get()); + observer_->OnMessage(*buffer); } else { if (queued_received_data_.byte_count() + payload.size() > kMaxQueuedReceivedDataBytes) { diff --git a/third_party/libwebrtc/pc/sdp_offer_answer.cc b/third_party/libwebrtc/pc/sdp_offer_answer.cc @@ -1039,7 +1039,7 @@ class SdpOfferAnswerHandler::RemoteDescriptionOperation { void ReportOfferAnswerUma() { RTC_DCHECK(ok()); if (type_ == SdpType::kOffer || type_ == SdpType::kAnswer) { - handler_->pc_->ReportSdpBundleUsage(*desc_.get()); + handler_->pc_->ReportSdpBundleUsage(*desc_); } } diff --git a/third_party/libwebrtc/pc/webrtc_sdp.cc b/third_party/libwebrtc/pc/webrtc_sdp.cc @@ -1768,7 +1768,7 @@ bool ParseSessionDescription(absl::string_view message, return false; } } else if (HasAttribute(*aline, kAttributeFingerprint)) { - if (session_td->identity_fingerprint.get()) { + if (session_td->identity_fingerprint) { return ParseFailed( *aline, "Can't have multiple fingerprint attributes at the same level.", @@ -3126,7 +3126,7 @@ bool ParseMediaDescription( unsupported_desc->set_protocol(protocol); content = std::move(unsupported_desc); } - if (!content.get()) { + if (!content) { // ParseContentDescription returns NULL if failed. return false; } diff --git a/third_party/libwebrtc/rtc_base/boringssl_identity.cc b/third_party/libwebrtc/rtc_base/boringssl_identity.cc @@ -175,7 +175,7 @@ const BoringSSLCertificate& BoringSSLIdentity::certificate() const { } const SSLCertChain& BoringSSLIdentity::cert_chain() const { - return *cert_chain_.get(); + return *cert_chain_; } std::unique_ptr<SSLIdentity> BoringSSLIdentity::CloneInternal() const { diff --git a/third_party/libwebrtc/rtc_base/fake_ssl_identity.cc b/third_party/libwebrtc/rtc_base/fake_ssl_identity.cc @@ -106,7 +106,7 @@ const SSLCertificate& FakeSSLIdentity::certificate() const { } const SSLCertChain& FakeSSLIdentity::cert_chain() const { - return *cert_chain_.get(); + return *cert_chain_; } std::string FakeSSLIdentity::PrivateKeyToPEMString() const { diff --git a/third_party/libwebrtc/rtc_base/memory/aligned_malloc_unittest.cc b/third_party/libwebrtc/rtc_base/memory/aligned_malloc_unittest.cc @@ -27,7 +27,7 @@ namespace webrtc { bool CorrectUsage(size_t size, size_t alignment) { std::unique_ptr<char, AlignedFreeDeleter> scoped( static_cast<char*>(AlignedMalloc(size, alignment))); - if (scoped.get() == nullptr) { + if (scoped == nullptr) { return false; } const uintptr_t scoped_address = reinterpret_cast<uintptr_t>(scoped.get()); diff --git a/third_party/libwebrtc/rtc_base/strong_alias_unittest.cc b/third_party/libwebrtc/rtc_base/strong_alias_unittest.cc @@ -312,8 +312,8 @@ TYPED_TEST(StrongAliasTest, CanDifferentiateOverloads) { using BarAlias = StrongAlias<class BarTag, TypeParam>; class Scope { public: - static std::string Overload(FooAlias) { return "FooAlias"; } - static std::string Overload(BarAlias) { return "BarAlias"; } + static std::string Overload(FooAlias /*unused*/) { return "FooAlias"; } + static std::string Overload(BarAlias /*unused*/) { return "BarAlias"; } }; EXPECT_EQ("FooAlias", Scope::Overload(FooAlias())); EXPECT_EQ("BarAlias", Scope::Overload(BarAlias())); diff --git a/third_party/libwebrtc/rtc_base/weak_ptr.cc b/third_party/libwebrtc/rtc_base/weak_ptr.cc @@ -57,7 +57,7 @@ WeakReference WeakReferenceOwner::GetRef() const { } void WeakReferenceOwner::Invalidate() { - if (flag_.get()) { + if (flag_) { flag_->Invalidate(); flag_ = nullptr; } diff --git a/third_party/libwebrtc/stats/rtc_stats_report.cc b/third_party/libwebrtc/stats/rtc_stats_report.cc @@ -41,7 +41,7 @@ RTCStatsReport::ConstIterator& RTCStatsReport::ConstIterator::operator++(int) { } const RTCStats& RTCStatsReport::ConstIterator::operator*() const { - return *it_->second.get(); + return *it_->second; } const RTCStats* RTCStatsReport::ConstIterator::operator->() const { diff --git a/third_party/libwebrtc/test/call_test.cc b/third_party/libwebrtc/test/call_test.cc @@ -586,7 +586,7 @@ void CallTest::CreateVideoSendStreams() { // We currently only support testing external fec controllers with a single // VideoSendStream. - if (fec_controller_factory_.get()) { + if (fec_controller_factory_) { RTC_DCHECK_LE(video_send_configs_.size(), 1); } @@ -606,7 +606,7 @@ void CallTest::CreateVideoSendStreams() { video_send_streams_.resize(video_send_configs_.size(), nullptr); for (size_t i : streams_creation_order) { - if (fec_controller_factory_.get()) { + if (fec_controller_factory_) { video_send_streams_[i] = sender_call_->CreateVideoSendStream( video_send_configs_[i].Copy(), video_encoder_configs_[i].Copy(), fec_controller_factory_->CreateFecController(send_env_)); diff --git a/third_party/libwebrtc/test/peer_scenario/scenario_connection.cc b/third_party/libwebrtc/test/peer_scenario/scenario_connection.cc @@ -135,7 +135,7 @@ ScenarioIceConnectionImpl::ScenarioIceConnectionImpl( CreateRandomString(ICE_PWD_LENGTH), IceMode::ICEMODE_FULL, ConnectionRole::CONNECTIONROLE_PASSIVE, - SSLFingerprint::CreateFromCertificate(*certificate_.get()).get()), + SSLFingerprint::CreateFromCertificate(*certificate_).get()), network_manager_(manager_->ReleaseNetworkManager()), packet_socket_factory_(manager_->socket_factory()), port_allocator_( diff --git a/third_party/libwebrtc/test/testsupport/yuv_frame_reader.cc b/third_party/libwebrtc/test/testsupport/yuv_frame_reader.cc @@ -54,7 +54,7 @@ scoped_refptr<I420Buffer> Scale(scoped_refptr<I420Buffer> buffer, } scoped_refptr<I420Buffer> scaled( I420Buffer::Create(resolution.width, resolution.height)); - scaled->ScaleFrom(*buffer.get()); + scaled->ScaleFrom(*buffer); return scaled; } } // namespace