commit 93f72e0a9eb52e48c50b3d24bdf5b8944c746dfa
parent 9a0a07c044a11f29cbb26b06d5b2be5836fc7353
Author: Nina Pypchenko <npypchenko@mozilla.com>
Date: Fri, 7 Nov 2025 06:03:32 +0000
Bug 1998833 - Make "Support Firefox" section the default and only option in New Tab settings r=home-newtab-reviewers,reemhamz
- Removed conditional code around the "Support Firefox" settings.
- Removed an obsolete setting: `browser.newtabpage.activity-stream.system.showSponsoredCheckboxes`.
Differential Revision: https://phabricator.services.mozilla.com/D271723
Diffstat:
3 files changed, 0 insertions(+), 60 deletions(-)
diff --git a/browser/extensions/newtab/lib/AboutPreferences.sys.mjs b/browser/extensions/newtab/lib/AboutPreferences.sys.mjs
@@ -66,18 +66,6 @@ const PREFS_FOR_SETTINGS = () => [
feed: "feeds.topsites",
titleString: "home-prefs-shortcuts-header",
descString: "home-prefs-shortcuts-description",
- nestedPrefs: [
- {
- name: "showSponsoredTopSites",
- titleString: "home-prefs-shortcuts-by-option-sponsored",
- eventSource: "SPONSORED_TOP_SITES",
- // Hide this nested pref if "Support Firefox" checkbox is enabled
- shouldHidePref: Services.prefs.getBoolPref(
- "browser.newtabpage.activity-stream.system.showSponsoredCheckboxes",
- false
- ),
- },
- ],
},
maxRows: 4,
rowsPref: "topSitesRows",
@@ -93,26 +81,6 @@ const PREFS_FOR_SETTINGS = () => [
descString: {
id: "home-prefs-recommended-by-description-generic",
},
- nestedPrefs: [
- ...(Services.prefs.getBoolPref(
- "browser.newtabpage.activity-stream.system.showSponsored",
- true
- ) && // Hide this nested pref if "Support Firefox" checkbox is enabled
- !Services.prefs.getBoolPref(
- "browser.newtabpage.activity-stream.system.showSponsoredCheckboxes",
- false
- )
- ? [
- {
- name: "showSponsored",
- titleString:
- "home-prefs-recommended-by-option-sponsored-stories",
- icon: "icon-info",
- eventSource: "POCKET_SPOCS",
- },
- ]
- : []),
- ],
},
shouldHidePref: !Services.prefs.getBoolPref(
"browser.newtabpage.activity-stream.feeds.system.topstories",
@@ -146,10 +114,6 @@ const PREFS_FOR_SETTINGS = () => [
},
],
},
- shouldHidePref: !Services.prefs.getBoolPref(
- "browser.newtabpage.activity-stream.system.showSponsoredCheckboxes",
- false
- ),
},
];
diff --git a/browser/extensions/newtab/lib/ActivityStream.sys.mjs b/browser/extensions/newtab/lib/ActivityStream.sys.mjs
@@ -1341,15 +1341,6 @@ export const PREFS_CONFIG = new Map([
},
},
],
- // Sponsored checkboxes placement experiment
- [
- "system.showSponsoredCheckboxes",
- {
- title:
- "Switches on grouping of sponsored checkboxes on 'about:settings#home' page",
- value: true,
- },
- ],
[
"showSponsoredCheckboxes",
{
diff --git a/toolkit/components/nimbus/FeatureManifest.yaml b/toolkit/components/nimbus/FeatureManifest.yaml
@@ -1143,21 +1143,6 @@ newtabCustomWallpaper:
description: >-
Maximum file size (in MB) a user can upload
-newtabGroupedSponsoredControls:
- description: >-
- Adjust sponsored content controls on newtab.
- owner: mcrawford@mozilla.com
- hasExposure: false
- variables:
- enabled:
- type: boolean
- setPref:
- branch: user
- pref: browser.newtabpage.activity-stream.system.showSponsoredCheckboxes
- description: >-
- When true, checkboxes for sponsored results in top sites and recommended stories are grouped separately
- on about:preferences#home
-
newtabInlineTopicSelection:
description: >-
Adds Inline topic selection to sections layout
