tor-browser

commit 93dfc5ab873d5a4b28cdd9dbfc7ca239426d2477
parent e1fd97aa19fc94ebe1ac8a6aa7e5119651fad502
Author: Eitan Isaacson <eitan@monotonous.org>
Date:   Wed, 15 Oct 2025 17:15:11 +0000

Bug 1994029 - P3: Remove eActionable accessible type. r=Jamie

Now that we always have the action interface in ATK we don't need this
flag/hack.

Differential Revision: https://phabricator.services.mozilla.com/D268600

Diffstat:
M
accessible/base/AccTypes.h
 | 
5
++---
M
accessible/basetypes/Accessible.h
 | 
2
--
M
accessible/ipc/DocAccessibleChild.cpp
 | 
12
------------

3 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/accessible/base/AccTypes.h b/accessible/base/AccTypes.h
@@ -86,10 +86,9 @@ enum AccGenericType {
   eTableRow = 1 << 13,
   eText = 1 << 14,
   eNumericValue = 1 << 15,
-  eActionable = 1 << 16,  // This is for remote accessibles
-  eDPub = 1 << 17,
+  eDPub = 1 << 16,
 
-  eLastAccGenericType = eActionable,
+  eLastAccGenericType = eDPub,
   eAllGenericTypes = (eLastAccGenericType << 1) - 1
 };
 
diff --git a/accessible/basetypes/Accessible.h b/accessible/basetypes/Accessible.h
@@ -603,8 +603,6 @@ class Accessible {
 
   bool IsSelect() const { return HasGenericType(eSelect); }
 
-  bool IsActionable() const { return HasGenericType(eActionable); }
-
   bool IsText() const { return mGenericTypes & eText; }
 
   bool IsImage() const { return mType == eImageType; }
diff --git a/accessible/ipc/DocAccessibleChild.cpp b/accessible/ipc/DocAccessibleChild.cpp
@@ -51,18 +51,6 @@ AccessibleData DocAccessibleChild::SerializeAcc(LocalAccessible* aAcc) {
     // XXX: We need to do this because this requires a state check.
     genericTypes |= eNumericValue;
   }
-  if (aAcc->IsTextLeaf() || aAcc->IsImage()) {
-    // Ideally, we'd set eActionable for any Accessible with an ancedstor
-    // action. However, that requires an ancestor walk which is too expensive
-    // here. eActionable is only used by ATK. For now, we only expose ancestor
-    // actions on text leaf and image Accessibles. This means that we don't
-    // support "clickAncestor" for ATK.
-    if (aAcc->ActionCount()) {
-      genericTypes |= eActionable;
-    }
-  } else if (aAcc->HasPrimaryAction()) {
-    genericTypes |= eActionable;
-  }
 
   RefPtr<AccAttributes> fields;
   // Even though we send moves as a hide and a show, we don't want to