tor-browser

commit 92a32420b83fe2580f2b9d9a3445b465e4761703
parent ca27a77bc71c4a5d6be04e30eff90291349eee36
Author: Daniel Holbert <dholbert@cs.stanford.edu>
Date:   Mon, 17 Nov 2025 18:09:24 +0000

Bug 1997459: Remove 'overflow:hidden' styling on new-tab weather card, since it causes its own menu to be clipped in some cases. r=home-newtab-reviewers,dholbert,ini

Note that we've already been suppressing 'overflow:hidden' on this element
whenever the clicks the button to open the menu.  So if there were an issue
with this element having overflow, then it would have already been showing up
whenever the menu opens.  So I'm hoping that means there are no issues with
removing this style. :)

Differential Revision: https://phabricator.services.mozilla.com/D270895

Diffstat:
M
browser/extensions/newtab/content-src/components/Weather/_Weather.scss
 | 
5
-----
M
browser/extensions/newtab/css/activity-stream.css
 | 
4
----

2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/browser/extensions/newtab/content-src/components/Weather/_Weather.scss b/browser/extensions/newtab/content-src/components/Weather/_Weather.scss
@@ -234,7 +234,6 @@
   flex-wrap: nowrap;
   align-items: stretch;
   border-radius: var(--border-radius-medium);
-  overflow: hidden;
 
   &:hover, &:focus-within {
     ~ .weatherSponsorText {
@@ -252,10 +251,6 @@
     }
   }
 
-  &:focus-within {
-    overflow: visible;
-  }
-
   &:hover {
     box-shadow: var(--box-shadow-card);
   }
diff --git a/browser/extensions/newtab/css/activity-stream.css b/browser/extensions/newtab/css/activity-stream.css
@@ -2935,7 +2935,6 @@ main section {
   flex-wrap: nowrap;
   align-items: stretch;
   border-radius: var(--border-radius-medium);
-  overflow: hidden;
 }
 .weatherCard:hover ~ .weatherSponsorText, .weatherCard:focus-within ~ .weatherSponsorText {
   visibility: visible;
@@ -2946,9 +2945,6 @@ main section {
 .weatherCard:has(.staticWeatherInfo):hover ~ .weatherSponsorText {
   visibility: hidden;
 }
-.weatherCard:focus-within {
-  overflow: visible;
-}
 .weatherCard:hover {
   box-shadow: var(--box-shadow-card);
 }