commit 8fd4217f41c3d6606415c38c29fb4f11dc22793e
parent b2118f56bd9a9cc9c7c10921561df24bb48afe12
Author: Michael Froman <mfroman@mozilla.com>
Date: Wed, 8 Oct 2025 21:53:13 -0500
Bug 1993083 - Vendor libwebrtc from 45835727fd
Upstream commit: https://webrtc.googlesource.com/src/+/45835727fd4c471b8fe606ca3eed21ecdfd4bfd0
Warn against calling WebRTC functions from callbacks
No-Try: documentation change only
Bug: webrtc:429335703
Change-Id: I8174e3d9842ed605cf5deee2ddc78ea0fe92097a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/399042
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45085}
Diffstat:
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/third_party/libwebrtc/README.mozilla.last-vendor b/third_party/libwebrtc/README.mozilla.last-vendor
@@ -1,4 +1,4 @@
# ./mach python dom/media/webrtc/third_party_build/vendor-libwebrtc.py --from-local /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc --commit mozpatches libwebrtc
-libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T02:46:05.159240+00:00.
+libwebrtc updated from /home/mfroman/mozilla/elm/.moz-fast-forward/moz-libwebrtc commit mozpatches on 2025-10-09T02:53:03.892288+00:00.
# base of lastest vendoring
-5682d46450
+45835727fd
diff --git a/third_party/libwebrtc/api/g3doc/threading_design.md b/third_party/libwebrtc/api/g3doc/threading_design.md
@@ -47,6 +47,13 @@ void ObserverClass::Handler(event) {
// Process event, we're now on the right thread
}
```
+It is generally NOT safe to call WebRTC library functions from the callback;
+if this is wanted, one should instead dispatch a task on an appropriate
+thread to do so.
+
+In the future, the implementation may evolve to crash or return an error
+if this happens.
+
In the future, the implementation may change to always call the callbacks
and event handlers on the client thread.
