tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

commit 8ed604513a35d8668e5513ea59af05f5ae234250
parent aca2ac519fa26f126c50bb4c64ca86c53d289cad
Author: Andrey Zinovyev <azinovyev@mozilla.com>
Date:   Wed, 31 Dec 2025 16:28:04 +0000

Bug 2003584 - Remove (activity as HomeActivity) casts in AddonDetailsFragment and AddonPermissionsDetailsFragment r=android-reviewers,android-addons-reviewers,willdurand

Differential Revision: https://phabricator.services.mozilla.com/D274799

Diffstat:
Mmobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsFragment.kt | 9+++++----
Mmobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonPermissionsDetailsFragment.kt | 9+++++----
2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonDetailsFragment.kt @@ -9,6 +9,7 @@ import android.os.Bundle import android.view.View import androidx.fragment.app.Fragment import androidx.lifecycle.lifecycleScope +import androidx.navigation.fragment.findNavController import androidx.navigation.fragment.navArgs import kotlinx.coroutines.Dispatchers.IO import kotlinx.coroutines.Dispatchers.Main @@ -18,10 +19,10 @@ import mozilla.components.feature.addons.Addon import mozilla.components.feature.addons.ui.showInformationDialog import mozilla.components.feature.addons.ui.translateName import mozilla.components.feature.addons.update.DefaultAddonUpdater.UpdateAttemptStorage -import org.mozilla.fenix.BrowserDirection -import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.R import org.mozilla.fenix.databinding.FragmentAddOnDetailsBinding +import org.mozilla.fenix.ext.openToBrowser +import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.ext.showToolbar /** @@ -46,10 +47,10 @@ class AddonDetailsFragment : Fragment(R.layout.fragment_add_on_details), AddonDe } override fun openWebsite(url: Uri) { - (activity as HomeActivity).openToBrowserAndLoad( + findNavController().openToBrowser() + requireComponents.useCases.fenixBrowserUseCases.loadUrlOrSearch( searchTermOrURL = url.toString(), newTab = true, - from = BrowserDirection.FromAddonDetailsFragment, ) } diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonPermissionsDetailsFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonPermissionsDetailsFragment.kt @@ -11,14 +11,15 @@ import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.saveable.rememberSaveable import androidx.fragment.app.Fragment import androidx.fragment.compose.content +import androidx.navigation.fragment.findNavController import androidx.navigation.fragment.navArgs import mozilla.components.feature.addons.Addon import mozilla.components.feature.addons.Addon.Companion.isAllURLsPermission import mozilla.components.feature.addons.ui.translateName -import org.mozilla.fenix.BrowserDirection -import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.addons.ui.AddonPermissionsScreen import org.mozilla.fenix.ext.components +import org.mozilla.fenix.ext.openToBrowser +import org.mozilla.fenix.ext.requireComponents import org.mozilla.fenix.ext.showToolbar import org.mozilla.fenix.theme.FirefoxTheme @@ -161,10 +162,10 @@ class AddonPermissionsDetailsFragment : Fragment() { } private fun openWebsite(addonSiteUrl: String) { - (activity as HomeActivity).openToBrowserAndLoad( + findNavController().openToBrowser() + requireComponents.useCases.fenixBrowserUseCases.loadUrlOrSearch( searchTermOrURL = addonSiteUrl, newTab = true, - from = BrowserDirection.FromAddonPermissionsDetailsFragment, ) }