tor-browser

commit 8e4ea1b8db2fb6a878ddd6dc4a6c19ee408910a8
parent 2fe2049e805b5716442a8bafaa340d1261b6cffb
Author: Kagami Sascha Rosylight <krosylight@proton.me>
Date:   Thu,  4 Dec 2025 17:54:29 +0000

Bug 2004052 - Rename setDateTimePickerState to setOpenState r=smaug,webidl

Differential Revision: https://phabricator.services.mozilla.com/D275088

Diffstat:
M
dom/html/HTMLInputElement.cpp
 | 
10
+++++-----
M
dom/html/HTMLInputElement.h
 | 
7
++++++-
M
dom/webidl/HTMLInputElement.webidl
 | 
2
+-
M
toolkit/content/widgets/datetimebox.js
 | 
2
+-

4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/dom/html/HTMLInputElement.cpp b/dom/html/HTMLInputElement.cpp
@@ -826,7 +826,7 @@ nsresult HTMLInputElement::InitColorPicker() {
   rv = colorPicker->Open(callback);
   if (NS_SUCCEEDED(rv)) {
     mPickerRunning = true;
-    SetStates(ElementState::OPEN, true);
+    SetOpenState(true);
   }
 
   return rv;
@@ -943,7 +943,7 @@ nsresult HTMLInputElement::InitFilePicker(FilePickerType aType) {
     rv = filePicker->Open(callback);
     if (NS_SUCCEEDED(rv)) {
       mPickerRunning = true;
-      SetStates(ElementState::OPEN, true);
+      SetOpenState(true);
     }
 
     return rv;
@@ -952,7 +952,7 @@ nsresult HTMLInputElement::InitFilePicker(FilePickerType aType) {
   HTMLInputElement::gUploadLastDir->FetchDirectoryAndDisplayPicker(
       doc, filePicker, callback);
   mPickerRunning = true;
-  SetStates(ElementState::OPEN, true);
+  SetOpenState(true);
   return NS_OK;
 }
 
@@ -2334,7 +2334,7 @@ void HTMLInputElement::CloseDateTimePicker() {
                                       CanBubble::eYes, Cancelable::eYes);
 }
 
-void HTMLInputElement::SetDateTimePickerState(bool aIsOpen) {
+void HTMLInputElement::SetOpenState(bool aIsOpen) {
   SetStates(ElementState::OPEN, aIsOpen);
 }
 
@@ -7439,7 +7439,7 @@ void HTMLInputElement::UpdateHasRange(bool aNotify) {
 
 void HTMLInputElement::PickerClosed() {
   mPickerRunning = false;
-  SetStates(ElementState::OPEN, false);
+  SetOpenState(false);
 }
 
 JSObject* HTMLInputElement::WrapNode(JSContext* aCx,
diff --git a/dom/html/HTMLInputElement.h b/dom/html/HTMLInputElement.h
@@ -784,7 +784,12 @@ class HTMLInputElement final : public TextControlElement,
   void OpenDateTimePicker(const DateTimeValue& aInitialValue);
   void UpdateDateTimePicker(const DateTimeValue& aValue);
   void CloseDateTimePicker();
-  void SetDateTimePickerState(bool aIsOpen);
+
+  /**
+   * Sets open state for the input element, depending on whether the picker is
+   * open or closed.
+   */
+  void SetOpenState(bool aIsOpen);
 
   /*
    * Called from datetime input box binding when inner text fields are focused
diff --git a/dom/webidl/HTMLInputElement.webidl b/dom/webidl/HTMLInputElement.webidl
@@ -277,7 +277,7 @@ partial interface HTMLInputElement {
   undefined closeDateTimePicker();
 
   [Func="IsChromeOrUAWidget"]
-  undefined setDateTimePickerState(boolean aIsOpen);
+  undefined setOpenState(boolean aIsOpen);
 
   [Func="IsChromeOrUAWidget"]
   undefined setFocusState(boolean aIsFocused);
diff --git a/toolkit/content/widgets/datetimebox.js b/toolkit/content/widgets/datetimebox.js
@@ -434,7 +434,7 @@ this.DateTimeBoxWidget = class {
   setPickerState(aIsOpen) {
     this.log("picker is now " + (aIsOpen ? "opened" : "closed"));
     this.mIsPickerOpen = aIsOpen;
-    this.mInputElement.setDateTimePickerState(aIsOpen);
+    this.mInputElement.setOpenState(aIsOpen);
     // Calendar button's expanded state mirrors this.mIsPickerOpen
     this.updateCalendarButtonState(this.mIsPickerOpen);
   }