commit 88003c5563b582891e2f51def0dbcf16d58117f3 parent 4c20ef62beb1799e00844a6d3c3f04ba942d695e Author: iorgamgabriel <iorgamgabriel@yahoo.com> Date: Tue, 25 Nov 2025 07:29:14 +0000 Bug 1985588 - Rename the name of the WebCompat Reporter store action from `SendMoreInfoClicked` to `AddMoreInfoClicked` r=android-reviewers,apindiprolu Differential Revision: https://phabricator.services.mozilla.com/D273833 Diffstat:
9 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/mobile/android/fenix/app/metrics.yaml b/mobile/android/fenix/app/metrics.yaml @@ -14045,10 +14045,10 @@ webcompatreporting: description: > Whether the user opted into including blocked tracker origins. type: boolean - send_more_info: + add_more_info: type: event description: | - Recorded when a user clicks on the Send More Info link in the reporting UI + Recorded when a user clicks on the Add More Info link in the reporting UI The user will be redirected to webcompat.com to submit a more comprehensive report. bugs: - https://bugzilla.mozilla.org/show_bug.cgi?id=1932462 diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterStorageMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterStorageMiddleware.kt @@ -53,7 +53,7 @@ class WebCompatReporterStorageMiddleware( } } WebCompatReporterAction.BackPressed, - WebCompatReporterAction.SendMoreInfoClicked, + WebCompatReporterAction.AddMoreInfoClicked, WebCompatReporterAction.LearnMoreClicked, -> appStore.dispatch( WebCompatAction.WebCompatStateUpdated( diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterSubmissionMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterSubmissionMiddleware.kt @@ -67,7 +67,7 @@ class WebCompatReporterSubmissionMiddleware( handleOpenPreviewClicked(context) } } - is WebCompatReporterAction.SendMoreInfoClicked -> { + is WebCompatReporterAction.AddMoreInfoClicked -> { scope.launch { handleSendMoreInfoClicked(context) } diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterTelemetryMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterTelemetryMiddleware.kt @@ -31,8 +31,8 @@ class WebCompatReporterTelemetryMiddleware : Webcompatreporting.reasonDropdown.set(action.newReason.name) } - WebCompatReporterAction.SendMoreInfoClicked -> { - Webcompatreporting.sendMoreInfo.record(NoExtras()) + WebCompatReporterAction.AddMoreInfoClicked -> { + Webcompatreporting.addMoreInfo.record(NoExtras()) } WebCompatReporterAction.SendReportClicked -> { diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/store/WebCompatReporterStore.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/store/WebCompatReporterStore.kt @@ -169,9 +169,9 @@ sealed class WebCompatReporterAction : Action { data object SendMoreInfoSubmitted : WebCompatReporterAction(), NavigationAction /** - * Dispatched when the user requests to send more info. + * Dispatched when the user requests to add more info. */ - data object SendMoreInfoClicked : WebCompatReporterAction(), WebCompatReporterStorageAction + data object AddMoreInfoClicked : WebCompatReporterAction(), WebCompatReporterStorageAction /** * Dispatched when the user requests to cancel the report. @@ -206,7 +206,7 @@ private fun reduce( ) is WebCompatReporterAction.NavigationAction -> state WebCompatReporterAction.SendReportClicked -> state - WebCompatReporterAction.SendMoreInfoClicked -> state + WebCompatReporterAction.AddMoreInfoClicked -> state WebCompatReporterAction.LearnMoreClicked -> state is WebCompatReporterAction.IncludeEtpBlockedUrlsChanged -> state.copy(includeEtpBlockedUrls = action.include) } diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/ui/WebCompatReporter.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/ui/WebCompatReporter.kt @@ -287,7 +287,7 @@ fun WebCompatReporter( text = stringResource(id = R.string.webcompat_reporter_add_more_info), modifier = Modifier .clickable { - store.dispatch(WebCompatReporterAction.SendMoreInfoClicked) + store.dispatch(WebCompatReporterAction.AddMoreInfoClicked) }, style = FirefoxTheme.typography.body2, color = MaterialTheme.colorScheme.tertiary, diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterSubmissionMiddlewareTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterSubmissionMiddlewareTest.kt @@ -620,7 +620,7 @@ class WebCompatReporterSubmissionMiddlewareTest { ), ) - store.dispatch(WebCompatReporterAction.SendMoreInfoClicked) + store.dispatch(WebCompatReporterAction.AddMoreInfoClicked) assertTrue(moreWebCompatInfoSent) captureActionsMiddleware.assertFirstAction(WebCompatReporterAction.SendMoreInfoSubmitted::class) diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterTelemetryMiddlewareTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/webcompat/middleware/WebCompatReporterTelemetryMiddlewareTest.kt @@ -38,13 +38,13 @@ class WebCompatReporterTelemetryMiddlewareTest { @Test fun `WHEN send more info button is clicked THEN record send more info button telemetry`() { val store = createStore() - assertNull(Webcompatreporting.sendMoreInfo.testGetValue()) + assertNull(Webcompatreporting.addMoreInfo.testGetValue()) - store.dispatch(WebCompatReporterAction.SendMoreInfoClicked) + store.dispatch(WebCompatReporterAction.AddMoreInfoClicked) - val snapshot = Webcompatreporting.sendMoreInfo.testGetValue()!! + val snapshot = Webcompatreporting.addMoreInfo.testGetValue()!! assertEquals(1, snapshot.size) - assertEquals("send_more_info", snapshot.single().name) + assertEquals("add_more_info", snapshot.single().name) } @Test diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/webcompat/store/WebCompatReporterStoreTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/webcompat/store/WebCompatReporterStoreTest.kt @@ -169,7 +169,7 @@ class WebCompatReporterStoreTest { fun `WHEN the send more info button is clicked THEN the state remains the same`() { val expected = store.state - store.dispatch(WebCompatReporterAction.SendMoreInfoClicked) + store.dispatch(WebCompatReporterAction.AddMoreInfoClicked) assertEquals(expected, store.state) }