tor-browser

commit 874e87e769292c1dbc817cc03bdd54bb5e9caa82
parent b1607815744a24f6667b363e312dd466ca044c67
Author: Emilio Cobos Álvarez <emilio@crisal.io>
Date:   Thu, 16 Oct 2025 22:24:48 +0000

Bug 1994855 - Remove assert that doesn't hold. r=win-reviewers,handyman

This spike probably comes from bug 1933181, but that assert is wrong
afaict. It's not flushing and we're now creating the widget a bit later,
so there might be a popupframe without a widget more often.

Looking at the commit that introduced these, it wasn't clear these
asserts were correct to begin with.

  https://hg-edge.mozilla.org/mozilla-central/rev/5823cb0f699866c8672cce50cf8e1cbceadc43aa

I think the assert below (every widget hanging from a popup having an
hwnd) should hold.

Differential Revision: https://phabricator.services.mozilla.com/D268958

Diffstat:
M
widget/windows/SystemStatusBar.cpp
 | 
3
+--

1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/widget/windows/SystemStatusBar.cpp b/widget/windows/SystemStatusBar.cpp
@@ -186,8 +186,7 @@ LRESULT StatusBarEntry::OnMessage(HWND hWnd, UINT msg, WPARAM wp, LPARAM lp) {
     }
 
     nsIWidget* widget = popupFrame->GetNearestWidget();
-    MOZ_DIAGNOSTIC_ASSERT(widget);
-    if (!widget) {
+    if (NS_WARN_IF(!widget)) {
       return TRUE;
     }