tor-browser

commit 7d9b80848500fd113036e1f54316a4ce0863b6d2
parent 1b61694baee703d9c2f626f919693d5620d35a96
Author: Irene Ni <ini@mozilla.com>
Date:   Fri,  3 Oct 2025 19:47:05 +0000

Bug 1981338 - Allow cursor placement in task text field of New Tab Lists widget. r=home-newtab-reviewers,maxx

Differential Revision: https://phabricator.services.mozilla.com/D267464

Diffstat:
M
browser/extensions/newtab/content-src/components/Widgets/Lists/Lists.jsx
 | 
4
++--
M
browser/extensions/newtab/content-src/components/Widgets/Lists/_Lists.scss
 | 
1
+
M
browser/extensions/newtab/css/activity-stream.css
 | 
1
+
M
browser/extensions/newtab/data/content/activity-stream.bundle.js
 | 
5
+++--

4 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/browser/extensions/newtab/content-src/components/Widgets/Lists/Lists.jsx b/browser/extensions/newtab/content-src/components/Widgets/Lists/Lists.jsx
@@ -669,7 +669,7 @@ function Lists({ dispatch, handleUserInteraction }) {
         <moz-reorderable-list
           ref={reorderListRef}
           itemSelector="fieldset .task-type-tasks"
-          dragSelector=".checkbox-wrapper"
+          dragSelector=".checkbox-wrapper:has(.task-label)"
         >
           <fieldset>
             {/* Incomplete List  */}
@@ -823,7 +823,7 @@ function ListItem({
       key={task.id}
       onTransitionEnd={handleTransitionEnd}
     >
-      <div className="checkbox-wrapper">
+      <div className="checkbox-wrapper" key={isEditing}>
         <input
           type="checkbox"
           onChange={handleCheckboxChange}
diff --git a/browser/extensions/newtab/content-src/components/Widgets/Lists/_Lists.scss b/browser/extensions/newtab/content-src/components/Widgets/Lists/_Lists.scss
@@ -195,6 +195,7 @@
       max-width: 180px;
       border: none;
       border-radius: 0;
+      user-select: text;
 
       &:focus {
         outline: var(--focus-outline);
diff --git a/browser/extensions/newtab/css/activity-stream.css b/browser/extensions/newtab/css/activity-stream.css
@@ -4595,6 +4595,7 @@ dialog::after {
   max-width: 180px;
   border: none;
   border-radius: 0;
+  user-select: text;
 }
 .lists .task-item .edit-task:focus {
   outline: var(--focus-outline);
diff --git a/browser/extensions/newtab/data/content/activity-stream.bundle.js b/browser/extensions/newtab/data/content/activity-stream.bundle.js
@@ -13053,7 +13053,7 @@ function Lists({
   }, /*#__PURE__*/external_React_default().createElement("moz-reorderable-list", {
     ref: reorderListRef,
     itemSelector: "fieldset .task-type-tasks",
-    dragSelector: ".checkbox-wrapper"
+    dragSelector: ".checkbox-wrapper:has(.task-label)"
   }, /*#__PURE__*/external_React_default().createElement("fieldset", null, selectedList?.tasks.length >= 1 && selectedList.tasks.map((task, index) => /*#__PURE__*/external_React_default().createElement(ListItem, {
     type: TASK_TYPE.IN_PROGRESS,
     task: task,
@@ -13171,7 +13171,8 @@ function ListItem({
     key: task.id,
     onTransitionEnd: handleTransitionEnd
   }, /*#__PURE__*/external_React_default().createElement("div", {
-    className: "checkbox-wrapper"
+    className: "checkbox-wrapper",
+    key: isEditing
   }, /*#__PURE__*/external_React_default().createElement("input", {
     type: "checkbox",
     onChange: handleCheckboxChange,