tor-browser

commit 781eb0294d9ad538fa78cf5814eaee7dc4c898ff
parent e5876b09a3ca47ebdb7755030b244f9138ff5a80
Author: Jeff Muizelaar <jmuizelaar@mozilla.com>
Date:   Fri, 24 Oct 2025 14:23:18 +0000

Bug 1993095. Don't include "application/x-moz-file" in types. r=tschuster

The existance of kFileMime ("application/x-moz-file") in types
is breaking drag and drop on fiverr.com. We don't seem to need it.

Differential Revision: https://phabricator.services.mozilla.com/D268167

Diffstat:
M
browser/base/content/test/general/browser_clipboard_pastefile.js
 | 
8
++------
M
browser/base/content/test/general/clipboard_pastefile.html
 | 
6
++----
M
dom/events/DataTransferItemList.cpp
 | 
10
+++-------

3 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/browser/base/content/test/general/browser_clipboard_pastefile.js b/browser/base/content/test/general/browser_clipboard_pastefile.js
@@ -78,13 +78,9 @@ add_task(async function () {
       "paste",
       function (event) {
         let dt = event.clipboardData;
-        is(dt.types.length, 3, "number of types");
+        is(dt.types.length, 2, "number of types");
         ok(dt.types.includes("text/plain"), "text/plain exists in types");
-        ok(
-          dt.types.includes("application/x-moz-file"),
-          "application/x-moz-file exists in types"
-        );
-        is(dt.types[2], "Files", "Last type should be 'Files'");
+        is(dt.types[1], "Files", "Last type should be 'Files'");
         ok(
           dt.mozTypesAt(0).contains("text/plain"),
           "text/plain exists in mozTypesAt"
diff --git a/browser/base/content/test/general/clipboard_pastefile.html b/browser/base/content/test/general/clipboard_pastefile.html
@@ -22,11 +22,9 @@ function is(a, b, msg) {
 async function checkPasteHelper(event) {
   let dt = event.clipboardData;
 
-  is(dt.types.length, 2, "Correct number of types");
+  is(dt.types.length, 1, "Correct number of types");
 
-  // TODO: Remove application/x-moz-file from content.
-  is(dt.types[0], "application/x-moz-file", "First type")
-  is(dt.types[1], "Files", "Last type must be Files");
+  is(dt.types[0], "Files", "Last type must be Files");
 
   is(dt.getData("text/plain"), "", "text/plain found with getData");
   is(dt.getData("application/x-moz-file"), "", "application/x-moz-file found with getData");
diff --git a/dom/events/DataTransferItemList.cpp b/dom/events/DataTransferItemList.cpp
@@ -450,13 +450,9 @@ void DataTransferItemList::GetTypes(nsTArray<nsString>& aTypes,
       continue;
     }
 
-    // NOTE: The reason why we get the internal type here is because we want
-    // kFileMime to appear in the types list for backwards compatibility
-    // reasons.
-    nsAutoString type;
-    item->GetInternalType(type);
-    if (item->Kind() != DataTransferItem::KIND_FILE ||
-        type.EqualsASCII(kFileMime)) {
+    if (item->Kind() != DataTransferItem::KIND_FILE) {
+      nsAutoString type;
+      item->GetType(type);
       aTypes.AppendElement(type);
     }
   }