tor-browser

commit 75b5b74832e62fa4129ee70d450863ff13e3e6d5
parent 754a296a1afb5bf7ce77c3889188bfeb5139b172
Author: rmalicdem <rmalicdem@mozilla.com>
Date:   Wed, 10 Dec 2025 16:37:40 +0000

Bug 1993707 - Fix toolbar site info telemetry item identifier r=android-reviewers,Roger

Differential Revision: https://phabricator.services.mozilla.com/D275674

Diffstat:
M
mobile/android/fenix/app/metrics.yaml
 | 
2
+-
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt
 | 
1
+
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddleware.kt
 | 
6
+++---
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/telemetry/ToolbarTelemetryConstants.kt
 | 
1
-
M
mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddlewareTest.kt
 | 
2
+-

5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/mobile/android/fenix/app/metrics.yaml b/mobile/android/fenix/app/metrics.yaml
@@ -14435,7 +14435,7 @@ toolbar:
           add_new_tab, add_new_tab_long_press, add_new_private_tab, tab_counter, tab_counter_long_press,
           menu, share, clear, refresh, stop, add_bookmark, edit_bookmark, security_indicator, qr_code,
           home, reader_mode, microphone, open_in_fenix, close, site_custom, search_engine_selector,
-          search_engine_selected, site_info.
+          search_engine_selected.
         type: string
       extra:
         description: |
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt
@@ -678,6 +678,7 @@ abstract class BaseBrowserFragment :
             view = view,
         )
 
+        // Site info telemetry for legacy toolbar
         (browserToolbarView as? BrowserToolbarView)?.toolbar?.display?.setOnSiteInfoClickedListener {
             showQuickSettingsDialog()
             Toolbar.buttonTapped.record(
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddleware.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddleware.kt
@@ -40,8 +40,8 @@ import org.mozilla.fenix.telemetry.ACTION_NAVIGATE_FORWARD_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_NAVIGATE_FORWARD_LONG_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_READER_MODE_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_REFRESH_CLICKED
+import org.mozilla.fenix.telemetry.ACTION_SECURITY_INDICATOR_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_SHARE_CLICKED
-import org.mozilla.fenix.telemetry.ACTION_SITE_INFO_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_STOP_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_TAB_COUNTER_CLICKED
 import org.mozilla.fenix.telemetry.ACTION_TAB_COUNTER_LONG_CLICKED
@@ -112,7 +112,7 @@ class BrowserToolbarTelemetryMiddleware : Middleware<BrowserToolbarState, Browse
                 trackToolbarEvent(ToolbarActionRecord.HomepageClicked, action.source)
             }
             is SiteInfoClicked -> {
-                trackToolbarEvent(ToolbarActionRecord.SiteInfoClicked, action.source)
+                trackToolbarEvent(ToolbarActionRecord.SecurityIndicatorClicked, action.source)
             }
             else -> {}
         }
@@ -138,7 +138,7 @@ class BrowserToolbarTelemetryMiddleware : Middleware<BrowserToolbarState, Browse
         data object ShareClicked : ToolbarActionRecord(ACTION_SHARE_CLICKED)
         data object ReaderModeClicked : ToolbarActionRecord(ACTION_READER_MODE_CLICKED)
         data object HomepageClicked : ToolbarActionRecord(ACTION_HOME_CLICKED)
-        data object SiteInfoClicked : ToolbarActionRecord(ACTION_SITE_INFO_CLICKED)
+        data object SecurityIndicatorClicked : ToolbarActionRecord(ACTION_SECURITY_INDICATOR_CLICKED)
     }
 
     private fun trackToolbarEvent(
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/telemetry/ToolbarTelemetryConstants.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/telemetry/ToolbarTelemetryConstants.kt
@@ -39,4 +39,3 @@ const val ACTION_SITE_CUSTOM_CLICKED = "site_custom"
 const val ACTION_STOP_CLICKED = "stop"
 const val ACTION_TAB_COUNTER_CLICKED = "tab_counter"
 const val ACTION_TAB_COUNTER_LONG_CLICKED = "tab_counter_long_press"
-const val ACTION_SITE_INFO_CLICKED = "site_info"
diff --git a/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddlewareTest.kt b/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/toolbar/BrowserToolbarTelemetryMiddlewareTest.kt
@@ -165,7 +165,7 @@ class BrowserToolbarTelemetryMiddlewareTest {
     @Test
     fun `WHEN site info is clicked THEN record page start telemetry`() {
         buildStore.dispatch(SiteInfoClicked)
-        assertTelemetryRecorded(Source.AddressBar.PageStart, item = ToolbarActionRecord.SiteInfoClicked.action)
+        assertTelemetryRecorded(Source.AddressBar.PageStart, item = ToolbarActionRecord.SecurityIndicatorClicked.action)
     }
 
     private fun assertTelemetryRecorded(