commit 74d9ba0e28f56b21e200c35048ba0778aaf413a7 parent 520ea2f0cccf8eb96772fd89753d1f92ba768e77 Author: Alison Maher <almaher@microsoft.com> Date: Tue, 21 Oct 2025 10:38:51 +0000 Bug 1995432 [wpt PR 55562] - [Masonry] Fix row/column-automatic-minimum-for-auto.html, a=testonly Automatic update from web-platform-tests [Masonry] Fix row/column-automatic-minimum-for-auto.html These tests were failing since there were styles needed from grid.css which I wasn't including in these tests. Adding this back in fixed all tests, but one in the row test case - this test in particular needed updated expectations from what was expected for columns, which has been updated accordingly. Bug: 343257585 Change-Id: If7302bacacec3f656e990a4ec6f97f7101d91e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7038889 Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1532633} -- wpt-commits: f064c28baf006b3f999fe7550822adbd82e4688e wpt-pr: 55562 Diffstat:
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/testing/web-platform/tests/css/css-grid/masonry/tentative/items/column-automatic-minimum-for-auto.html b/testing/web-platform/tests/css/css-grid/masonry/tentative/items/column-automatic-minimum-for-auto.html @@ -4,6 +4,7 @@ <link rel="help" href="https://drafts.csswg.org/css-grid/#layout-algorithm"> <link rel="help" href="https://drafts.csswg.org/css-sizing-3/#automatic-minimum-size"> <meta name="assert" content="Check that masonry item's 'min-width' is honored when sizing 'auto' columns."> +<link rel="stylesheet" href="/css/support/grid.css"> <link rel="stylesheet" href="/fonts/ahem.css"> <style> @@ -74,7 +75,7 @@ <div class="constrainedContainer"> <div class="masonry gridAuto" id="gridAutoMultipleItems"> <div class="firstRowFirstColumn minWidth30">XX</div> - <div class="secondRowFirstColumn minWidth20"">XXXX XXXX</div> + <div class="secondRowFirstColumn minWidth20">XXXX XXXX</div> <div class="thirdRowAutoColumn minWidth10">XX XXXXX X</div> </div> </div> diff --git a/testing/web-platform/tests/css/css-grid/masonry/tentative/items/row-automatic-minimum-for-auto.html b/testing/web-platform/tests/css/css-grid/masonry/tentative/items/row-automatic-minimum-for-auto.html @@ -3,7 +3,8 @@ <link rel="author" title="Alison Maher" href="mailto:almaher@microsoft.com"> <link rel="help" href="https://drafts.csswg.org/css-grid/#layout-algorithm"> <link rel="help" href="https://drafts.csswg.org/css-sizing-3/#automatic-minimum-size"> -<meta name="assert" content="Check that masonry item's 'min-width' is honored when sizing 'auto' rows."> +<meta name="assert" content="Check that masonry item's 'min-height' is honored when sizing 'auto' rows."> +<link rel="stylesheet" href="/css/support/grid.css"> <link rel="stylesheet" href="/fonts/ahem.css"> <style> @@ -63,7 +64,7 @@ <div class="masonry gridAuto constrainedContainer" id="gridAutoMultipleItems"> <div class="firstRowFirstColumn minHeight60">X<br>X</div> - <div class="firstRowSecondColumn minHeight20"">XXX<br>X<br>XX<br>XX</div> + <div class="firstRowSecondColumn minHeight20">XXX<br>X<br>XX<br>XX</div> <div class="firstRowAutoColumn minConstrainedContainer height50"></div> </div> @@ -245,7 +246,7 @@ document.fonts.ready.then(() => { testGridRowsValues('gridAutoAndAutoFixedHeightChildren', '200px 50px'); }, 'Check that min-height is honored when sizing auto rows.'); test(() => { - testGridRowsValues('gridAutoAndAutoOneSpanningOneNonSpannig', '10px 40px'); + testGridRowsValues('gridAutoAndAutoOneSpanningOneNonSpannig', '20px 30px'); testGridRowsValues('gridAutoAndAutoOneSpanningMultipleNonSpanning', '40px 20px'); testGridRowsValues('gridAutoAndMinMaxAutoAutoOneSpanningOneNonSpanning', '40px 30px'); testGridRowsValues('gridAutoAndMinMaxAutoAutoMultipleSpanning', '35px 35px');