tor-browser

commit 739e0962df7fed95b8539c97cc8c658de07021b6
parent 2fa36d838798bc3c5741e436c9f161a37fa7468f
Author: Catherine Meade <cmeade@mozilla.com>
Date:   Wed,  8 Oct 2025 14:28:22 +0000

Bug 1991745 - Border linting allows null properties in shorthand r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D267630

Diffstat:
M
toolkit/content/widgets/menupopup.css
 | 
2
--
M
tools/lint/stylelint/stylelint-plugin-mozilla/rules/use-border-color-tokens.mjs
 | 
1
+
M
tools/lint/stylelint/stylelint-plugin-mozilla/tests/use-border-color-tokens.tests.mjs
 | 
8
++++++++

3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/toolkit/content/widgets/menupopup.css b/toolkit/content/widgets/menupopup.css
@@ -12,7 +12,5 @@
   overscroll-behavior: none;
   margin: 0;
   padding: 0;
-  /* See bug 1991745 for the ignore below */
-  /* stylelint-disable-next-line stylelint-plugin-mozilla/use-border-color-tokens */
   border: 0;
 }
diff --git a/tools/lint/stylelint/stylelint-plugin-mozilla/rules/use-border-color-tokens.mjs b/tools/lint/stylelint/stylelint-plugin-mozilla/rules/use-border-color-tokens.mjs
@@ -41,6 +41,7 @@ const ALLOW_LIST = createAllowList([
   "auto",
   "normal",
   "none",
+  "0",
 ]);
 
 const SHORTHAND_CSS_PROPERTIES = [
diff --git a/tools/lint/stylelint/stylelint-plugin-mozilla/tests/use-border-color-tokens.tests.mjs b/tools/lint/stylelint/stylelint-plugin-mozilla/tests/use-border-color-tokens.tests.mjs
@@ -81,6 +81,14 @@ testRule({
       description: "Using currentColor is valid.",
     },
     {
+      code: ".a { border: none; }",
+      description: "Using none is valid.",
+    },
+    {
+      code: ".a { border: 0; }",
+      description: "Using 0 is valid.",
+    },
+    {
       code: ".a { border: 1px solid transparent; }",
       description: "Using transparent in shorthand is valid.",
     },